From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 727481FA14 for ; Sat, 27 May 2017 01:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032623AbdE0BWv (ORCPT ); Fri, 26 May 2017 21:22:51 -0400 Received: from avasout08.plus.net ([212.159.14.20]:51724 "EHLO avasout08.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945314AbdE0BUt (ORCPT ); Fri, 26 May 2017 21:20:49 -0400 Received: from [10.0.2.15] ([143.159.212.80]) by avasout08 with smtp id RDLh1v0011keHif01DLiMw; Sat, 27 May 2017 02:20:42 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.2 cv=FLJr/6gs c=1 sm=1 tr=0 a=n+zECcf3rkBNBoU0FNF4VQ==:117 a=n+zECcf3rkBNBoU0FNF4VQ==:17 a=IkcTkHD0fZMA:10 a=LMaSFMIIojMiEG72jHgA:9 a=QEXdDO2ut3YA:10 X-AUTH: ramsayjones@:2500 Subject: Re: [GSoC][PATCH v5 3/3] submodule: port subcommand foreach from shell to C To: Johannes Sixt , Prathamesh Chavan Cc: git@vger.kernel.org, bmwill@google.com, christian.couder@gmail.com, sbeller@google.com References: <20170521125814.26255-2-pc44800@gmail.com> <20170526151713.10974-1-pc44800@gmail.com> <20170526151713.10974-3-pc44800@gmail.com> <83801d05-e3a9-b7e4-8f29-cd8172257dac@kdbg.org> From: Ramsay Jones Message-ID: <41781ba1-2284-cc5d-8736-bb87d580f5bf@ramsayjones.plus.com> Date: Sat, 27 May 2017 02:20:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <83801d05-e3a9-b7e4-8f29-cd8172257dac@kdbg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 26/05/17 22:54, Johannes Sixt wrote: > Am 26.05.2017 um 17:17 schrieb Prathamesh Chavan: >> + argv_array_pushf(&cp.env_array, "path=%s", list_item->name); > > Not good! On Windows, environment variables are case insensitive. The environment variable "path" has a very special purpose, although it is generally spelled "PATH" (actually "Path" on Windows). > > Lowercase "path" may have worked as long as it was only used in a shell script (and perhaps only by lucky coincidence), but this I can pretty much guarantee to fail. (I haven't tested it, though.) > > The correct fix can only be to rename this variable here and in shell scripts that need the value that is set here. Yeah, I already pointed to commit 64394e3ae9 (but it seems not to have registered!), but ... I tried provoking a failure on cygwin, and I couldn't get it to fail! Since Johannes told me about Gfw fork of the msys-runtime, I didn't even attempt to try and provoke a failure on MSYS2/MinGW. So, maybe it's fixed (no I'm not convinced either) ... ATB, Ramsay Jones