All of lore.kernel.org
 help / color / mirror / Atom feed
From: "akuster" <akuster808@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [Dunfell patch review 07/11] ceres-solver: prevent fetching git hook during do_configure
Date: Mon,  5 Apr 2021 07:54:20 -0700	[thread overview]
Message-ID: <4178447710d7a36badf2323e8cf3039a5cbaf3a1.1617634345.git.akuster808@gmail.com> (raw)
In-Reply-To: <cover.1617634345.git.akuster808@gmail.com>

From: Martin Jansa <Martin.Jansa@gmail.com>

* today I've found 2 jenkins jobs stuck way too long sitting in this do_configure
  Bitbake still alive (5000s)
  Bitbake still alive (10000s)
  Bitbake still alive (15000s)
  Bitbake still alive (20000s)
  Bitbake still alive (25000s)
  Bitbake still alive (30000s)
  ... manually killed, the CMake ...
  ERROR: ceres-solver-1.14.0-r0 do_configure: Execution of 'ceres-solver/1.14.0-r0/temp/run.do_configure.39438' failed with exit code 143:
  ...
  | -- Detected Ceres being used as a git submodule, adding commit hook for Gerrit to: ceres-solver/1.14.0-r0/git/.git
  | ceres-solver/1.14.0-r0/temp/run.do_configure.39438: line 213: 39485 Terminated              cmake -G 'Ninja' -DCMAKE_MAKE_PROGRAM=ninja ...

  I've seen it with dunfell and gatesgarth, but master has the same
  ADD_GERRIT_COMMIT_HOOK function (just in newer ceres-solver release),
  so probably needs the same.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 .../recipes-support/ceres-solver/ceres-solver_1.14.0.bb   | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.0.bb b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.0.bb
index ac463038aac..105610be5aa 100644
--- a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.0.bb
+++ b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.0.bb
@@ -13,6 +13,14 @@ S = "${WORKDIR}/git"
 
 inherit cmake
 
+do_configure_prepend() {
+    # otherwise https://github.com/ceres-solver/ceres-solver/blob/0b748597889f460764f6c980a00c6f502caa3875/cmake/AddGerritCommitHook.cmake#L68
+    # will try to fetch https://ceres-solver-review.googlesource.com/tools/hooks/commit-msg durind do_configure
+    # which sometimes gets stuck (as there is no TIMEOUT set in DOWNLOAD)
+    # and we really don't need Gerrit's Change-Id tags when just building this
+    touch ${S}/.git/hooks/commit-msg
+}
+
 # We don't want path to eigen3 in ceres-solver RSS to be
 # used by components which use CeresConfig.cmake from their
 # own RSS
-- 
2.17.1


  parent reply	other threads:[~2021-04-05 14:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 14:54 [Dunfell patch review 00/11] April 05 akuster
2021-04-05 14:54 ` [Dunfell patch review 01/11] thin-provisioning-tools: switch branch from master to main akuster
2021-04-05 14:54 ` [Dunfell patch review 02/11] freerdp: Add missing libxkbcommon WL dependency akuster
2021-04-05 14:54 ` [Dunfell patch review 03/11] neon: Add ptest akuster
2021-04-05 14:54 ` [Dunfell patch review 04/11] opencv: refresh patches with devtool to apply cleanly akuster
2021-04-05 14:54 ` [Dunfell patch review 05/11] guider: Upgrade to 3.9.7 akuster
2021-04-05 14:54 ` [Dunfell patch review 06/11] Update commit for version 3.9.7 akuster
2021-04-05 14:54 ` akuster [this message]
2021-04-05 14:54 ` [Dunfell patch review 08/11] packagegroup-meta-oe: include nodejs without meta-python2 conditional akuster
2021-04-05 14:54 ` [Dunfell patch review 09/11] packagegroup-meta-oe: move the packages depending on meta-python2 to separate packages akuster
2021-04-05 14:54 ` [Dunfell patch review 10/11] packagegroup-meta-oe: add guider akuster
2021-04-05 14:54 ` [Dunfell patch review 11/11] wireguard: fix build issue with updated 5.4 kernel akuster
2021-04-06 16:37 ` [oe] [Dunfell patch review 00/11] April 05 Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4178447710d7a36badf2323e8cf3039a5cbaf3a1.1617634345.git.akuster808@gmail.com \
    --to=akuster808@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.