[bug report] compiling error with latest linux-block/for-next

[bug report] compiling error with latest linux-block/for-next

[Yi Zhang]

Hello
I found below compiling error[2] on latest linux-block/for-next[1],
pls check it.

[1]
b8b914c06a6f (HEAD, origin/for-next) Merge branch
'for-5.20/drivers-post' into for-next

[2]
In file included from ./include/linux/export.h:33,
                 from ./include/linux/linkage.h:7,
                 from ./include/linux/kernel.h:17,
                 from io_uring/notif.c:1:
io_uring/notif.c: In function ‘io_alloc_notif’:
io_uring/notif.c:52:23: error: implicit declaration of function
‘io_alloc_req_refill’; did you mean ‘io_rsrc_refs_refill’?
[-Werror=implicit-function-declaration]
   52 |         if (unlikely(!io_alloc_req_refill(ctx)))
      |                       ^~~~~~~~~~~~~~~~~~~
./include/linux/compiler.h:78:45: note: in definition of macro ‘unlikely’
   78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
      |                                             ^
  CC      kernel/trace/trace_seq.o
  CC      drivers/mfd/stmpe.o
io_uring/notif.c:54:17: error: implicit declaration of function
‘io_alloc_req’; did you mean ‘xa_alloc_irq’?
[-Werror=implicit-function-declaration]
   54 |         notif = io_alloc_req(ctx);
      |                 ^~~~~~~~~~~~
      |                 xa_alloc_irq
io_uring/notif.c:54:15: warning: assignment to ‘struct io_kiocb *’
from ‘int’ makes pointer from integer without a cast
[-Wint-conversion]
   54 |         notif = io_alloc_req(ctx);
      |               ^



-- 
Best Regards,
  Yi Zhang

Re: [bug report] compiling error with latest linux-block/for-next

[Jens Axboe]

On 7/27/22 9:18 AM, Yi Zhang wrote:
> Hello
> I found below compiling error[2] on latest linux-block/for-next[1],
> pls check it.
> 
> [1]
> b8b914c06a6f (HEAD, origin/for-next) Merge branch
> 'for-5.20/drivers-post' into for-next
> 
> [2]
> In file included from ./include/linux/export.h:33,
>                  from ./include/linux/linkage.h:7,
>                  from ./include/linux/kernel.h:17,
>                  from io_uring/notif.c:1:
> io_uring/notif.c: In function ?io_alloc_notif?:
> io_uring/notif.c:52:23: error: implicit declaration of function
> ?io_alloc_req_refill?; did you mean ?io_rsrc_refs_refill??
> [-Werror=implicit-function-declaration]
>    52 |         if (unlikely(!io_alloc_req_refill(ctx)))
>       |                       ^~~~~~~~~~~~~~~~~~~
> ./include/linux/compiler.h:78:45: note: in definition of macro ?unlikely?
>    78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
>       |                                             ^
>   CC      kernel/trace/trace_seq.o
>   CC      drivers/mfd/stmpe.o
> io_uring/notif.c:54:17: error: implicit declaration of function
> ?io_alloc_req?; did you mean ?xa_alloc_irq??
> [-Werror=implicit-function-declaration]
>    54 |         notif = io_alloc_req(ctx);
>       |                 ^~~~~~~~~~~~
>       |                 xa_alloc_irq
> io_uring/notif.c:54:15: warning: assignment to ?struct io_kiocb *?
> from ?int? makes pointer from integer without a cast
> [-Wint-conversion]
>    54 |         notif = io_alloc_req(ctx);
>       |               ^

This is fixed in the current tree.

-- 
Jens Axboe