From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B552CC05027 for ; Fri, 3 Feb 2023 16:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233068AbjBCQ16 (ORCPT ); Fri, 3 Feb 2023 11:27:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233070AbjBCQ14 (ORCPT ); Fri, 3 Feb 2023 11:27:56 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3066A6BA8; Fri, 3 Feb 2023 08:27:46 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 21D0E188387C; Fri, 3 Feb 2023 16:27:44 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 0594C250007B; Fri, 3 Feb 2023 16:27:44 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id EA3F591201E4; Fri, 3 Feb 2023 16:27:43 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Fri, 03 Feb 2023 17:27:43 +0100 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-2-netdev@kapio-technology.com> <766efaf94fcb6362c5ceb176ad7955f1@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <4188a35c3c260d8ea2b5f8b2ac0ae6b2@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-02-03 17:14, Ido Schimmel wrote: > > OK, so can't this hunk: > > ``` > if (fdb_info->is_dyn) > fdb_flags |= DSA_FDB_FLAG_DYNAMIC; > ``` > > Become: > > ``` > if (fdb_info->is_dyn && !fdb_info->added_by_user) > fdb_flags |= DSA_FDB_FLAG_DYNAMIC; > ``` > > ? > > Then there is no need to fold 'added_by_user' into 'is_dyn' in the > bridge driver. I *think* this is the change Vladimir asked you to do. I suppose you mean?: if (fdb_info->is_dyn && fdb_info->added_by_user) fdb_flags |= DSA_FDB_FLAG_DYNAMIC; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42529C61DA4 for ; Fri, 3 Feb 2023 16:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xii9M+iulryZKlsu+n4SpPoPrgUByobEzCT+di27EeM=; b=2iVFtNv+e5RwijM6tdL4kNriEI N7ehIraEpgIDnt1jEpd8MIZgJBZUdjh0CGnCURxQ0UEMaV9ozTeaBwA4jrqn8A3kBU4BSEYK8Iooz i4PPZ0+blLAFHN1vJpxM63e6wvcf+Vku/zYsRkfit5RKTUcYgOxjZPnt6KCFZDInXnJ89iLq7lqvs Vm8dGCI/0FgA/inz4E5j1rsY++QDeJC00hck5de3gWh9Vtwfo814UNNbLCGRInCIZve7TkxObxlSf Ua1enI0SsGOcgegdzg5QR6NAMZREQg0osy5H0ELf51ODzxLTHyjUPDaAR38J/DeMepGp0SaRB0X2V m+ftKzOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyut-002uoz-7v; Fri, 03 Feb 2023 16:27:59 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyup-002uma-8e; Fri, 03 Feb 2023 16:27:56 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 21D0E188387C; Fri, 3 Feb 2023 16:27:44 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 0594C250007B; Fri, 3 Feb 2023 16:27:44 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id EA3F591201E4; Fri, 3 Feb 2023 16:27:43 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Fri, 03 Feb 2023 17:27:43 +0100 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-2-netdev@kapio-technology.com> <766efaf94fcb6362c5ceb176ad7955f1@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <4188a35c3c260d8ea2b5f8b2ac0ae6b2@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_082755_491909_60E33560 X-CRM114-Status: UNSURE ( 8.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-02-03 17:14, Ido Schimmel wrote: > > OK, so can't this hunk: > > ``` > if (fdb_info->is_dyn) > fdb_flags |= DSA_FDB_FLAG_DYNAMIC; > ``` > > Become: > > ``` > if (fdb_info->is_dyn && !fdb_info->added_by_user) > fdb_flags |= DSA_FDB_FLAG_DYNAMIC; > ``` > > ? > > Then there is no need to fold 'added_by_user' into 'is_dyn' in the > bridge driver. I *think* this is the change Vladimir asked you to do. I suppose you mean?: if (fdb_info->is_dyn && fdb_info->added_by_user) fdb_flags |= DSA_FDB_FLAG_DYNAMIC; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 29ABB821D4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0C58E82160 MIME-Version: 1.0 Date: Fri, 03 Feb 2023 17:27:43 +0100 From: netdev@kapio-technology.com In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-2-netdev@kapio-technology.com> <766efaf94fcb6362c5ceb176ad7955f1@kapio-technology.com> Message-ID: <4188a35c3c260d8ea2b5f8b2ac0ae6b2@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Russell King , Roopa Prabhu , kuba@kernel.org, Paolo Abeni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev@vger.kernel.org, open list , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , Vladimir Oltean , davem@davemloft.net On 2023-02-03 17:14, Ido Schimmel wrote: > > OK, so can't this hunk: > > ``` > if (fdb_info->is_dyn) > fdb_flags |= DSA_FDB_FLAG_DYNAMIC; > ``` > > Become: > > ``` > if (fdb_info->is_dyn && !fdb_info->added_by_user) > fdb_flags |= DSA_FDB_FLAG_DYNAMIC; > ``` > > ? > > Then there is no need to fold 'added_by_user' into 'is_dyn' in the > bridge driver. I *think* this is the change Vladimir asked you to do. I suppose you mean?: if (fdb_info->is_dyn && fdb_info->added_by_user) fdb_flags |= DSA_FDB_FLAG_DYNAMIC;