From: Pavel Begunkov <asml.silence@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org, Kanchan Joshi <joshi.k@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>
Subject: Re: [PATCH 0/2] Remove kiocb ki_complete
Date: Thu, 9 Jul 2020 16:59:34 +0300 [thread overview]
Message-ID: <418c57cb-04a2-d324-4b9a-59106427dfe5@gmail.com> (raw)
In-Reply-To: <20200709135311.GE12769@casper.infradead.org>
On 09/07/2020 16:53, Matthew Wilcox wrote:
> On Thu, Jul 09, 2020 at 04:49:51PM +0300, Pavel Begunkov wrote:
>> On 09/07/2020 16:43, Matthew Wilcox wrote:
>>> On Thu, Jul 09, 2020 at 04:37:59PM +0300, Pavel Begunkov wrote:
>>>> Kanchan, could you take a look if you can hide it in req->cflags?
>>>
>>> No, that's not what cflags are for. And besides, there's only 32 bits
>>> there.
>>
>> It's there to temporarily store cqe->cflags, if a request can't completed
>> right away. And req->{result,user_data,cflags} are basically an CQE inside
>> io_kiocb.
>>
>> So, it is there exactly for that reason, and whatever way it's going to be
>> encoded in an CQE, io_kiocb can fit it. That was my point.
>
> But it's not going to be encoded in the CQE. Perhaps you should go back to
> the older thread and read the arguments there.
Ok, if the thread is stopped on the version with indirection. I just looked the
last sent patch.
If so, we can also store offset before adding an CQE and getting by with local
vars only. Just a thought.
--
Pavel Begunkov
next prev parent reply other threads:[~2020-07-09 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 22:26 [PATCH 0/2] Remove kiocb ki_complete Matthew Wilcox (Oracle)
2020-07-08 22:26 ` [PATCH 1/2] fs: Abstract calling the kiocb completion function Matthew Wilcox (Oracle)
2020-07-08 22:37 ` Jens Axboe
2020-07-08 22:40 ` Matthew Wilcox
2020-07-08 22:50 ` Jens Axboe
2020-07-08 22:26 ` [PATCH 2/2] fs: Remove kiocb->ki_complete Matthew Wilcox (Oracle)
2020-07-08 22:38 ` Jens Axboe
2020-07-09 3:25 ` Jens Axboe
2020-07-09 5:23 ` kernel test robot
2020-07-09 5:23 ` kernel test robot
2020-07-08 22:33 ` [PATCH 0/2] Remove kiocb ki_complete Jens Axboe
2020-07-09 10:17 ` Christoph Hellwig
2020-07-09 11:10 ` Matthew Wilcox
2020-07-09 13:26 ` Christoph Hellwig
2020-07-09 13:32 ` Matthew Wilcox
2020-07-09 13:53 ` Jens Axboe
2020-07-09 13:37 ` Pavel Begunkov
2020-07-09 13:43 ` Matthew Wilcox
2020-07-09 13:49 ` Pavel Begunkov
2020-07-09 13:53 ` Matthew Wilcox
2020-07-09 13:59 ` Pavel Begunkov [this message]
2020-07-09 13:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418c57cb-04a2-d324-4b9a-59106427dfe5@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.