From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Date: Tue, 09 Nov 2004 22:28:15 +0000 Subject: Re: [KJ] [PATCH] convert airo wireless driver to module_param Message-Id: <4191447F.3000500@osdl.org> List-Id: References: <20041109212957.GA9496@dice.seeling33.de> In-Reply-To: <20041109212957.GA9496@dice.seeling33.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Stefan Sperling wrote: > On Tue, Nov 09, 2004 at 01:38:18PM -0800, Randy.Dunlap wrote: > >>Stefan Sperling wrote: > > > >>Rusty's first set of module_param() conversion patches, which >>I mostly followed, use permission (last parameter) of 0 >>(not visible in sysfs) except for fields that can be modified. >>Often this is a "debug" or "verbose" flag or bitmask. > > > Not in this one: > > http://marc.theaimsgroup.com/?l=linux-kernel&m9826168201622&w=2 True. That's why we post patches and have review (one reason). > This is the reference link from the janitors TODO file. > Everything 0444, except a debug flag, which is 0644. > > Can someone please clarify the "official guidelines" for > module parameter permissions in sysfs? Shall I use 0 or 0444 > for parameters that should not be modified, i.e. everything > except debug and verbosity flags? Compare with Rusty's (other) conversion patch (with wrap): http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/remove-module_parm-from-allyesconfig-almost.patch Greg KH just told me (paraphrased): if it can be modified on the fly, put it into sysfs (permissions non-zero). If it cannot be modified, make permissions = 0. -- ~Randy _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors