From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755910AbeEaRYX (ORCPT ); Thu, 31 May 2018 13:24:23 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:35608 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755787AbeEaRYV (ORCPT ); Thu, 31 May 2018 13:24:21 -0400 X-Google-Smtp-Source: ADUXVKKKllaIBXGvPHJlDYQ7Y7uLvApImuAfPRa/8QREnt83toe4TpUXXBHBWvis69xFzUWhSrv6HA== Subject: Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Florian Fainelli , linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org, Tony Lindgren , Laura Abbott , Scott Branden , Jon Mason , Ray Jui , BCM Kernel Feedback , =?UTF-8?Q?Cl=c3=a9ment_Peron?= References: <20180530131956.13972-1-peron.clem@gmail.com> <93c2d07a-9344-ed39-261e-11084067a3fa@broadcom.com> From: Ray Jui Message-ID: <41bbf801-f060-2056-4015-b4d05c6831bb@broadcom.com> Date: Thu, 31 May 2018 10:24:16 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/2018 1:22 AM, Clément Péron wrote: > Hi Rai, > > On Wed, 30 May 2018 at 19:25, Ray Jui wrote: >> >> Hi Clément, >> >> Correct me if I'm wrong, but I thought the trend is to move to use >> earlycon that can be activated from kernel command line for early print >> before the serial driver is loaded. >> >> Have you tried earlcon? > No, only tested this method. > > Thanks, > Clement > If I remember it correctly, I think the trend is to use earlycon. There are obvious shortcomings by making this configuration compile time based. >> >> Thanks, >> >> Ray >> >> On 5/30/2018 6:19 AM, Clément Péron wrote: >>> From: Clément Peron >>> >>> Broadcom Iproc SoCs typically use the UART3 for >>> debug/console, provide a known good location for that. >>> >>> Signed-off-by: Clément Peron >>> --- >>> >>> arch/arm/Kconfig.debug | 12 +++++++++++- >>> 1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug >>> index 199ebc1c4538..4ea9d5793b91 100644 >>> --- a/arch/arm/Kconfig.debug >>> +++ b/arch/arm/Kconfig.debug >>> @@ -207,6 +207,14 @@ choice >>> depends on ARCH_BCM_HR2 >>> select DEBUG_UART_8250 >>> >>> + config DEBUG_BCM_IPROC_UART3 >>> + bool "Kernel low-level debugging on BCM IPROC UART3" >>> + depends on ARCH_BCM_CYGNUS >>> + select DEBUG_UART_8250 >>> + help >>> + Say Y here if you want the debug print routines to direct >>> + their output to the third serial port on these devices. >>> + >>> config DEBUG_BCM_KONA_UART >>> bool "Kernel low-level debugging messages via BCM KONA UART" >>> depends on ARCH_BCM_MOBILE >>> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS >>> default 0x18000400 if DEBUG_BCM_HR2 >>> default 0x18010000 if DEBUG_SIRFATLAS7_UART0 >>> default 0x18020000 if DEBUG_SIRFATLAS7_UART1 >>> + default 0x18023000 if DEBUG_BCM_IPROC_UART3 >>> default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1 >>> default 0x20001000 if DEBUG_HIP01_UART >>> default 0x20060000 if DEBUG_RK29_UART0 >>> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT >>> default 0xf1002000 if DEBUG_MT8127_UART0 >>> default 0xf1006000 if DEBUG_MT6589_UART0 >>> default 0xf1009000 if DEBUG_MT8135_UART3 >>> + default 0xf1023000 if DEBUG_BCM_IPROC_UART3 >>> default 0xf11f1000 if DEBUG_VERSATILE >>> default 0xf1600000 if DEBUG_INTEGRATOR >>> default 0xf1c28000 if DEBUG_SUNXI_UART0 >>> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD >>> DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \ >>> DEBUG_ALPINE_UART0 || \ >>> DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \ >>> - DEBUG_DAVINCI_DA8XX_UART2 || \ >>> + DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \ >>> DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 >>> >>> config DEBUG_UART_8250_PALMCHIP >>> From mboxrd@z Thu Jan 1 00:00:00 1970 From: ray.jui@broadcom.com (Ray Jui) Date: Thu, 31 May 2018 10:24:16 -0700 Subject: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses In-Reply-To: References: <20180530131956.13972-1-peron.clem@gmail.com> <93c2d07a-9344-ed39-261e-11084067a3fa@broadcom.com> Message-ID: <41bbf801-f060-2056-4015-b4d05c6831bb@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 5/31/2018 1:22 AM, Cl?ment P?ron wrote: > Hi Rai, > > On Wed, 30 May 2018 at 19:25, Ray Jui wrote: >> >> Hi Cl?ment, >> >> Correct me if I'm wrong, but I thought the trend is to move to use >> earlycon that can be activated from kernel command line for early print >> before the serial driver is loaded. >> >> Have you tried earlcon? > No, only tested this method. > > Thanks, > Clement > If I remember it correctly, I think the trend is to use earlycon. There are obvious shortcomings by making this configuration compile time based. >> >> Thanks, >> >> Ray >> >> On 5/30/2018 6:19 AM, Cl?ment P?ron wrote: >>> From: Cl?ment Peron >>> >>> Broadcom Iproc SoCs typically use the UART3 for >>> debug/console, provide a known good location for that. >>> >>> Signed-off-by: Cl?ment Peron >>> --- >>> >>> arch/arm/Kconfig.debug | 12 +++++++++++- >>> 1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug >>> index 199ebc1c4538..4ea9d5793b91 100644 >>> --- a/arch/arm/Kconfig.debug >>> +++ b/arch/arm/Kconfig.debug >>> @@ -207,6 +207,14 @@ choice >>> depends on ARCH_BCM_HR2 >>> select DEBUG_UART_8250 >>> >>> + config DEBUG_BCM_IPROC_UART3 >>> + bool "Kernel low-level debugging on BCM IPROC UART3" >>> + depends on ARCH_BCM_CYGNUS >>> + select DEBUG_UART_8250 >>> + help >>> + Say Y here if you want the debug print routines to direct >>> + their output to the third serial port on these devices. >>> + >>> config DEBUG_BCM_KONA_UART >>> bool "Kernel low-level debugging messages via BCM KONA UART" >>> depends on ARCH_BCM_MOBILE >>> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS >>> default 0x18000400 if DEBUG_BCM_HR2 >>> default 0x18010000 if DEBUG_SIRFATLAS7_UART0 >>> default 0x18020000 if DEBUG_SIRFATLAS7_UART1 >>> + default 0x18023000 if DEBUG_BCM_IPROC_UART3 >>> default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1 >>> default 0x20001000 if DEBUG_HIP01_UART >>> default 0x20060000 if DEBUG_RK29_UART0 >>> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT >>> default 0xf1002000 if DEBUG_MT8127_UART0 >>> default 0xf1006000 if DEBUG_MT6589_UART0 >>> default 0xf1009000 if DEBUG_MT8135_UART3 >>> + default 0xf1023000 if DEBUG_BCM_IPROC_UART3 >>> default 0xf11f1000 if DEBUG_VERSATILE >>> default 0xf1600000 if DEBUG_INTEGRATOR >>> default 0xf1c28000 if DEBUG_SUNXI_UART0 >>> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD >>> DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \ >>> DEBUG_ALPINE_UART0 || \ >>> DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \ >>> - DEBUG_DAVINCI_DA8XX_UART2 || \ >>> + DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \ >>> DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 >>> >>> config DEBUG_UART_8250_PALMCHIP >>>