From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC6EC433E1 for ; Fri, 10 Jul 2020 17:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 585A220674 for ; Fri, 10 Jul 2020 17:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="YkW+/knV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgGJRR5 (ORCPT ); Fri, 10 Jul 2020 13:17:57 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:49140 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbgGJRR4 (ORCPT ); Fri, 10 Jul 2020 13:17:56 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06AHHqJb045219; Fri, 10 Jul 2020 12:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1594401472; bh=And+UVi6LJgw5zNisJ1sin3PCpYh9TJOQeoY32MycvU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=YkW+/knVkNDayC3kyNth0DZgpQHHtIr2KdyxAtYhO7/SY4KXdKlRiU8IKHnXEWOvh 3g6LrNxkJX5Uzadc77JKaUjZ/IRrVoRFO7EMQswVLuLnp2aN3QpNVug1cMC63YIv4G daW1LxlV9TE44ucTrGuv28s+QDJgOjS71EKYylR8= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 06AHHqp0108775 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Jul 2020 12:17:52 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 10 Jul 2020 12:17:51 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 10 Jul 2020 12:17:51 -0500 Received: from [10.250.34.57] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06AHHpX6013622; Fri, 10 Jul 2020 12:17:51 -0500 Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 To: Tony Lindgren CC: , , , Tero Kristo References: <20200709231954.1973-1-s-anna@ti.com> <20200710165814.GF5849@atomide.com> From: Suman Anna Message-ID: <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> Date: Fri, 10 Jul 2020 12:17:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200710165814.GF5849@atomide.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/10/20 11:58 AM, Tony Lindgren wrote: > Hi, > > * Suman Anna [200709 16:20]: >> Hi Tony, >> >> The following series contains all the necessary DT pieces to boot the >> IPU and DSP remote processors on OMAP4 and OMAP5 SoCs. They are >> enabled specifically on the TI OMAP4 PandaBoard and OMAP5 uEVM boards. >> This is the last DT piece that now completes the support for IPUs and >> DSPs on all OMAP4+ SoCs, similar patches were merged for 5.8 covering >> the DRA7xx/AM57xx SoCs. Appreciate it if you can pick up the series for >> 5.9 if it isn't too late. > > Great and good to hear things are working with only dts changes now :) > Yes let's try to get these merged. Thanks. > >> There is one issue that I have run into while testing this series on >> the latest kernel. I am seeing a l3_noc error for OMAP4 DSP when it >> attempts to auto-suspend or stop after it is booted. The issue is a >> L4CFG read error that happens in the sysc_disable_module() function >> in ti-sysc code. >> >> I do not have any issues on my downstream 5.4 based SDK kernel. I have >> root-caused this to the OMAP4 voltage controller patches you added for >> 5.5 kernel through your omap-for-v5.5/pm branch, specifically the >> commit 4873843718f9 ("ARM: OMAP2+: Initialize voltage controller for omap4"). >> The VOLTCTRL register value is 0x300 before that patch, and modifying >> this register either through omap4_vc_init_pmic_signaling() or >> omap4_vc_set_pmic_signaling() will trigger this. A debug print in >> sysc_disable_module() also seems to help. > > Hmm interesting, not sure how the VOLTCTRL register affects this. > > I wonder the following commit in v5.8-rc3 might help with this though: > > 5ce8aee81be6 ("bus: ti-sysc: Flush posted write on enable and disable") > I had already tested on v5.8-rc4 when I posted the patches, so this patch doesn't help. OMAP5 DSP is fine, because Think it has to do with this automated So, I am looking at the TRM, and the three VDD_{IVA,MPU,CORE}_I2C_DISABLE bits in VOLTCTRL are marked debug-purpose only, so I don't think we should be setting those to begin with. Any reason why you want to set those? Anyway, these bits were not an issue, I have specifically tried that already. regards Suman > I was seeing that occasionally with mcspi, but never had anything > reproducable. > > Regards, > > Tony > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A05FC433E4 for ; Fri, 10 Jul 2020 17:19:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3990D20674 for ; Fri, 10 Jul 2020 17:19:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="byCnEZc6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="YkW+/knV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3990D20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IqXicm0cUEPCCnbCeZPtHXRUmAgeZqQlghJ2Jy/BfBU=; b=byCnEZc6zCu+T0p9YUw7ygJSv 1GrP02A25RoqMmE7ACrVZ/odAbOc4W350xuOl0xmSHtgUID4bJX0jn8AhTaZnxS0qnZC+UBbL7qpC FudxtPe9tcrAUfhyHCZplywrsm4Efo3Ak7AsdXsgSJtlGouRldTySgiIVXrypDLVMz03P4uTN6NXi 6RG96AmWWcEdbMgPScIFYEeEq+WUhLwydT8TMPaj8iET0NGYQP5Yz9aSSF+wzFn630ZOvkQCkY+jT +9DpKjQRIkMUPh55tIgv9ol8oKsxtHCxjYiEh7/3YpRv4jQ3wPPrs9auILMsodIY3ebR0qWx2Fa1q Jvj9/iXow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtwer-00040k-Jl; Fri, 10 Jul 2020 17:17:57 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtwep-000406-5r for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 17:17:56 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06AHHqJb045219; Fri, 10 Jul 2020 12:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1594401472; bh=And+UVi6LJgw5zNisJ1sin3PCpYh9TJOQeoY32MycvU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=YkW+/knVkNDayC3kyNth0DZgpQHHtIr2KdyxAtYhO7/SY4KXdKlRiU8IKHnXEWOvh 3g6LrNxkJX5Uzadc77JKaUjZ/IRrVoRFO7EMQswVLuLnp2aN3QpNVug1cMC63YIv4G daW1LxlV9TE44ucTrGuv28s+QDJgOjS71EKYylR8= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 06AHHqp0108775 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Jul 2020 12:17:52 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 10 Jul 2020 12:17:51 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 10 Jul 2020 12:17:51 -0500 Received: from [10.250.34.57] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06AHHpX6013622; Fri, 10 Jul 2020 12:17:51 -0500 Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 To: Tony Lindgren References: <20200709231954.1973-1-s-anna@ti.com> <20200710165814.GF5849@atomide.com> From: Suman Anna Message-ID: <41bd2bb4-06fe-5f70-22cf-ce9cedc8bbc3@ti.com> Date: Fri, 10 Jul 2020 12:17:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200710165814.GF5849@atomide.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_131755_401331_C8456415 X-CRM114-Status: GOOD ( 25.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/10/20 11:58 AM, Tony Lindgren wrote: > Hi, > > * Suman Anna [200709 16:20]: >> Hi Tony, >> >> The following series contains all the necessary DT pieces to boot the >> IPU and DSP remote processors on OMAP4 and OMAP5 SoCs. They are >> enabled specifically on the TI OMAP4 PandaBoard and OMAP5 uEVM boards. >> This is the last DT piece that now completes the support for IPUs and >> DSPs on all OMAP4+ SoCs, similar patches were merged for 5.8 covering >> the DRA7xx/AM57xx SoCs. Appreciate it if you can pick up the series for >> 5.9 if it isn't too late. > > Great and good to hear things are working with only dts changes now :) > Yes let's try to get these merged. Thanks. > >> There is one issue that I have run into while testing this series on >> the latest kernel. I am seeing a l3_noc error for OMAP4 DSP when it >> attempts to auto-suspend or stop after it is booted. The issue is a >> L4CFG read error that happens in the sysc_disable_module() function >> in ti-sysc code. >> >> I do not have any issues on my downstream 5.4 based SDK kernel. I have >> root-caused this to the OMAP4 voltage controller patches you added for >> 5.5 kernel through your omap-for-v5.5/pm branch, specifically the >> commit 4873843718f9 ("ARM: OMAP2+: Initialize voltage controller for omap4"). >> The VOLTCTRL register value is 0x300 before that patch, and modifying >> this register either through omap4_vc_init_pmic_signaling() or >> omap4_vc_set_pmic_signaling() will trigger this. A debug print in >> sysc_disable_module() also seems to help. > > Hmm interesting, not sure how the VOLTCTRL register affects this. > > I wonder the following commit in v5.8-rc3 might help with this though: > > 5ce8aee81be6 ("bus: ti-sysc: Flush posted write on enable and disable") > I had already tested on v5.8-rc4 when I posted the patches, so this patch doesn't help. OMAP5 DSP is fine, because Think it has to do with this automated So, I am looking at the TRM, and the three VDD_{IVA,MPU,CORE}_I2C_DISABLE bits in VOLTCTRL are marked debug-purpose only, so I don't think we should be setting those to begin with. Any reason why you want to set those? Anyway, these bits were not an issue, I have specifically tried that already. regards Suman > I was seeing that occasionally with mcspi, but never had anything > reproducable. > > Regards, > > Tony > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel