From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1015AC48BDF for ; Fri, 11 Jun 2021 02:54:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCC0A61222 for ; Fri, 11 Jun 2021 02:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbhFKC4q (ORCPT ); Thu, 10 Jun 2021 22:56:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbhFKC4p (ORCPT ); Thu, 10 Jun 2021 22:56:45 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 194A7C061574 for ; Thu, 10 Jun 2021 19:54:48 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id q5-20020a9d66450000b02903f18d65089fso1757791otm.11 for ; Thu, 10 Jun 2021 19:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=DINKFOqOMhxxSvYAQRZTNA7fBlEmiuST1PHK60SsnSg=; b=oCXZL/gaa9F4fKQDVopQ1sJgDPYR0URxfq7ygPAp2IjBOszlgnK9sq/GuQoV2kwVBY BJIsvdoWjkDAs9FJpvW4GLmHsoyFETq9eiKwn1ari0fHSZQWB39YWlETpsoAKf58XOwE fOzbLanzJF7ySbjd2bm65odG3TIU/DPjq37KXsc+nJgkT1agofpg8q6NNo6MjgYnNUqZ wuE32j4bjEubYd6m8oKlZZnfn4yE5IxIIKVcFP6TUdUYYbrdW+S0DPQL0lMeyVlWGVUY 2d4eRfNpNOd6M3q7X/X8YewfMLnAMPReH5d5UYSLRoAz/ZJH9tIX7WrVWIjhNNKl9aiq I24Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DINKFOqOMhxxSvYAQRZTNA7fBlEmiuST1PHK60SsnSg=; b=Ut+Lcq1r+hbPlU7iWLob1E8Gjmc5AaaLoIKLg5OalsrnPOMinfsZtT0v9mnOWfHuNl 6tC6cah9x3ZjRNMyxlBnVRsXuiDaORU6JwkVwm1SWAM9bFVuEM7AMAGKBdFs/1s7TX8T iyHM+p/FgqNpTt4HuRT3+x/7hx/STjVob+UckeysY7IpRyAEZu5Sr3jKvpo5sWJRgS1Z PuYQp0XVBZMgQBPdHUh5UBgGHoV2p3EgnGxpTCegBI6gl9FewzRMWoBArI7bYgkZKuYk 70j4EAgyJMSpkpk8V0f/Sacz7HchVIRw25FC8q4zAyzekwtv5BPMCSZV6aSbQ8NYMFuX FPzQ== X-Gm-Message-State: AOAM530366jVZ4SDzWjiPLxsecQ1AuiSDGWDAnFxA1nc7++a/H0XAzqd Wo3NxNoHk6bf/Mpx5TlGsvDHZnVyCII= X-Google-Smtp-Source: ABdhPJxjiJ0+viBqQ3t1i9e0c+YoE71ojhp6DFZbI8mbRP0QJ3AAMPAbAWHN4PCUYkCds38zuvMGIw== X-Received: by 2002:a05:6830:154b:: with SMTP id l11mr1175522otp.66.1623380087306; Thu, 10 Jun 2021 19:54:47 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.22]) by smtp.googlemail.com with ESMTPSA id 102sm1017120otf.37.2021.06.10.19.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 19:54:46 -0700 (PDT) Subject: Re: [PATCH iproute2] uapi: add missing virtio related headers To: Parav Pandit , Stephen Hemminger , "netdev@vger.kernel.org" References: <20210423174011.11309-1-stephen@networkplumber.org> From: David Ahern Message-ID: <41c8cf83-6b7d-1d55-fd88-5b84732f9d70@gmail.com> Date: Thu, 10 Jun 2021 20:54:45 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/8/21 11:15 PM, Parav Pandit wrote: > Hi Stephen, > > vdpa headers were present in commit c2ecc82b9d4c at [1]. > > I added them at [1] after David's recommendation in [2]. > > Should we remove [1]? > Did you face compilation problem without this fix? > > [1] ./vdpa/include/uapi/linux/vdpa.h > [2] https://lore.kernel.org/netdev/abc71731-012e-eaa4-0274-5347fc99c249@gmail.com/ > > Parav Stephen: Did you hit a compile issue? vdpa goes beyond networking and features go through other trees AIUI so the decision was to put the uapi file under the vdpa command similar to what rdma is doing.