From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CDEAC10F03 for ; Tue, 23 Apr 2019 17:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAC7A218D2 for ; Tue, 23 Apr 2019 17:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729407AbfDWRG4 (ORCPT ); Tue, 23 Apr 2019 13:06:56 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54707 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729184AbfDWRGz (ORCPT ); Tue, 23 Apr 2019 13:06:55 -0400 X-Originating-IP: 93.29.109.196 Received: from collins (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B8EE3C0009; Tue, 23 Apr 2019 17:06:52 +0000 (UTC) Message-ID: <41c94d93321b10ee9173e0b5bce9bc37a1ea7532.camel@bootlin.com> Subject: Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before releasing DRM and mem at master unbind From: Paul Kocialkowski To: Chen-Yu Tsai Cc: dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Maxime Ripard , David Airlie , Daniel Vetter , Thomas Petazzoni Date: Tue, 23 Apr 2019 19:06:52 +0200 In-Reply-To: <1fcd1b7b1b52e67e4f0a28fca567bf3243fe0ada.camel@bootlin.com> References: <20190419080235.24396-1-paul.kocialkowski@bootlin.com> <1fcd1b7b1b52e67e4f0a28fca567bf3243fe0ada.camel@bootlin.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le vendredi 19 avril 2019 à 19:10 +0200, Paul Kocialkowski a écrit : > Hi, > > On Fri, 2019-04-19 at 09:02 -0700, Chen-Yu Tsai wrote: > > On Fri, Apr 19, 2019 at 1:03 AM Paul Kocialkowski > > wrote: > > > Our components may still be using the DRM device driver (if only to > > > access our driver's private data), so make sure to unbind them before > > > the final drm_dev_put. > > > > > > Also release our resserved memory adter unbind to match reverse > > > > typos... > > I'll probably spin up a v2 to fix them, they annoy me as well. > > > > creation order. > > > > > > Fixes: f5a9ed867c83 ("drm/sun4i: Fix component unbinding and component master deletion") > > > Signed-off-by: Paul Kocialkowski > > > --- > > > drivers/gpu/drm/sun4i/sun4i_drv.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c > > > index 843b86661833..29258b404e54 100644 > > > --- a/drivers/gpu/drm/sun4i/sun4i_drv.c > > > +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c > > > @@ -149,10 +149,11 @@ static void sun4i_drv_unbind(struct device *dev) > > > drm_kms_helper_poll_fini(drm); > > > drm_atomic_helper_shutdown(drm); > > > drm_mode_config_cleanup(drm); > > > - of_reserved_mem_device_release(dev); > > > - drm_dev_put(drm); > > > > > > component_unbind_all(dev, NULL); > > > + of_reserved_mem_device_release(dev); > > > > You should probably mention this change in the commit log as well. > > That's what I meant with the line that has typos. Maybe I should make > it slightly more explicit as: > > Also released our reserved memory after component unbind instead of > before to match reverse creation order. > > What do you think? > > > Otherwise, > > > > Reviewed-by: Chen-Yu Tsai > > Thanks for the review! Unless you have objections at this point, I'll send out the patch with your Reviewed-by soon to get the patch out ASAP. Cheers, Paul > Cheers, > > Paul > > > > + > > > + drm_dev_put(drm); > > > } > > > > > > static const struct component_master_ops sun4i_drv_master_ops = { > > > -- > > > 2.21.0 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > > > For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A83C10F03 for ; Tue, 23 Apr 2019 17:07:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B881E218D2 for ; Tue, 23 Apr 2019 17:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r7ZTYCFp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B881E218D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z+PP/xcv8pWRZRKgLrJde8V5qmmSVzYPjkm0Rnw1PA0=; b=r7ZTYCFpJi2ElR c0fUAU2Tfv2z9b5/QuYb3pwBYwvw8CmoL4qvtzDh7OBz/K9gZTB8qaQBpr3EtIdEoW29VWR9QHpFR m2+nqSZXTH/NkYnfMszU/TQjYcNqj1aW8Xy6mK57OyytjFV639ah0/JhyJ+pE/4xBdzpWri3KaFsr 97v1y6IkiUND7xI9FJMFl7eslm9h5cS7iS9Mg0J9EE+onqh0fNk87d56wTs/5ULlD/nONK7Et/SC1 En/ANSre4gPsQh4rWrE8k9lWKKPltIAjKDzQ1W34/0RZfYng+ri2Z8ekHqiQLjswcLGYm9zBA0vHT ApPM7FNUG7gfmuVptejA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIysq-0008Qm-FY; Tue, 23 Apr 2019 17:07:04 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIysn-0008PT-4y for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 17:07:02 +0000 X-Originating-IP: 93.29.109.196 Received: from collins (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B8EE3C0009; Tue, 23 Apr 2019 17:06:52 +0000 (UTC) Message-ID: <41c94d93321b10ee9173e0b5bce9bc37a1ea7532.camel@bootlin.com> Subject: Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before releasing DRM and mem at master unbind From: Paul Kocialkowski To: Chen-Yu Tsai Date: Tue, 23 Apr 2019 19:06:52 +0200 In-Reply-To: <1fcd1b7b1b52e67e4f0a28fca567bf3243fe0ada.camel@bootlin.com> References: <20190419080235.24396-1-paul.kocialkowski@bootlin.com> <1fcd1b7b1b52e67e4f0a28fca567bf3243fe0ada.camel@bootlin.com> User-Agent: Evolution 3.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_100701_364907_78413F7E X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Maxime Ripard , linux-kernel , dri-devel , David Airlie , linux-sunxi , Daniel Vetter , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpMZSB2ZW5kcmVkaSAxOSBhdnJpbCAyMDE5IMOgIDE5OjEwICswMjAwLCBQYXVsIEtvY2lh bGtvd3NraSBhIMOpY3JpdCA6Cj4gSGksCj4gCj4gT24gRnJpLCAyMDE5LTA0LTE5IGF0IDA5OjAy IC0wNzAwLCBDaGVuLVl1IFRzYWkgd3JvdGU6Cj4gPiBPbiBGcmksIEFwciAxOSwgMjAxOSBhdCAx OjAzIEFNIFBhdWwgS29jaWFsa293c2tpCj4gPiA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5j b20+IHdyb3RlOgo+ID4gPiBPdXIgY29tcG9uZW50cyBtYXkgc3RpbGwgYmUgdXNpbmcgdGhlIERS TSBkZXZpY2UgZHJpdmVyIChpZiBvbmx5IHRvCj4gPiA+IGFjY2VzcyBvdXIgZHJpdmVyJ3MgcHJp dmF0ZSBkYXRhKSwgc28gbWFrZSBzdXJlIHRvIHVuYmluZCB0aGVtIGJlZm9yZQo+ID4gPiB0aGUg ZmluYWwgZHJtX2Rldl9wdXQuCj4gPiA+IAo+ID4gPiBBbHNvIHJlbGVhc2Ugb3VyIHJlc3NlcnZl ZCBtZW1vcnkgYWR0ZXIgdW5iaW5kIHRvIG1hdGNoIHJldmVyc2UKPiA+IAo+ID4gdHlwb3MuLi4K PiAKPiBJJ2xsIHByb2JhYmx5IHNwaW4gdXAgYSB2MiB0byBmaXggdGhlbSwgdGhleSBhbm5veSBt ZSBhcyB3ZWxsLgo+IAo+ID4gPiBjcmVhdGlvbiBvcmRlci4KPiA+ID4gCj4gPiA+IEZpeGVzOiBm NWE5ZWQ4NjdjODMgKCJkcm0vc3VuNGk6IEZpeCBjb21wb25lbnQgdW5iaW5kaW5nIGFuZCBjb21w b25lbnQgbWFzdGVyIGRlbGV0aW9uIikKPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBLb2NpYWxr b3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRy aXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9kcnYuYyB8IDUgKysrLS0KPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jIGIvZHJpdmVycy9ncHUv ZHJtL3N1bjRpL3N1bjRpX2Rydi5jCj4gPiA+IGluZGV4IDg0M2I4NjY2MTgzMy4uMjkyNThiNDA0 ZTU0IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfZHJ2LmMK PiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jCj4gPiA+IEBAIC0x NDksMTAgKzE0OSwxMSBAQCBzdGF0aWMgdm9pZCBzdW40aV9kcnZfdW5iaW5kKHN0cnVjdCBkZXZp Y2UgKmRldikKPiA+ID4gICAgICAgICBkcm1fa21zX2hlbHBlcl9wb2xsX2ZpbmkoZHJtKTsKPiA+ ID4gICAgICAgICBkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bihkcm0pOwo+ID4gPiAgICAgICAg IGRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRybSk7Cj4gPiA+IC0gICAgICAgb2ZfcmVzZXJ2ZWRf bWVtX2RldmljZV9yZWxlYXNlKGRldik7Cj4gPiA+IC0gICAgICAgZHJtX2Rldl9wdXQoZHJtKTsK PiA+ID4gCj4gPiA+ICAgICAgICAgY29tcG9uZW50X3VuYmluZF9hbGwoZGV2LCBOVUxMKTsKPiA+ ID4gKyAgICAgICBvZl9yZXNlcnZlZF9tZW1fZGV2aWNlX3JlbGVhc2UoZGV2KTsKPiA+IAo+ID4g WW91IHNob3VsZCBwcm9iYWJseSBtZW50aW9uIHRoaXMgY2hhbmdlIGluIHRoZSBjb21taXQgbG9n IGFzIHdlbGwuCj4gCj4gVGhhdCdzIHdoYXQgSSBtZWFudCB3aXRoIHRoZSBsaW5lIHRoYXQgaGFz IHR5cG9zLiBNYXliZSBJIHNob3VsZCBtYWtlCj4gaXQgc2xpZ2h0bHkgbW9yZSBleHBsaWNpdCBh czoKPiAKPiBBbHNvIHJlbGVhc2VkIG91ciByZXNlcnZlZCBtZW1vcnkgYWZ0ZXIgY29tcG9uZW50 IHVuYmluZCBpbnN0ZWFkIG9mCj4gYmVmb3JlIHRvIG1hdGNoIHJldmVyc2UgY3JlYXRpb24gb3Jk ZXIuCj4gCj4gV2hhdCBkbyB5b3UgdGhpbms/Cj4gCj4gPiBPdGhlcndpc2UsCj4gPiAKPiA+IFJl dmlld2VkLWJ5OiBDaGVuLVl1IFRzYWkgPHdlbnNAY3NpZS5vcmc+Cj4gCj4gVGhhbmtzIGZvciB0 aGUgcmV2aWV3IQoKVW5sZXNzIHlvdSBoYXZlIG9iamVjdGlvbnMgYXQgdGhpcyBwb2ludCwgSSds bCBzZW5kIG91dCB0aGUgcGF0Y2ggd2l0aAp5b3VyIFJldmlld2VkLWJ5IHNvb24gdG8gZ2V0IHRo ZSBwYXRjaCBvdXQgQVNBUC4KCkNoZWVycywKClBhdWwKCj4gQ2hlZXJzLAo+IAo+IFBhdWwKPiAK PiA+ID4gKwo+ID4gPiArICAgICAgIGRybV9kZXZfcHV0KGRybSk7Cj4gPiA+ICB9Cj4gPiA+IAo+ ID4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBjb21wb25lbnRfbWFzdGVyX29wcyBzdW40aV9kcnZf bWFzdGVyX29wcyA9IHsKPiA+ID4gLS0KPiA+ID4gMi4yMS4wCj4gPiA+IAo+ID4gPiAtLQo+ID4g PiBZb3UgcmVjZWl2ZWQgdGhpcyBtZXNzYWdlIGJlY2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRv IHRoZSBHb29nbGUgR3JvdXBzICJsaW51eC1zdW54aSIgZ3JvdXAuCj4gPiA+IFRvIHVuc3Vic2Ny aWJlIGZyb20gdGhpcyBncm91cCBhbmQgc3RvcCByZWNlaXZpbmcgZW1haWxzIGZyb20gaXQsIHNl bmQgYW4gZW1haWwgdG8gbGludXgtc3VueGkrdW5zdWJzY3JpYmVAZ29vZ2xlZ3JvdXBzLmNvbS4K PiA+ID4gRm9yIG1vcmUgb3B0aW9ucywgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9k L29wdG91dC4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==