From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E01AC19F2D for ; Tue, 9 Aug 2022 12:16:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2EFCA84A1B; Tue, 9 Aug 2022 14:15:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1660047344; bh=/M8O4+LEk/lxhKL0hexn/jnyAmr0oR+gc2vrhddjgCk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oy61Eql/H7HBS4UEy7lZ30f41DXGg2vUjypsRa9TPMEU2ufTnWyFbihG6SSqyPlsD o5GXawivQ0Q+xiH38MKjGvYTolPo3lJ5aEqmsFOBTFjbb2rG2/qghOA9BNIrbf1zHy laBDctZwtGqQKwj9bG3p/N+thmb8Keiipw//FrNIWSTXbMWnNPV9FHR8cKUYywuRP2 3H5jcswV4aK+37dDnmdZoQVmNNQQWDZe3LI6/MLmzbUbWsvFo73JDU2Ao/ZekzqPnH 3j0mw0vRYHH6Ta09vQe57dYUivUNSntzJOL85vgSxddr+XTgu5bpEZ76Om3qw5sP38 cd+sGedHNHLrQ== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DEA5081872; Tue, 9 Aug 2022 13:16:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1660043808; bh=/M8O4+LEk/lxhKL0hexn/jnyAmr0oR+gc2vrhddjgCk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oouPKHXA28fMUXI7faREWDoT3hOcMehCQy2aag+CM8U1cdlhsPiSOzvEw3TleOxA+ iJVon2cEASyuaatyn7DOQIWvMSVo0KDjtrkwRBmA63ksG7N+swoqaKa62RWdxpUiHp efhfJ42zROXA5wgJUd3gnR+G2d1QcFOoGvAyWDRc7lYakUfB+5ClJDDy97ojP1MYOI uqpQcxPgvzLOVou/9FiPeD7XgRkFRNPTGnZxMUMd44BTM6oKJxTH3UHAsEIeJ2unRf QOIWgeRwh4VX46bS9LxY4gypBw6rJVls+BgTIPVqfOW6slF1cTGZ6K6sHq052N8vlh rGKiiLoMupXgg== Message-ID: <41f76858-38d9-284b-1b54-b511f3b3cd67@denx.de> Date: Tue, 9 Aug 2022 13:16:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Philip Oberfichtner Cc: u-boot@lists.denx.de, Christoph Niedermaier , Stefano Babic , Adam Ford , Anatolij Gustschin , Andreas Geisreiter , "Andrew F. Davis" , Baruch Siach , Bharat Gooty , Breno Lima , Chin-Liang See , Chris Packham , Dalon Westergreen , Dennis Gilmore , Dinh Nguyen , =?UTF-8?Q?Eric_B=c3=a9nard?= , Eric Nelson , Fabio Estevam , Francesco Montefoschi , Heiko Schocher , Holger Brunck , Huan 'Kitty' Wang , Humberto Naves , Ian Ray , Jaehoon Chung , Jagan Teki , Jim Liu , Luka Kovacic , Luka Perkov , Lukasz Majewski , Marcel Ziswiler , =?UTF-8?Q?Marek_Beh=c3=ban?= , Mario Six , Markus Niebel , Martyn Welch , Matthias Winker , Michal Simek , Niel Fourie , Nikita Kiryanov , Otavio Salvador , Patrick Delaunay , Pavel Machek , =?UTF-8?Q?Pawe=c5=82_Anikiel?= , Peng Fan , Phil Sutter , Raffaele RECALCATI , Rayagonda Kokatanur , Rick Chen , Rui Miguel Silva , Silvio Fricke , Simon Glass , Simone CIANNI , Soeren Moch , Stanley Chu , Stefan Roese , Stephan Gerhold , Thomas Huth , Tim Harvey , Troy Kisky , Wolfgang Grandegger , Wolfgang Wallner , u-boot@dh-electronics.com References: <20220809100703.3101047-1-pro@denx.de> <20220809100703.3101047-2-pro@denx.de> <20220809105813.aa4vjcyiqm3mnqx4@pali> From: Marek Vasut In-Reply-To: <20220809105813.aa4vjcyiqm3mnqx4@pali> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 09 Aug 2022 14:15:23 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/9/22 12:58, Pali Rohár wrote: > On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: >> This converts CONFIG_SYS_L2_PL310 to Kconfig. > ... >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 949ebb46ba..dde06bdd96 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -488,6 +488,10 @@ config TPL_SYS_THUMB_BUILD >> density. For ARM architectures that support Thumb2 this flag will >> result in Thumb2 code generated by GCC. >> >> +config SYS_L2_PL310 >> + bool "ARM PL310 L2 cache controller" >> + help >> + Enable support for ARM PL310 L2 cache controller in U-Boot >> >> config SYS_L2CACHE_OFF >> bool "L2cache off" >> diff --git a/arch/arm/mach-mvebu/include/mach/config.h b/arch/arm/mach-mvebu/include/mach/config.h >> index 4add0d9e10..0bba0a4cf9 100644 >> --- a/arch/arm/mach-mvebu/include/mach/config.h >> +++ b/arch/arm/mach-mvebu/include/mach/config.h >> @@ -25,8 +25,6 @@ >> #define MV88F78X60 /* for the DDR training bin_hdr code */ >> #endif >> >> -#define CONFIG_SYS_L2_PL310 >> - >> #define MV_UART_CONSOLE_BASE MVEBU_UART0_BASE >> >> /* Needed for SPI NOR booting in SPL */ > > This option is required for mvebu SoC and is not user (de)-selectable. > So please do not define it in each individual mvebu board. It would make > it harder to introduce a new mvebu board into U-Boot. Instead enable it > for mvebu SoCs like it was before this change. It can be done e.g. by > "select" Kconfig keyword in mvebu Kconfig file. Should it rather be 'default y if MVEBU' in that new PL310 Kconfig option ?