From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68EB3C47087 for ; Fri, 28 May 2021 12:53:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A7B86124B for ; Fri, 28 May 2021 12:53:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A7B86124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1EB9F82ABD; Fri, 28 May 2021 14:53:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="OXyO0OsH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAA3882ABD; Fri, 28 May 2021 14:53:26 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F6A782EC5 for ; Fri, 28 May 2021 14:53:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrice.chotard@foss.st.com Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14SCqWOH009721; Fri, 28 May 2021 14:53:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=YkFx0zHHYiowcfMuwv1cEnfWv2dEY9aj582R6ct0crM=; b=OXyO0OsHd/ARur1eP95Pv4utWDSsjmVZs9RZmmVgcRzkLTGapJ3zK9kCwvdZ5DG4tUYi VMRRYeT4G7FPBuFyQljpJngEUa/Fv4o7p8vKHiI7hfXFqywRIbXUfUHm8Z4jq6f/nI+K 0Ema+aAZ6MOHD2Zs0ksLhldYoKVrfrdEVJfdDCc94aUtksbcBzC/G8MXu/nu2qnhhd7/ eoukikAiq5p+AUN/4ZDNCoVpTzswLb9BzM+P8pEDzsVrXd35QnqwlJBlDgZL70n5UcEl dS1r4yZ/Ij/I/EIIegBSyuwsa3Y0Zh4jMLViPiUZX/BhXy+wrW0WzDBcwzsVAEoBRMmO /w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38ttn02aea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 14:53:20 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 21A0C10002A; Fri, 28 May 2021 14:53:20 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 149232291B2; Fri, 28 May 2021 14:53:20 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 14:53:19 +0200 Subject: Re: [PATCH 02/10] stm32mp: stm32prog: add timeout in stm32prog_serial_get_buffer To: Patrick Delaunay , CC: Patrick Delaunay , Simon Glass , U-Boot STM32 References: <20210518131213.20343-1-patrick.delaunay@foss.st.com> <20210518151206.2.I11b3c3f4cdfbecc6830d6280ba993c8ba2ba0eeb@changeid> From: Patrice CHOTARD Message-ID: <41f90d57-1152-b045-c1aa-3ffd5d855a29@foss.st.com> Date: Fri, 28 May 2021 14:53:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518151206.2.I11b3c3f4cdfbecc6830d6280ba993c8ba2ba0eeb@changeid> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-28_04:2021-05-27, 2021-05-28 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Patrick On 5/18/21 3:12 PM, Patrick Delaunay wrote: > Handle timeout in stm32prog_serial_get_buffer to sent NACK > to STM32CubeProgrammer when the buffer is not fully received. > > This patch avoids to reach the STM32CubeProgrammer timeout and > the associated unrecoverable error. > > Timeout error occurred while waiting for acknowledgment. > > Error: Write Operation fails at packet number 4165 at address 0x1044FF > > Signed-off-by: Patrick Delaunay > --- > > .../mach-stm32mp/cmd_stm32prog/stm32prog_serial.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c > index 7eca86c11b..2550ae6a2b 100644 > --- a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c > +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog_serial.c > @@ -60,6 +60,9 @@ const u8 cmd_id[] = { > > #define NB_CMD sizeof(cmd_id) > > +/* with 115200 bauds, 20 ms allow to receive the 256 bytes buffer */ > +#define TIMEOUT_SERIAL_BUFFER 30 > + > /* DFU support for serial *********************************************/ > static struct dfu_entity *stm32prog_get_entity(struct stm32prog_data *data) > { > @@ -264,6 +267,7 @@ static bool stm32prog_serial_get_buffer(u8 *buffer, u32 *count) > { > struct dm_serial_ops *ops = serial_get_ops(down_serial_dev); > int err; > + ulong start = get_timer(0); > > do { > err = ops->getc(down_serial_dev); > @@ -273,6 +277,10 @@ static bool stm32prog_serial_get_buffer(u8 *buffer, u32 *count) > } else if (err == -EAGAIN) { > ctrlc(); > WATCHDOG_RESET(); > + if (get_timer(start) > TIMEOUT_SERIAL_BUFFER) { > + err = -ETIMEDOUT; > + break; > + } > } else { > break; > } > @@ -648,7 +656,7 @@ static void download_command(struct stm32prog_data *data) > printf("transmission error on packet %d, byte %d\n", > packet_number, codesize - counter); > /* waiting end of packet before flush & NACK */ > - mdelay(30); > + mdelay(TIMEOUT_SERIAL_BUFFER); > data->packet_number--; > result = NACK_BYTE; > goto end; > @@ -666,7 +674,7 @@ static void download_command(struct stm32prog_data *data) > /* wait to be sure that all data are received > * in the FIFO before flush > */ > - mdelay(30); > + mdelay(TIMEOUT_SERIAL_BUFFER); > data->packet_number--; > result = NACK_BYTE; > goto end; > Reviewed-by: Patrice Chotard Thanks Patrice