From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EC9C433F5 for ; Tue, 5 Oct 2021 09:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAA0661505 for ; Tue, 5 Oct 2021 09:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233574AbhJEJyu (ORCPT ); Tue, 5 Oct 2021 05:54:50 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:13296 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232723AbhJEJyt (ORCPT ); Tue, 5 Oct 2021 05:54:49 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633427579; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=9NNh8Apyajof6vjdxuO0fo4bjhrIb3avsDuXH6d364Y=; b=YC4wsFevvXLse61D0v5Xy+0nSLRDDjd20ILBksrGbBQshxTdsdu0wgaQdIGqHV6eTeUUCEem hG9S1MfvydH2cmntvGxy9q3WBxkpYePgbk5IzSOoXhaieLEq4AhR1dDrBUbOuVw7eX/40cxh YM++yFdoXTG2+z8Ud1qc6Twf1uI= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 615c207ab62327f2cb643de9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 05 Oct 2021 09:52:58 GMT Sender: mkrishn=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3F2B1C43617; Tue, 5 Oct 2021 09:52:58 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mkrishn) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7639EC4338F; Tue, 5 Oct 2021 09:52:57 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Oct 2021 15:22:57 +0530 From: mkrishn@codeaurora.org To: Stephen Boyd Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kalyan_t@codeaurora.org, sbillaka@codeaurora.org, abhinavk@codeaurora.org, robdclark@gmail.com, bjorn.andersson@linaro.org, khsieh@codeaurora.org, rajeevny@codeaurora.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes In-Reply-To: References: <1629282424-4070-1-git-send-email-mkrishn@codeaurora.org> <1629282424-4070-2-git-send-email-mkrishn@codeaurora.org> <5adf2ab2c2a162272509d253bd797721@codeaurora.org> <8f344213978f31c04e80b804a931db56@codeaurora.org> Message-ID: <41fb0eec922ff8499bb4b95ab29000f3@codeaurora.org> X-Sender: mkrishn@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-10-05 07:21, Stephen Boyd wrote: > Quoting mkrishn@codeaurora.org (2021-09-30 23:39:07) >> On 2021-09-30 23:28, Stephen Boyd wrote: >> > Quoting mkrishn@codeaurora.org (2021-09-30 04:56:59) >> >> On 2021-08-19 01:27, Stephen Boyd wrote: >> >> > Quoting Krishna Manikandan (2021-08-18 03:27:02) >> >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> >> index 53a21d0..fd7ff1c 100644 >> >> >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> >> >> + >> >> >> + status = "disabled"; >> >> >> + >> >> >> + mdp: mdp@ae01000 { >> >> > >> >> > display-controller@ae01000 >> >> >> >> Stephen, >> >> In the current driver code, there is a substring comparison for >> >> "mdp" >> >> in device node name as part of probe sequence. If "mdp" is not present >> >> in the node name, it will >> >> return an error resulting in probe failure. Can we continue using >> >> mdp >> >> as nodename instead of display controller? >> >> >> > >> > Can we fix the driver to not look for node names and look for >> > compatible >> > strings instead? It took me a minute to find compare_name_mdp() in >> > drivers/gpu/drm/msm/msm_drv.c to understand what you're talking about. >> > Perhaps looking for qcom,mdp5 in there will be sufficient instead of >> > looking at the node name. >> >> Sure Stephen. I will make the necessary changes in msm_drv.c to look >> for >> compatible string instead of node name. >> Can I include these two changes (changing mdp--> display controller >> and >> msm_drv.c changes) in a separate series ? >> > > Sure. So you'll send the drm driver change now and we'll get the DT > change after that with the more generic node name? Yes Stephen.I have raised the change to fix the driver issue. https://patchwork.kernel.org/project/linux-arm-msm/patch/1633427071-19523-1-git-send-email-mkrishn@codeaurora.org/ Regards, Krishna