From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE4BC433FE for ; Mon, 28 Mar 2022 17:04:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244163AbiC1RGL (ORCPT ); Mon, 28 Mar 2022 13:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238845AbiC1RGK (ORCPT ); Mon, 28 Mar 2022 13:06:10 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EEC04B41B for ; Mon, 28 Mar 2022 10:04:29 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id bq8so16058550ejb.10 for ; Mon, 28 Mar 2022 10:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6yQeqxmAC2aKz5WWofRTiroUa0cIPCXtz1ZK19EhWKo=; b=daxWCLSzVHGVhchsUZ6+YMjYVs1b6Fsm+tcDdFellj+t2WgqgjOdKLAWci/CZA5kTt YpUbcI/aiNTyqKr5AatPYmITMGtorqn7ES0eJ6ftJukevTX7gjRktmyM2KYU+jPIuMOo lRr1gySh1tvjJkDAfaSn+RFfZxDEI0XgwVFKQ3Jd0UwbgXJ421CA6h4nu98pFsDLh3iS Uplm1/6F6IsS2NZY2tmoLWY6NxpGAtzxX7vCCefkJ0eCtUEmzhGnTDDG9HvdC85/RgeI UmWlJrwlG+6aq9Gb59jmhagnkKLRvqeRsGPRkeNA/rmK3hTybLGNWQPHfY5ejaZOnwWR nyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6yQeqxmAC2aKz5WWofRTiroUa0cIPCXtz1ZK19EhWKo=; b=7dLjJTxnPLU3+xfg9ZlMZ5S8OSHaqfMteTNqpdONCODxwWvaX19aDEl9zYGs4P0T0v ER+hd10fVgISXymVXre7sQqmu7mgctCfZ4Xzxtf2hl1dgoN+Fi+tmETjKmv/ApeJDuYV WkODhYp4CmlMfPtqDm8IijJeov+lCsGoqA38QHxha9cyF9jGvM7d2i6hsZH8dugSLEM2 8yr962uofVTob/mpJolYy1rrGORGSbVmQLvdV8E8/dBDCHwkWRDltZK6hKnAxdWlONhy mXJ02/wXpAB+gGaWqDZaLK0bAdCJ7ezepIyyyPYV30qlkBDXG45pYzcgBywlg/tUI63r 66VQ== X-Gm-Message-State: AOAM531n8qFiu3l/MgP80ywIFCr0d6Y3DNuk3rM0Vtv5XChrjTwM7vyI gotPaSCAvtV/vTz4CmB0gGlkcA== X-Google-Smtp-Source: ABdhPJxOIHwbCP7io7cxTbL5Y9HAi1K2LbIG9adPMWYOr5vMxk3eG/GDERE2ELL/JaPwcEKHwv7GGQ== X-Received: by 2002:a17:907:7704:b0:6cf:48ac:b4a8 with SMTP id kw4-20020a170907770400b006cf48acb4a8mr29021497ejc.305.1648487067801; Mon, 28 Mar 2022 10:04:27 -0700 (PDT) Received: from [192.168.0.162] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id 20-20020a17090601d400b006caff964e30sm6108433ejj.19.2022.03.28.10.04.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 10:04:27 -0700 (PDT) Message-ID: <41fe6179-5628-6393-01c1-918baccec176@linaro.org> Date: Mon, 28 Mar 2022 19:04:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells Content-Language: en-US To: Dmitry Baryshkov , Krzysztof Kozlowski Cc: Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul References: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/03/2022 18:43, Dmitry Baryshkov wrote: > On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > wrote: >> >> The DSI node is not a bus and the children do not have unit addresses. >> >> Reported-by: Vinod Koul >> Signed-off-by: Krzysztof Kozlowski > > NAK. > DSI panels are children of the DSI device tree node with the reg = <0>; address. > This is the convention used by other platforms too (see e.g. > arch/arm64/boot/dts/freescale/imx8mq-evk.dts). > > With the DSI split link it is possible to attach two panels to a > single DSI host, so addresses are necessary. Yes, I noticed it slightly after I sent the patch. :( Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A69D6C4332F for ; Mon, 28 Mar 2022 17:22:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFCF110E727; Mon, 28 Mar 2022 17:22:33 +0000 (UTC) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B46C10E059 for ; Mon, 28 Mar 2022 17:04:29 +0000 (UTC) Received: by mail-ej1-x631.google.com with SMTP id p15so30006219ejc.7 for ; Mon, 28 Mar 2022 10:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6yQeqxmAC2aKz5WWofRTiroUa0cIPCXtz1ZK19EhWKo=; b=daxWCLSzVHGVhchsUZ6+YMjYVs1b6Fsm+tcDdFellj+t2WgqgjOdKLAWci/CZA5kTt YpUbcI/aiNTyqKr5AatPYmITMGtorqn7ES0eJ6ftJukevTX7gjRktmyM2KYU+jPIuMOo lRr1gySh1tvjJkDAfaSn+RFfZxDEI0XgwVFKQ3Jd0UwbgXJ421CA6h4nu98pFsDLh3iS Uplm1/6F6IsS2NZY2tmoLWY6NxpGAtzxX7vCCefkJ0eCtUEmzhGnTDDG9HvdC85/RgeI UmWlJrwlG+6aq9Gb59jmhagnkKLRvqeRsGPRkeNA/rmK3hTybLGNWQPHfY5ejaZOnwWR nyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6yQeqxmAC2aKz5WWofRTiroUa0cIPCXtz1ZK19EhWKo=; b=mdJUlctGh6eAWYjoh0ndkgtNwqflmQqu/k9gdix7ZNhFc9f1I11QdsLgQyMpfRrxvE vLJCn9HqAELnThAklGYTe0s8vK+Dq1eDVS/GjblDCSUO1PiEFqKk/BtRl+AXSOGhMwHx HGfWvUAP6/AmH8ZeohgSDkhTUG+0ROz5929dB2w2/25MAUhQQZR7D1uOrpVlONy6jPhA fmYm1kIsWrK4lmuwGIQxItRjZK6hsMcN/pKVaszLnTam7fbanx/O1IHXV8RPM2YlnHTg dtN/AQNU+k0WIFTNmYFXEdVvoM+8H8SVZ89R0rHaKo034ecuBOfwxeYiRKFuQ9ofd5cc tE9A== X-Gm-Message-State: AOAM53398sceQZOnza/Tn04augHREizs2hzFfEp8mZRJE+WzfhrdRpna YVlcHIqUGT17qpVcDik7pv16U/5SSeOyFPef X-Google-Smtp-Source: ABdhPJxOIHwbCP7io7cxTbL5Y9HAi1K2LbIG9adPMWYOr5vMxk3eG/GDERE2ELL/JaPwcEKHwv7GGQ== X-Received: by 2002:a17:907:7704:b0:6cf:48ac:b4a8 with SMTP id kw4-20020a170907770400b006cf48acb4a8mr29021497ejc.305.1648487067801; Mon, 28 Mar 2022 10:04:27 -0700 (PDT) Received: from [192.168.0.162] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id 20-20020a17090601d400b006caff964e30sm6108433ejj.19.2022.03.28.10.04.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 10:04:27 -0700 (PDT) Message-ID: <41fe6179-5628-6393-01c1-918baccec176@linaro.org> Date: Mon, 28 Mar 2022 19:04:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells Content-Language: en-US To: Dmitry Baryshkov , Krzysztof Kozlowski References: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 28 Mar 2022 17:22:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krishna Manikandan , devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Vinod Koul , Krzysztof Kozlowski , freedreno@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/03/2022 18:43, Dmitry Baryshkov wrote: > On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > wrote: >> >> The DSI node is not a bus and the children do not have unit addresses. >> >> Reported-by: Vinod Koul >> Signed-off-by: Krzysztof Kozlowski > > NAK. > DSI panels are children of the DSI device tree node with the reg = <0>; address. > This is the convention used by other platforms too (see e.g. > arch/arm64/boot/dts/freescale/imx8mq-evk.dts). > > With the DSI split link it is possible to attach two panels to a > single DSI host, so addresses are necessary. Yes, I noticed it slightly after I sent the patch. :( Best regards, Krzysztof