All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Borislav Petkov <bp@alien8.de>
Cc: lkml <linux-kernel@vger.kernel.org>,
	x86@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>, Yinghai Lu <yinghai@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Stephane Eranian <eranian@google.com>
Subject: Re: Info: mapping multiple BARs. Your kernel is fine.
Date: Sat, 15 Mar 2014 15:15:04 +0100	[thread overview]
Message-ID: <4205942.Tp8ltEsv6e@vostro.rjw.lan> (raw)
In-Reply-To: <20140224162400.GE16457@pd.tnic>

[CC list rearranged]

On Monday, February 24, 2014 05:24:00 PM Borislav Petkov wrote:
> This started happening this morning after booting -rc4+tip, let's
> add *everybody* to CC :-)
> 
> We have intel_uncore_init, snb_uncore_imc_init_box, uncore_pci_probe and
> other goodies on the stack.

I've just gone throught this.

So the problem is that we have the PNP "system" driver whose only purpose seems
to be to reserve system resources so that the PCI layer doesn't assign them to
new devices on hotplug (disclaimer: I didn't invent it, I only read the code and
comments in there).

It does that for ACPI device objects having the "PNP0C02" and "PNP0C01" IDs.

Apparently, snb_uncore_imc_init_box() steps on a range already reserved by that
driver on your box.  And this doesn't seem to be a coincidence, because the ACPI
device object in question probably *does* correspond to the memory controller
that the uncore driver attempts to use.

I'm not sure how to address that right now to be honest.  Arguably, the PNP
"system" driver should be replaced with something saner, but still the
resources it claims need to be kept out of reach of the PCI's resource
allocation code.

> ...
> [    0.488998] software IO TLB [mem 0xcac30000-0xcec30000] (64MB) mapped at [ffff8800cac30000-ffff8800cec2ffff]
> [    0.489975] resource map sanity check conflict: 0xfed10000 0xfed15fff 0xfed10000 0xfed13fff pnp 00:01
> [    0.490079] ------------[ cut here ]------------
> [    0.490204] WARNING: CPU: 2 PID: 1 at arch/x86/mm/ioremap.c:171 __ioremap_caller+0x372/0x380()
> [    0.490306] Info: mapping multiple BARs. Your kernel is fine.
> [    0.490371] Modules linked in:
> [    0.490558] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 3.14.0-rc4+ #1
> [    0.490642] Hardware name: LENOVO 2320CTO/2320CTO, BIOS G2ET86WW (2.06 ) 11/13/2012
> [    0.490742]  00000000000000ab ffff880213d01ad8 ffffffff816112e3 0000000000000006
> [    0.491032]  ffff880213d01b28 ffff880213d01b18 ffffffff8104e9bc ffff880213d01b08
> [    0.491343]  ffffc90000c58000 00000000fed10000 00000000fed10000 0000000000006000
> [    0.491631] Call Trace:
> [    0.493337]  [<ffffffff816112e3>] dump_stack+0x4f/0x7c
> [    0.493420]  [<ffffffff8104e9bc>] warn_slowpath_common+0x8c/0xc0
> [    0.493503]  [<ffffffff8104eaa6>] warn_slowpath_fmt+0x46/0x50
> [    0.493588]  [<ffffffff8103f1e2>] __ioremap_caller+0x372/0x380
> [    0.493674]  [<ffffffff810211a2>] ? snb_uncore_imc_init_box+0x62/0x90
> [    0.493761]  [<ffffffff8103f247>] ioremap_nocache+0x17/0x20
> [    0.493846]  [<ffffffff810211a2>] snb_uncore_imc_init_box+0x62/0x90
> [    0.493933]  [<ffffffff81022925>] uncore_pci_probe+0xe5/0x1e0
> [    0.494020]  [<ffffffff812d487e>] local_pci_probe+0x4e/0xa0
> [    0.494104]  [<ffffffff81418a59>] ? get_device+0x19/0x20
> [    0.494213]  [<ffffffff812d5cd1>] pci_device_probe+0xe1/0x130
> [    0.494300]  [<ffffffff8141d3cb>] driver_probe_device+0x7b/0x240
> [    0.494385]  [<ffffffff8141d63b>] __driver_attach+0xab/0xb0
> [    0.494469]  [<ffffffff8141d590>] ? driver_probe_device+0x240/0x240
> [    0.494551]  [<ffffffff8141b71e>] bus_for_each_dev+0x5e/0x90
> [    0.494634]  [<ffffffff8141cede>] driver_attach+0x1e/0x20
> [    0.494718]  [<ffffffff8141ca57>] bus_add_driver+0x117/0x230
> [    0.494802]  [<ffffffff8141dd34>] driver_register+0x64/0xf0
> [    0.494884]  [<ffffffff812d4c14>] __pci_register_driver+0x64/0x70
> [    0.494972]  [<ffffffff81d0319b>] ? uncore_types_init+0x19c/0x19c
> [    0.495056]  [<ffffffff81d03312>] intel_uncore_init+0x177/0x41c
> [    0.495155]  [<ffffffff81d0319b>] ? uncore_types_init+0x19c/0x19c
> [    0.495242]  [<ffffffff8100029e>] do_one_initcall+0x4e/0x170
> [    0.495326]  [<ffffffff81071100>] ? parse_args+0x60/0x360
> [    0.495411]  [<ffffffff81cfbfb8>] kernel_init_freeable+0x106/0x19a
> [    0.495497]  [<ffffffff81cfb83b>] ? do_early_param+0x86/0x86
> [    0.495582]  [<ffffffff81607ef0>] ? rest_init+0xd0/0xd0
> [    0.495666]  [<ffffffff81607efe>] kernel_init+0xe/0xf0
> [    0.495749]  [<ffffffff81621f6c>] ret_from_fork+0x7c/0xb0
> [    0.495831]  [<ffffffff81607ef0>] ? rest_init+0xd0/0xd0
> [    0.495921] ---[ end trace 428f365c054d9a01 ]---
> [    0.496196] RAPL PMU detected, hw unit 2^-16 Joules, API unit is 2^-32 Joules, 3 fixed counters 163840 ms ovfl timer
> [    0.498598] futex hash table entries: 1024 (order: 5, 131072 bytes)
> [    0.498833] audit: initializing netlink subsys (disabled)
> [    0.499024] audit: type=2000 audit(1393259866.477:1): initialized
> ...
> 
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  parent reply	other threads:[~2014-03-15 14:15 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 16:24 Info: mapping multiple BARs. Your kernel is fine Borislav Petkov
2014-02-24 16:24 ` Borislav Petkov
2014-02-24 20:19 ` Borislav Petkov
2014-02-24 20:19   ` Borislav Petkov
2014-02-25 15:48   ` H. Peter Anvin
2014-02-25 16:14     ` Stephane Eranian
2014-02-25 16:30       ` Borislav Petkov
2014-02-25 16:30         ` Borislav Petkov
2014-02-25 16:33         ` Stephane Eranian
2014-02-25 17:39           ` Borislav Petkov
2014-02-25 17:39             ` Borislav Petkov
2014-02-25 18:54             ` Stephane Eranian
2014-02-25 22:10               ` Borislav Petkov
2014-02-25 22:10                 ` Borislav Petkov
2014-02-26  6:56                 ` Stephane Eranian
2014-02-26  9:29                   ` Borislav Petkov
2014-02-26  9:29                     ` Borislav Petkov
2014-02-26  9:47                     ` Stephane Eranian
2014-02-26  9:59                       ` Borislav Petkov
2014-02-26  9:59                         ` Borislav Petkov
2014-02-27 10:12                         ` Stephane Eranian
2014-02-27 10:27                           ` Borislav Petkov
2014-02-27 10:27                             ` Borislav Petkov
2014-02-27 22:12                             ` Rafael J. Wysocki
2014-02-27 22:12                               ` Rafael J. Wysocki
2014-02-27 22:21                               ` Borislav Petkov
2014-02-27 22:21                                 ` Borislav Petkov
2014-03-05 21:03                                 ` Stephane Eranian
2014-03-05 21:03                                   ` Stephane Eranian
2014-02-27 10:30                           ` Peter Zijlstra
2014-02-27 10:30                             ` Peter Zijlstra
2014-02-27 10:32                             ` Stephane Eranian
2014-02-27 11:08                               ` Peter Zijlstra
2014-02-27 11:08                                 ` Peter Zijlstra
2014-02-27 12:20                                 ` Stephane Eranian
2014-02-26 13:57 ` Rafael J. Wysocki
2014-02-26 13:57   ` Rafael J. Wysocki
2014-02-26 13:50   ` Peter Zijlstra
2014-02-26 13:50     ` Peter Zijlstra
2014-02-26 13:52   ` Borislav Petkov
2014-02-26 13:52     ` Borislav Petkov
2014-03-15 14:15 ` Rafael J. Wysocki [this message]
2014-03-16 11:55   ` Borislav Petkov
2014-03-16 13:08     ` Stephane Eranian
2014-03-17  0:09       ` Rafael J. Wysocki
2014-03-17  0:23         ` Rafael J. Wysocki
2014-03-20  2:24   ` Aaron Lu
2014-03-20  2:29     ` Stephane Eranian
2014-03-20  3:03     ` Zhang, Rui
2014-03-20  3:03       ` Zhang, Rui
2014-03-20  3:03       ` Zhang, Rui
2014-03-20  3:34       ` Stephane Eranian
2014-03-20  7:53         ` Zhang, Rui
2014-03-20  7:53           ` Zhang, Rui
2014-03-20  7:53           ` Zhang, Rui
2014-03-20  8:16           ` Yan, Zheng
2014-03-20 13:43             ` Zhang Rui
2014-03-20 16:03             ` Stephane Eranian
2014-03-20 13:35           ` Zhang Rui
2014-03-20 13:35             ` Zhang Rui
2014-03-20 12:29       ` Rafael J. Wysocki
2014-03-20 16:45       ` Bjorn Helgaas
2014-03-20 20:55         ` Rafael J. Wysocki
2014-03-20 20:48           ` Bjorn Helgaas
2014-04-16 19:04             ` Borislav Petkov
2014-04-16 20:24               ` Zhang, Rui
2014-04-16 20:24                 ` Zhang, Rui
2014-04-16 20:24                 ` Zhang, Rui
2014-04-16 20:31               ` Bjorn Helgaas
2014-04-16 22:31                 ` Dave Jones
2014-04-16 22:56                   ` Bjorn Helgaas
2014-04-17  0:18                     ` Dave Jones
2014-04-17 10:45                     ` Borislav Petkov
2014-04-17 18:26                       ` Bjorn Helgaas
2014-04-17 19:48                         ` Borislav Petkov
2014-04-17 20:10                           ` Bjorn Helgaas
2014-04-17 19:52                         ` Dave Jones
2014-04-17 20:01                           ` Borislav Petkov
2014-04-17 20:03                             ` Dave Jones
2014-04-17 20:53                               ` Dave Jones
2014-04-17 21:01                                 ` Borislav Petkov
     [not found]                                   ` <20140417213027.GA22412@redhat.com>
2014-04-18 10:38                                     ` Borislav Petkov
2014-04-16 23:08                 ` Stephane Eranian
2014-04-16 23:11                   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4205942.Tp8ltEsv6e@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.