From: Lyude Paul <lyude@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, airlied@linux.ie,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
jani.nikula@linux.intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/8] drm: Introduce display-helper library
Date: Tue, 29 Mar 2022 15:26:09 -0400 [thread overview]
Message-ID: <420c66cf3d4bf76d54ad4ee437fec079e82e0e99.camel@redhat.com> (raw)
In-Reply-To: <20220322192743.14414-1-tzimmermann@suse.de>
For patches 2, 3, and 4: Reviewed-by: Lyude Paul <lyude@redhat.com>
On Tue, 2022-03-22 at 20:27 +0100, Thomas Zimmermann wrote:
> Move DisplayPort, HDMI and various other display helpers from KMS
> helpers into a new module. Adapt all drivers.
>
> This patch is part of an on-going effort to reduce the minimum size
> of DRM when linked into the kernel binary. The helpers for various
> display and video-output standards are not required for minimal
> graphics output and can be moved into a separate module.
>
> The DisplayPort code was already part of the DP module, which now
> forms the base of the display-helper module. Moving other helpers
> into the new module reduces KMS helpers by ~14 KiB (from 243 KiB to
> 229 KiB). More importantly, restructuring the code allows for a more
> fine-grained selection of helpers and dependencies.
>
> Built on x64-64, i586, aarch64, and arm.
>
> Thomas Zimmermann (8):
> drm: Put related statements next to each other in Makefile
> drm: Rename dp/ to display/
> drm/display: Introduce a DRM display-helper module
> drm/display: Split DisplayPort header into core and helper
> drm/display: Move DSC header and helpers into display-helper module
> drm/display: Move HDCP helpers into display-helper module
> drm/display: Move HDMI helpers into display-helper module
> drm/display: Move SCDC helpers into display-helper library
>
> Documentation/gpu/drm-kms-helpers.rst | 43 +-
> drivers/gpu/drm/Kconfig | 23 +
> drivers/gpu/drm/Makefile | 29 +-
> .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 +-
> drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 3 +-
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 +
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 +
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 +
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 +
> drivers/gpu/drm/amd/display/Kconfig | 1 +
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +-
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
> .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 2 +-
> .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +-
> .../drm/amd/display/dc/core/dc_link_dpcd.c | 2 +-
> .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 2 +
> .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.h | 2 +-
> .../drm/amd/display/dc/dml/dsc/rc_calc_fpu.h | 2 +-
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 4 +-
> .../gpu/drm/amd/display/dc/dsc/dscc_types.h | 2 +-
> .../gpu/drm/amd/display/dc/dsc/rc_calc_dpi.c | 2 +-
> drivers/gpu/drm/amd/display/dc/os_types.h | 2 +-
> .../gpu/drm/amd/display/include/dpcd_defs.h | 2 +-
> .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 4 +-
> drivers/gpu/drm/bridge/Kconfig | 5 +
> drivers/gpu/drm/bridge/analogix/Kconfig | 2 +
> .../drm/bridge/analogix/analogix-anx6345.c | 2 +-
> .../drm/bridge/analogix/analogix-anx78xx.c | 4 +-
> .../drm/bridge/analogix/analogix-i2c-dptx.c | 2 +-
> .../drm/bridge/analogix/analogix_dp_core.h | 2 +-
> drivers/gpu/drm/bridge/analogix/anx7625.c | 6 +-
> drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> .../drm/bridge/cadence/cdns-mhdp8546-core.c | 4 +-
> .../drm/bridge/cadence/cdns-mhdp8546-core.h | 2 +-
> .../drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 2 +-
> drivers/gpu/drm/bridge/ite-it6505.c | 4 +-
> drivers/gpu/drm/bridge/parade-ps8640.c | 4 +-
> drivers/gpu/drm/bridge/sii902x.c | 2 +-
> drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
> drivers/gpu/drm/bridge/synopsys/Kconfig | 1 +
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +-
> drivers/gpu/drm/bridge/tc358767.c | 2 +-
> drivers/gpu/drm/bridge/tc358775.c | 2 +-
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 +-
> drivers/gpu/drm/display/Makefile | 13 +
> .../drm_display_helper_mod.c} | 10 +-
> .../gpu/drm/{dp => display}/drm_dp_aux_bus.c | 4 +-
> .../gpu/drm/{dp => display}/drm_dp_aux_dev.c | 4 +-
> drivers/gpu/drm/{dp => display}/drm_dp_cec.c | 2 +-
> .../{dp => display}/drm_dp_dual_mode_helper.c | 2 +-
> .../{dp/drm_dp.c => display/drm_dp_helper.c} | 4 +-
> .../{dp => display}/drm_dp_helper_internal.h | 0
> .../drm/{dp => display}/drm_dp_mst_topology.c | 2 +-
> .../drm_dp_mst_topology_internal.h | 2 +-
> .../{drm_dsc.c => display/drm_dsc_helper.c} | 5 +-
> .../{drm_hdcp.c => display/drm_hdcp_helper.c} | 4 +-
> drivers/gpu/drm/display/drm_hdmi_helper.c | 463 +++++++++++
> .../gpu/drm/{ => display}/drm_scdc_helper.c | 3 +-
> drivers/gpu/drm/dp/Makefile | 9 -
> drivers/gpu/drm/drm_connector.c | 34 -
> drivers/gpu/drm/drm_edid.c | 439 +----------
> drivers/gpu/drm/drm_mipi_dsi.c | 6 +-
> drivers/gpu/drm/exynos/Kconfig | 1 +
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
> drivers/gpu/drm/gma500/intel_bios.c | 3 +-
> drivers/gpu/drm/hdmi/Makefile | 4 +
> drivers/gpu/drm/i2c/Kconfig | 1 +
> drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
> drivers/gpu/drm/i915/Kconfig | 2 +
> drivers/gpu/drm/i915/display/icl_dsi.c | 1 +
> drivers/gpu/drm/i915/display/intel_bios.c | 3 +-
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> .../drm/i915/display/intel_display_types.h | 6 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 5 +-
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 6 +-
> .../drm/i915/display/intel_dp_link_training.h | 2 +-
> drivers/gpu/drm/i915/display/intel_gmbus.c | 2 +-
> drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +-
> drivers/gpu/drm/i915/display/intel_lspcon.c | 4 +-
> .../gpu/drm/i915/display/intel_qp_tables.c | 2 +-
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 +
> drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +
> drivers/gpu/drm/mediatek/Kconfig | 1 +
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +-
> drivers/gpu/drm/msm/Kconfig | 1 +
> drivers/gpu/drm/msm/dp/dp_audio.c | 2 +-
> drivers/gpu/drm/msm/dp/dp_aux.h | 2 +-
> drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
> drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 +-
> drivers/gpu/drm/msm/edp/edp.h | 3 +-
> drivers/gpu/drm/msm/edp/edp_ctrl.c | 3 +-
> drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +
> drivers/gpu/drm/nouveau/Kconfig | 1 +
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 5 +-
> drivers/gpu/drm/nouveau/nouveau_connector.h | 2 +-
> drivers/gpu/drm/nouveau/nouveau_dp.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_encoder.h | 6 +-
> drivers/gpu/drm/omapdrm/Kconfig | 2 +
> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 +
> drivers/gpu/drm/panel/panel-edp.c | 4 +-
> .../gpu/drm/panel/panel-samsung-atna33xc20.c | 4 +-
> drivers/gpu/drm/radeon/atombios_dp.c | 2 +-
> drivers/gpu/drm/radeon/radeon_audio.c | 1 +
> drivers/gpu/drm/radeon/radeon_connectors.c | 2 +-
> drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +-
> drivers/gpu/drm/radeon/radeon_mode.h | 4 +-
> drivers/gpu/drm/rockchip/Kconfig | 2 +
> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
> drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 +
> drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +-
> drivers/gpu/drm/rockchip/rockchip_rgb.c | 2 +-
> .../drm/selftests/test-drm_dp_mst_helper.c | 4 +-
> drivers/gpu/drm/sti/Kconfig | 1 +
> drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> drivers/gpu/drm/sun4i/Kconfig | 1 +
> drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +-
> drivers/gpu/drm/tegra/Kconfig | 1 +
> drivers/gpu/drm/tegra/dp.c | 2 +-
> drivers/gpu/drm/tegra/dpaux.c | 4 +-
> drivers/gpu/drm/tegra/hdmi.c | 1 +
> drivers/gpu/drm/tegra/sor.c | 5 +-
> drivers/gpu/drm/vc4/Kconfig | 1 +
> drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +-
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> drivers/misc/mei/hdcp/mei_hdcp.h | 2 +-
> .../{dp/drm_dp_helper.h => display/drm_dp.h} | 695 +----------------
> include/drm/{dp => display}/drm_dp_aux_bus.h | 0
> .../{dp => display}/drm_dp_dual_mode_helper.h | 0
> include/drm/display/drm_dp_helper.h | 719 ++++++++++++++++++
> .../drm/{dp => display}/drm_dp_mst_helper.h | 2 +-
> include/drm/{ => display}/drm_dsc.h | 8 +-
> include/drm/display/drm_dsc_helper.h | 20 +
> include/drm/{ => display}/drm_hdcp.h | 14 +-
> include/drm/display/drm_hdcp_helper.h | 22 +
> include/drm/display/drm_hdmi_helper.h | 36 +
> .../{drm_scdc_helper.h => display/drm_scdc.h} | 52 +-
> include/drm/display/drm_scdc_helper.h | 79 ++
> include/drm/drm_connector.h | 2 -
> include/drm/drm_edid.h | 31 +-
> include/drm/i915_mei_hdcp_interface.h | 2 +-
> 147 files changed, 1631 insertions(+), 1428 deletions(-)
> create mode 100644 drivers/gpu/drm/display/Makefile
> rename drivers/gpu/drm/{dp/drm_dp_helper_mod.c =>
> display/drm_display_helper_mod.c} (51%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_aux_bus.c (99%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_aux_dev.c (99%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_cec.c (99%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_dual_mode_helper.c (99%)
> rename drivers/gpu/drm/{dp/drm_dp.c => display/drm_dp_helper.c} (99%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_helper_internal.h (100%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_mst_topology.c (99%)
> rename drivers/gpu/drm/{dp => display}/drm_dp_mst_topology_internal.h (94%)
> rename drivers/gpu/drm/{drm_dsc.c => display/drm_dsc_helper.c} (99%)
> rename drivers/gpu/drm/{drm_hdcp.c => display/drm_hdcp_helper.c} (99%)
> create mode 100644 drivers/gpu/drm/display/drm_hdmi_helper.c
> rename drivers/gpu/drm/{ => display}/drm_scdc_helper.c (99%)
> delete mode 100644 drivers/gpu/drm/dp/Makefile
> create mode 100644 drivers/gpu/drm/hdmi/Makefile
> rename include/drm/{dp/drm_dp_helper.h => display/drm_dp.h} (74%)
> rename include/drm/{dp => display}/drm_dp_aux_bus.h (100%)
> rename include/drm/{dp => display}/drm_dp_dual_mode_helper.h (100%)
> create mode 100644 include/drm/display/drm_dp_helper.h
> rename include/drm/{dp => display}/drm_dp_mst_helper.h (99%)
> rename include/drm/{ => display}/drm_dsc.h (97%)
> create mode 100644 include/drm/display/drm_dsc_helper.h
> rename include/drm/{ => display}/drm_hdcp.h (95%)
> create mode 100644 include/drm/display/drm_hdcp_helper.h
> create mode 100644 include/drm/display/drm_hdmi_helper.h
> rename include/drm/{drm_scdc_helper.h => display/drm_scdc.h} (65%)
> create mode 100644 include/drm/display/drm_scdc_helper.h
>
>
> base-commit: fe83949cd4316608ea785fc376b6ed444224adad
> prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
> prerequisite-patch-id: 6e1032c6302461624f33194c8b8f37103a3fa6ef
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
prev parent reply other threads:[~2022-03-29 19:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 19:27 [PATCH 0/8] drm: Introduce display-helper library Thomas Zimmermann
2022-03-22 19:27 ` [PATCH 1/8] drm: Put related statements next to each other in Makefile Thomas Zimmermann
2022-03-30 8:13 ` Jani Nikula
2022-03-30 8:13 ` Javier Martinez Canillas
2022-03-22 19:27 ` [PATCH 2/8] drm: Rename dp/ to display/ Thomas Zimmermann
2022-03-30 9:04 ` Javier Martinez Canillas
2022-03-30 9:24 ` Thomas Zimmermann
2022-03-30 13:52 ` Alex Deucher
2022-03-22 19:27 ` [PATCH 3/8] drm/display: Introduce a DRM display-helper module Thomas Zimmermann
2022-03-30 9:23 ` Javier Martinez Canillas
2022-03-30 10:32 ` Thomas Zimmermann
2022-03-31 6:57 ` Javier Martinez Canillas
2022-04-06 19:08 ` Thomas Zimmermann
2022-04-07 7:43 ` Javier Martinez Canillas
2022-04-07 8:03 ` Thomas Zimmermann
2022-04-07 8:45 ` Jani Nikula
2022-04-18 18:13 ` Thomas Zimmermann
2022-03-22 19:27 ` [PATCH 4/8] drm/display: Split DisplayPort header into core and helper Thomas Zimmermann
2022-04-01 7:18 ` Javier Martinez Canillas
2022-03-22 19:27 ` [PATCH 5/8] drm/display: Move DSC header and helpers into display-helper module Thomas Zimmermann
2022-04-01 7:23 ` Javier Martinez Canillas
2022-03-22 19:27 ` [PATCH 6/8] drm/display: Move HDCP " Thomas Zimmermann
2022-03-30 7:12 ` Jani Nikula
2022-03-30 8:05 ` Thomas Zimmermann
2022-04-01 8:23 ` Javier Martinez Canillas
2022-03-22 19:27 ` [PATCH 7/8] drm/display: Move HDMI " Thomas Zimmermann
2022-03-30 10:35 ` Jani Nikula
2022-04-06 19:47 ` Thomas Zimmermann
2022-04-07 7:32 ` Jani Nikula
2022-04-07 7:34 ` Jani Nikula
2022-04-07 7:44 ` Thomas Zimmermann
2022-03-22 19:27 ` [PATCH 8/8] drm/display: Move SCDC helpers into display-helper library Thomas Zimmermann
2022-03-29 19:26 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420c66cf3d4bf76d54ad4ee437fec079e82e0e99.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.