All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.com>
To: Jason Yan <yanaijie@huawei.com>,
	martin.petersen@oracle.com, jejb@linux.vnet.ibm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	john.garry@huawei.com, zhaohongjiang@huawei.com,
	dan.j.williams@intel.com, jthumshirn@suse.de, hch@lst.de,
	huangdaode@hisilicon.com, chenxiang66@hisilicon.com,
	miaoxie@huawei.com, Ewan Milne <emilne@redhat.com>,
	Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c
Date: Mon, 17 Sep 2018 15:53:33 +0200	[thread overview]
Message-ID: <4218aff0-92d5-dee2-2d60-8f24b71c4ad9@suse.com> (raw)
In-Reply-To: <20180912082946.34814-2-yanaijie@huawei.com>

On 09/12/2018 10:29 AM, Jason Yan wrote:
> This code is dead and no clue implies that it will be back again.
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> CC: John Garry <john.garry@huawei.com>
> CC: Johannes Thumshirn <jthumshirn@suse.de>
> CC: Ewan Milne <emilne@redhat.com>
> CC: Christoph Hellwig <hch@lst.de>
> CC: Tomas Henzl <thenzl@redhat.com>
> CC: Dan Williams <dan.j.williams@intel.com>
> CC: Hannes Reinecke <hare@suse.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
>  drivers/scsi/scsi_transport_sas.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
> index 0cd16e80b019..0a165b2b3e81 100644
> --- a/drivers/scsi/scsi_transport_sas.c
> +++ b/drivers/scsi/scsi_transport_sas.c
> @@ -612,7 +612,6 @@ sas_phy_protocol_attr(identify.target_port_protocols,
>  sas_phy_simple_attr(identify.sas_address, sas_address, "0x%016llx\n",
>  		unsigned long long);
>  sas_phy_simple_attr(identify.phy_identifier, phy_identifier, "%d\n", u8);
> -//sas_phy_simple_attr(port_identifier, port_identifier, "%d\n", int);
>  sas_phy_linkspeed_attr(negotiated_linkrate);
>  sas_phy_linkspeed_attr(minimum_linkrate_hw);
>  sas_phy_linkspeed_rw_attr(minimum_linkrate);
> @@ -1802,7 +1801,6 @@ sas_attach_transport(struct sas_function_template *ft)
>  	SETUP_PHY_ATTRIBUTE(device_type);
>  	SETUP_PHY_ATTRIBUTE(sas_address);
>  	SETUP_PHY_ATTRIBUTE(phy_identifier);
> -	//SETUP_PHY_ATTRIBUTE(port_identifier);
>  	SETUP_PHY_ATTRIBUTE(negotiated_linkrate);
>  	SETUP_PHY_ATTRIBUTE(minimum_linkrate_hw);
>  	SETUP_PHY_ATTRIBUTE_RW(minimum_linkrate);
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes

  parent reply	other threads:[~2018-09-17 13:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12  8:29 [PATCH 0/5] scsi: libsas: some code cleanups and bug fixes Jason Yan
2018-09-12  8:29 ` Jason Yan
2018-09-12  8:29 ` [PATCH 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c Jason Yan
2018-09-12  8:29   ` Jason Yan
2018-09-17  8:35   ` John Garry
2018-09-17  8:35     ` John Garry
2018-09-17 13:53   ` Hannes Reinecke [this message]
2018-09-12  8:29 ` [PATCH 2/5] scsi: libsas: check the lldd callback correctly Jason Yan
2018-09-12  8:29   ` Jason Yan
2018-09-17  8:11   ` John Garry
2018-09-17  8:11     ` John Garry
2018-09-17 13:54   ` Hannes Reinecke
2018-09-12  8:29 ` [PATCH 3/5] scsi: libsas: always unregister the old device if going to discover new Jason Yan
2018-09-12  8:29   ` Jason Yan
2018-09-17 13:55   ` Hannes Reinecke
2018-09-12  8:29 ` [PATCH 4/5] scsi: libsas: check the ata device status by ata_dev_enabled() Jason Yan
2018-09-12  8:29   ` Jason Yan
2018-09-17 13:56   ` Hannes Reinecke
2018-09-18 13:54   ` John Garry
2018-09-18 13:54     ` John Garry
2018-09-19  2:54     ` Jason Yan
2018-09-19  2:54       ` Jason Yan
2018-09-12  8:29 ` [PATCH 5/5] scsi: libsas: fix a race condition when smp task timeout Jason Yan
2018-09-12  8:29   ` Jason Yan
2018-09-17  9:47   ` John Garry
2018-09-17  9:47     ` John Garry
2018-09-19  2:49     ` Jason Yan
2018-09-19  2:49       ` Jason Yan
2018-09-19  8:39       ` John Garry
2018-09-19  8:39         ` John Garry
2018-09-17 13:57   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4218aff0-92d5-dee2-2d60-8f24b71c4ad9@suse.com \
    --to=hare@suse.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dan.j.williams@intel.com \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=huangdaode@hisilicon.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=miaoxie@huawei.com \
    --cc=thenzl@redhat.com \
    --cc=yanaijie@huawei.com \
    --cc=zhaohongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.