From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iGLHX-0004Vt-CH for mharc-grub-devel@gnu.org; Fri, 04 Oct 2019 06:57:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46063) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGLHT-0004NA-64 for grub-devel@gnu.org; Fri, 04 Oct 2019 06:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGLHR-0002Kq-D5 for grub-devel@gnu.org; Fri, 04 Oct 2019 06:57:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGLHR-0002Jm-7l for grub-devel@gnu.org; Fri, 04 Oct 2019 06:57:49 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 943387FDCD for ; Fri, 4 Oct 2019 10:57:47 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id c17so2269876wro.18 for ; Fri, 04 Oct 2019 03:57:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ceVmNT+cBCqV9vhBzAxWVFcWzX9HGMFSm+in3nUueoE=; b=jjTVot+6orDsABXR8wXAgXH9uB+bCjb3AtOAfY1zmLsHuO9HYr5DqcUC3eWgdeeBtK cXXDu919z2sOqpmAnh+8idmsfN0n0Ls5/kD9CMpX+CYfJjRd0n8Bgza6uucntnJqf5VJ zSI08lA/3yOCZg73JqDU/F2t8RwOnC3ssbebKK7WfQvAIPRfA0Kh68vkBuIMztNHbawP nAi0bHU6mgN11L+zMgouWz6ns6OfJcdEezgKeIDqtR/MKlUyohJS37rQDMnGa8Rxppss 26cV3JJ+HrmAg6GStZxYDKRXGYg6wVZuKYuR9vdyWyWmCLrJv75UuyBrC9wi0c39uB5d Yptw== X-Gm-Message-State: APjAAAW+X+W13/bA0z1fjztrCzVIECBOFMSQIs5c4lS/l9R//hDIr+Xl NYGFkw5wkS4SsEuWQZdizYNAjYkByFV1GHjwf3z+4COkACTC+9ePmaBf4C++TLAeGKNJpCemIy3 1XAdghUecf1k= X-Received: by 2002:a1c:658b:: with SMTP id z133mr10651700wmb.130.1570186666347; Fri, 04 Oct 2019 03:57:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTTi6yRkC3ufGcre6L+IORHFaorFmKFm/bOQyNxmIYeZ/2C0Of8W6eOYXk2J7pUDjMTo7f5Q== X-Received: by 2002:a1c:658b:: with SMTP id z133mr10651686wmb.130.1570186666145; Fri, 04 Oct 2019 03:57:46 -0700 (PDT) Received: from [192.168.1.13] ([90.168.169.92]) by smtp.gmail.com with ESMTPSA id c10sm8558895wrf.58.2019.10.04.03.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2019 03:57:45 -0700 (PDT) Subject: Re: [PATCH v2] Add GRUB_DISABLE_UUID To: Nicholas Vinson , Daniel Kiper Cc: grub-devel@gnu.org, Peter Jones , Vladimir Serbinenko References: <20190930145912.20375-1-javierm@redhat.com> <20191002120955.5qkvrjqsnpmmwcyy@tomti.i.net-space.pl> <85453966-4f9d-39c0-ccb7-310dfd23d537@gmail.com> From: Javier Martinez Canillas Message-ID: <422ba861-a9fc-2f0e-751b-b23326491ce9@redhat.com> Date: Fri, 4 Oct 2019 12:57:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <85453966-4f9d-39c0-ccb7-310dfd23d537@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2019 10:57:53 -0000 Hello Nicolas, Thanks a lot for the feedback. On 10/3/19 4:29 AM, Nicholas Vinson wrote: [snip] >>> >>> +if [ "x${GRUB_DISABLE_UUID}" = "xtrue" ]; then >>> + if [ "x${GRUB_DISABLE_LINUX_UUID}" != "xfalse" ]; then >>> + GRUB_DISABLE_LINUX_UUID="true" >>> + fi >>> + if [ "x${GRUB_DISABLE_LINUX_PARTUUID}" != "xfalse" ]; then >>> + GRUB_DISABLE_LINUX_PARTUUID="true" >>> + fi >>> +fi > > I don't think this logic is exactly consistent with > 51be3372ec8ba07ef68a409956ea0eefa89fe7c5. That commit assumes any value > other than 'true' is false. It also sets the default values for I'm not sure how we could make it more consistent with the mentioned commit while only setting it to 'true' if the user haven't explicitly set the var as Dan asked in the previous version of the patch. > GRUB_DISABLE_LINUX_PARTUUID in 10_linux.in and 20_linux_xen.in. > This isn't an issue since that's only when GRUB_DISABLE_LINUX_PARTUUID hasn't been set, but it will be set to 'true' if GRUB_DISABLE_UUID=true. > Both minor issues, but I do wonder if they should be addressed. > > Thanks, > Nicholas Vinson > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat