All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luca Bocassi" <luca.boccassi@gmail.com>
To: OE-core <openembedded-core@lists.openembedded.org>
Cc: Khem Raj <raj.khem@gmail.com>
Subject: Re: [PATCH] systemd: Fix build on musl
Date: Thu, 29 Jul 2021 14:49:49 +0100	[thread overview]
Message-ID: <423aed88f51b09d6342089f4b02dc9d62bbdb413.camel@gmail.com> (raw)
In-Reply-To: <AM7PR83MB0436960F9D4BFDD1F504F0DFF1EB9@AM7PR83MB0436.EURPRD83.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2393 bytes --]

On Thu, 2021-07-29 at 12:59 +0000, Khem Raj wrote:
> 
> Latest upgrade to 249 broke a working build on musl, this is incremental
> fix to exisiting patches adapted to 249 release
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
>  ...002-don-t-use-glibc-specific-qsort_r.patch |  24 +--
>  ...missing.h-check-for-missing-strndupa.patch | 173 +++++++++---------
>  .../0006-Include-netinet-if_ether.h.patch     | 147 ++++++++-------
>  ...OB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch |  20 +-
>  ...T_SYMLINK_NOFOLLOW-flag-to-faccessat.patch |  14 +-
>  ...-not-disable-buffer-in-writing-files.patch | 143 ++++++---------
>  .../systemd/0026-Handle-missing-gshadow.patch |  18 +-
>  7 files changed, 247 insertions(+), 292 deletions(-)
> 

Having a look at the patches, a few comments:

- 0001-test-parse-argument-Include-signal.h.patch was merged upstream,
but never removed, I think because it was refactored so it applies
cleanly and doesn't raise errors?

- 0005-src-basic-missing.h-check-for-missing-strndupa.patch this is
massive and will keep growing and breaking the build, wouldn't it be
better to just implement strndupa in musl? Even out-of-tree it sounds
like it would be easier to maintain than this

- 0006-Include-netinet-if_ether.h.patch sounds like it should be doable
in a way that is compatible with both glibc and musl, and thus could be
upstreamed?

- 0010-Use-uintmax_t-for-handling-rlim_t.patch can be upstreamed but
needs to be reworked slightly as explained in 
https://github.com/systemd/systemd/pull/7199#issuecomment-358268647
which seems worth doing to me

- 0012-don-t-pass-AT_SYMLINK_NOFOLLOW-flag-to-faccessat.patch I find
quite worrying, as it fundamentally changes access patterns, some of
which are done for security reasons. At best, this will cause
completely different runtime behaviours for the same filesystem
depending on the libc implementation, which doesn't sound great?

- 0016-Hide-__start_BUS_ERROR_MAP-and-__stop_BUS_ERROR_MAP.patch sounds
like a genuine bug, have you tried upstreaming it?

- 0019-Handle-missing-LOCK_EX.patch I see no problem upstreaming this

- 0028-missing_syscall.h-Define-MIPS-ABI-defines-for-musl.patch should
also be fine to upstream I think, in src/basic/missing_syscall_def.h

-- 
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

  parent reply	other threads:[~2021-07-29 13:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 20:13 Khem Raj
2021-07-29 12:55 ` [OE-core] " Robert Berger
2021-07-29 16:00   ` Khem Raj
     [not found] ` <AM7PR83MB0436960F9D4BFDD1F504F0DFF1EB9@AM7PR83MB0436.EURPRD83.prod.outlook.com>
2021-07-29 13:49   ` Luca Bocassi [this message]
2021-07-29 13:54     ` Luca Bocassi
2021-07-29 14:37       ` [OE-core] " Alexander Kanavin
2021-07-29 17:47       ` Khem Raj
2021-07-29 19:11     ` [OE-core] " Andre McCurdy
2021-08-06 14:12       ` Luca Bocassi
2021-08-06 18:12         ` Andre McCurdy
  -- strict thread matches above, loose matches on Subject: below --
2021-02-07  1:40 Khem Raj
2017-10-27  5:10 Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423aed88f51b09d6342089f4b02dc9d62bbdb413.camel@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --subject='Re: [PATCH] systemd: Fix build on musl' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.