From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0
Date: Tue, 17 Dec 2019 08:38:48 +0100 [thread overview]
Message-ID: <423b0427-c8b3-8e2e-d64c-ae06d79214b6@denx.de> (raw)
In-Reply-To: <CANr=Z=Z9GFgXDfgee2eq_-U1Wk7qjsvRYKD5Yzxagk1H6vYRNQ@mail.gmail.com>
On 11/7/19 9:04 PM, Joe Hershberger wrote:
> On Thu, Nov 7, 2019 at 1:16 PM Tom Rini <trini@konsulko.com> wrote:
>>
>> On Tue, Nov 05, 2019 at 04:05:11AM +0000, Priyanka Jain wrote:
>>
>>> Fix 'mask' calculation in phy_connect() for phy addr '0'.
>>> 'mask' is getting set to '0xffffffff' for phy addr '0'
>>> in phy_connect() whereas expected value is '0'.
>>>
>>>
>>> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
>>
>> Reported-by: tetsu-aoki via github
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Sadly, this breaks systems where a PHY is at address 0.
I have such an STM32MP1 system with LAN8720 PHY and since this patch, I
cannot use ethernet. Please revert.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-12-17 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 4:05 [U-Boot] [PATCH] net/phy: Fix phy_connect() for phy addr 0 Priyanka Jain
2019-11-07 19:15 ` Tom Rini
2019-11-07 20:04 ` Joe Hershberger
2019-12-17 7:38 ` Marek Vasut [this message]
2019-12-17 12:52 ` Tom Rini
2019-12-17 13:16 ` Marek Vasut
2019-12-17 16:25 ` Joe Hershberger
2019-12-17 17:35 ` Marek Vasut
2019-12-17 18:47 ` Joe Hershberger
2019-12-17 19:04 ` Marek Vasut
2019-12-17 23:35 ` Tom Rini
2019-12-18 4:24 ` Marek Vasut
2019-12-18 2:11 ` Joe Hershberger
2019-12-18 4:48 ` Marek Vasut
2019-12-18 16:15 ` Joe Hershberger
2019-12-18 16:16 ` Marek Vasut
2019-12-19 6:30 ` Priyanka Jain
2019-12-19 12:16 ` Alexandru Marginean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423b0427-c8b3-8e2e-d64c-ae06d79214b6@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.