From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAKE0-0005Al-V6 for qemu-devel@nongnu.org; Tue, 07 Jun 2016 12:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAKDv-0003SA-22 for qemu-devel@nongnu.org; Tue, 07 Jun 2016 12:51:31 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:41926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAKDu-0003S1-Qy for qemu-devel@nongnu.org; Tue, 07 Jun 2016 12:51:26 -0400 References: <1465314555-11501-1-git-send-email-peer.adelt@c-lab.de> <1465314555-11501-5-git-send-email-peer.adelt@c-lab.de> From: Bastian Koppelmann Message-ID: <423be5b8-646e-78d4-b6c2-bc05ed3ad0b5@mail.uni-paderborn.de> Date: Tue, 7 Jun 2016 18:51:24 +0200 MIME-Version: 1.0 In-Reply-To: <1465314555-11501-5-git-send-email-peer.adelt@c-lab.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-tricore: Added new JNE instruction variant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peer.adelt@c-lab.de, qemu-devel@nongnu.org Cc: rth@twiddle.net On 06/07/2016 05:49 PM, peer.adelt@c-lab.de wrote: > From: Peer Adelt > > If D[15] is != sign_ext(const4) then PC will be set to (PC + > zero_ext(disp4 + 16)). > > Signed-off-by: Peer Adelt > --- > target-tricore/translate.c | 16 ++++++++++++++++ > target-tricore/tricore-opcodes.h | 2 ++ > 2 files changed, 18 insertions(+) > Minor nitpick -- the commit message should reflect that you added the JEQ variant as well. But I could do that when applying it to my tricore-next tree. Otherwise: Reviewed-by: Bastian Koppelmann Cheers, Bastian