Re: [yocto] [PATCH yocto-autobuilder-helper 1/4] config.json: add "collect-data" template

["Randy MacLeod" <randy.macleod@windriver.com>]

On 2021-04-15 11:55 a.m., Richard Purdie wrote:
> On Thu, 2021-04-15 at 11:31 -0400, Sakib Sajal wrote:
>> On 2021-04-15 9:52 a.m., Richard Purdie wrote:
>>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>>
>>> On Tue, 2021-04-13 at 13:02 -0400, sakib.sajal@windriver.com wrote:
>>>> collect-data template can run arbitrary commands/scripts
>>>> on a regular basis and logs the output in a file.
>>>>
>>>> See oe-core for more details:
>>>>       edb7098e9e buildstats.bbclass: add functionality to collect build system stats
>>>>
>>>> Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
>>>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>>>> ---
>>>>    config.json | 7 +++++++
>>>>    1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/config.json b/config.json
>>>> index 5bfa240..c43d231 100644
>>>> --- a/config.json
>>>> +++ b/config.json
>>>> @@ -87,6 +87,13 @@
>>>>                    "SANITYTARGETS" : "core-image-full-cmdline:do_testimage core-image-sato:do_testimage core-image-sato-sdk:do_testimage"
>>>>                }
>>>>            },
>>>> +     "collect-data" : {
>>>> +            "extravars" : [
>>>> +                "BB_HEARTBEAT_EVENT = '10'",
>>>> +                "BB_LOG_HOST_STAT_ON_INTERVAL = '1'",
>>>> +                "BB_LOG_HOST_STAT_CMDS = 'oe-time-dd-test.sh 100'"
>>>> +            ]
>>>> +        },
>>> Is the template used anywhere? I can't remember if we support nesting templates in which
>>> case this is useful, or not?

We were using it for testing on the YP AB and thought it would be
useful if at some point the monitoring was dropped from the
default config.

I think we can just add it later if needed.

../Randy
>>>
>>> Cheers,
>>>
>>> Richard
>>
>> The template is not used anywhere, yet, the initial patchset enables the
>> data collection by default.
>>
>> I have left the template in case the data collection is removed from
>> defaults and need to be used on a case by case basis.
>>
>> I am not entirely sure if nesting templates work. I have not seen any
>> examples of it, neither did i try it myself. If nesting does work, the
>> template should be useful.
> 
> I had a quick look at the code and sadly, it doesn't appear I implemented
> nesting so this wouldn't be that useful as things stand.
> 
> Cheers,
> 
> Richard
> 
> 
> 
> 
> 
> 


-- 
# Randy MacLeod
# Wind River Linux