From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next] bridge: use hlist_entry_safe Date: Thu, 26 Apr 2018 17:44:09 +0300 Message-ID: <426b1ae6-9fd8-a07b-790e-d01eb25a3990@cumulusnetworks.com> References: <20180426030705.6632-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org To: YueHaibing , stephen@networkplumber.org, davem@davemloft.net Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:46958 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756262AbeDZOoM (ORCPT ); Thu, 26 Apr 2018 10:44:12 -0400 Received: by mail-wr0-f193.google.com with SMTP id d1-v6so57028060wrj.13 for ; Thu, 26 Apr 2018 07:44:11 -0700 (PDT) In-Reply-To: <20180426030705.6632-1-yuehaibing@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 26/04/18 06:07, YueHaibing wrote: > Use hlist_entry_safe() instead of open-coding it. > > Signed-off-by: YueHaibing > --- > net/bridge/br_forward.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c > index b4eed11..7a7fd67 100644 > --- a/net/bridge/br_forward.c > +++ b/net/bridge/br_forward.c > @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, > struct net_bridge_port *port, *lport, *rport; > > lport = p ? p->port : NULL; > - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : > - NULL; > + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); > > if ((unsigned long)lport > (unsigned long)rport) { > port = lport; > Reviewed-by: Nikolay Aleksandrov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yPv2rhpzzDjziFVMLLuApOCSrtVCE+dprevKYftyJio=; b=fPgeRGMwcODw1h9Y3ZZZ6c5TjK1vIO2ArgQuHfE9KzRmbtDgTy2M4ON66Lqdju3ubw +Gc8oJUyEl7dusY4WDjeU8hR1YdMLEdiY1hjoimoYOlg7w2zpL8jPM4ondANdSDKnT+/ 36FiKYIYaYGaXmKY44VcBSA0HSiPIauASvd+0= References: <20180426030705.6632-1-yuehaibing@huawei.com> From: Nikolay Aleksandrov Message-ID: <426b1ae6-9fd8-a07b-790e-d01eb25a3990@cumulusnetworks.com> Date: Thu, 26 Apr 2018 17:44:09 +0300 MIME-Version: 1.0 In-Reply-To: <20180426030705.6632-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next] bridge: use hlist_entry_safe List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: YueHaibing , stephen@networkplumber.org, davem@davemloft.net Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org On 26/04/18 06:07, YueHaibing wrote: > Use hlist_entry_safe() instead of open-coding it. > > Signed-off-by: YueHaibing > --- > net/bridge/br_forward.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c > index b4eed11..7a7fd67 100644 > --- a/net/bridge/br_forward.c > +++ b/net/bridge/br_forward.c > @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, > struct net_bridge_port *port, *lport, *rport; > > lport = p ? p->port : NULL; > - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : > - NULL; > + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); > > if ((unsigned long)lport > (unsigned long)rport) { > port = lport; > Reviewed-by: Nikolay Aleksandrov