From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C07C77B62 for ; Tue, 28 Mar 2023 12:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbjC1M7B (ORCPT ); Tue, 28 Mar 2023 08:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbjC1M67 (ORCPT ); Tue, 28 Mar 2023 08:58:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 854A2B773; Tue, 28 Mar 2023 05:58:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8CE361776; Tue, 28 Mar 2023 12:58:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC61C4339B; Tue, 28 Mar 2023 12:58:22 +0000 (UTC) Message-ID: <426b4776-104c-cb47-c8cc-c26515fcb6e3@linux-m68k.org> Date: Tue, 28 Mar 2023 22:58:19 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Content-Language: en-US To: Marco Felsch Cc: Ahmad Fatoum , peng.fan@nxp.com, Alexander Stein , abailon@baylibre.com, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, abelvesa@kernel.org, marex@denx.de, Markus.Niebel@ew.tq-group.com, paul.elder@ideasonboard.com, gerg@kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, "Peng Fan (OSS)" , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, aford173@gmail.com, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org, kernel@pengutronix.de, djakov@kernel.org, l.stach@pengutronix.de, shawnguo@kernel.org, laurent.pinchart@ideasonboard.com References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org> <2678294.mvXUDI8C0e@steina-w> <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> From: Greg Ungerer In-Reply-To: <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marco, On 28/3/23 17:33, Marco Felsch wrote: > Hi Greg, > > On 23-03-27, Greg Ungerer wrote: >> Hi Ahmad, >> >> On 27/3/23 17:16, Ahmad Fatoum wrote: >>> On 27.03.23 08:27, Alexander Stein wrote: >>>> Am Montag, 27. März 2023, 06:50:37 CEST schrieb Greg Ungerer: >>>>> Any thoughts on why this breaks USB? >>>> >>>> Maybe you are missing CONFIG_INTERCONNECT_IMX8MP? >>> >>> And if that's the case, did you check /sys/kernel/debug/devices_deferred >>> to see if there was any indication that this is the reason? >> >> Yeah, it does: >> >> # cat /sys/kernel/debug/devices_deferred >> 32f10100.usb platform: supplier 32f10000.blk-ctrl not ready >> 32f10108.usb platform: supplier 32f10000.blk-ctrl not ready >> 32ec0000.blk-ctrl imx8m-blk-ctrl: failed to get noc entries >> 381f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready >> 382f0040.usb-phy platform: supplier 32f10000.blk-ctrl not ready >> imx-pgc-domain.11 >> imx-pgc-domain.12 >> imx-pgc-domain.13 >> 38330000.blk-ctrl platform: supplier imx-pgc-domain.11 not ready >> 32f10000.blk-ctrl imx8mp-blk-ctrl: failed to get noc entries >> >> As far as I can tell blk-ctrl should be good: >> >> # >> # i.MX SoC drivers >> # >> CONFIG_IMX_GPCV2_PM_DOMAINS=y >> CONFIG_SOC_IMX8M=y >> # CONFIG_SOC_IMX9 is not set >> CONFIG_IMX8M_BLK_CTRL=y >> # end of i.MX SoC drivers >> >> >>> If you didn't find any hint there, you might want to place a >>> dev_err_probe with a suitable message at the place where -EPROBE_DEFER >>> was returned. >> >> I will try that. > > Can you check that CONFIG_ARM_IMX_BUS_DEVFREQ is enabled? This is the > noc/interconnect driver. This could also the problem for you vpu issue. I do not have that enabled. Enabling that fixes the USB probing. So that is good, thanks. It doesn't fix the other problem I mentioned with the vpu pgc nodes though. I do get some extra messages now with this enabled and the 6.1 kernel: imx-pgc imx-pgc-domain.8: failed to command PGC imx-pgc imx-pgc-domain.8: failed to command PGC imx8m-blk-ctrl 38330000.blk-ctrl: deferred probe timeout, ignoring dependency imx8m-blk-ctrl 38330000.blk-ctrl: error -110: failed to attach power domain "g1" imx8m-blk-ctrl: probe of 38330000.blk-ctrl failed with error -110 Regards Greg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC880C6FD18 for ; Tue, 28 Mar 2023 12:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1KMioqMuo05uGSg0oRpc5C7fYqNr7/mlQbMCKAqY8+A=; b=ZrlJGEcMbsg8g9 xQlK3/PQ7G2y2sTYCK6zpgPr06oLtOiL7KpNbaFqWwlYIpa6HTjkNl0wlk42pPAMvRRIvVfTod9nT oz8AK6nZC/tafZqll69kob4CCvpk11BKqtYkghf6zpyVjn+rUDR0cAd+9D8VFdmX1KiQAXBep6swB hs0HhLOoDkfLmULyma0FdM/87VmS7ErtB/KtcvBATf/QvVhwm2xiZSZ0fpKRZXXngyPt0geZwujuQ mD9a+IIqXSFFpYwYJdJcVoGZ81SlRy438ODs6hLzDPFNyLPcJOZcRkkclPZPMXfB7LP2JgDDKgAA+ asonmSJACPP6J7yjo5zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph8uH-00ETDU-1X; Tue, 28 Mar 2023 12:58:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph8uF-00ETCY-0R for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 12:58:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8CB76172B; Tue, 28 Mar 2023 12:58:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC61C4339B; Tue, 28 Mar 2023 12:58:22 +0000 (UTC) Message-ID: <426b4776-104c-cb47-c8cc-c26515fcb6e3@linux-m68k.org> Date: Tue, 28 Mar 2023 22:58:19 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Content-Language: en-US To: Marco Felsch Cc: Ahmad Fatoum , peng.fan@nxp.com, Alexander Stein , abailon@baylibre.com, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, abelvesa@kernel.org, marex@denx.de, Markus.Niebel@ew.tq-group.com, paul.elder@ideasonboard.com, gerg@kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, "Peng Fan (OSS)" , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, aford173@gmail.com, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org, kernel@pengutronix.de, djakov@kernel.org, l.stach@pengutronix.de, shawnguo@kernel.org, laurent.pinchart@ideasonboard.com References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org> <2678294.mvXUDI8C0e@steina-w> <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> From: Greg Ungerer In-Reply-To: <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_055831_251207_60DD474B X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyY28sCgpPbiAyOC8zLzIzIDE3OjMzLCBNYXJjbyBGZWxzY2ggd3JvdGU6Cj4gSGkgR3Jl ZywKPiAKPiBPbiAyMy0wMy0yNywgR3JlZyBVbmdlcmVyIHdyb3RlOgo+PiBIaSBBaG1hZCwKPj4K Pj4gT24gMjcvMy8yMyAxNzoxNiwgQWhtYWQgRmF0b3VtIHdyb3RlOgo+Pj4gT24gMjcuMDMuMjMg MDg6MjcsIEFsZXhhbmRlciBTdGVpbiB3cm90ZToKPj4+PiBBbSBNb250YWcsIDI3LiBNw6RyeiAy MDIzLCAwNjo1MDozNyBDRVNUIHNjaHJpZWIgR3JlZyBVbmdlcmVyOgo+Pj4+PiBBbnkgdGhvdWdo dHMgb24gd2h5IHRoaXMgYnJlYWtzIFVTQj8KPj4+Pgo+Pj4+IE1heWJlIHlvdSBhcmUgbWlzc2lu ZyBDT05GSUdfSU5URVJDT05ORUNUX0lNWDhNUD8KPj4+Cj4+PiBBbmQgaWYgdGhhdCdzIHRoZSBj YXNlLCBkaWQgeW91IGNoZWNrIC9zeXMva2VybmVsL2RlYnVnL2RldmljZXNfZGVmZXJyZWQKPj4+ IHRvIHNlZSBpZiB0aGVyZSB3YXMgYW55IGluZGljYXRpb24gdGhhdCB0aGlzIGlzIHRoZSByZWFz b24/Cj4+Cj4+IFllYWgsIGl0IGRvZXM6Cj4+Cj4+ICAgICAgIyBjYXQgL3N5cy9rZXJuZWwvZGVi dWcvZGV2aWNlc19kZWZlcnJlZAo+PiAgICAgIDMyZjEwMTAwLnVzYglwbGF0Zm9ybTogc3VwcGxp ZXIgMzJmMTAwMDAuYmxrLWN0cmwgbm90IHJlYWR5Cj4+ICAgICAgMzJmMTAxMDgudXNiCXBsYXRm b3JtOiBzdXBwbGllciAzMmYxMDAwMC5ibGstY3RybCBub3QgcmVhZHkKPj4gICAgICAzMmVjMDAw MC5ibGstY3RybAlpbXg4bS1ibGstY3RybDogZmFpbGVkIHRvIGdldCBub2MgZW50cmllcwo+PiAg ICAgIDM4MWYwMDQwLnVzYi1waHkJcGxhdGZvcm06IHN1cHBsaWVyIDMyZjEwMDAwLmJsay1jdHJs IG5vdCByZWFkeQo+PiAgICAgIDM4MmYwMDQwLnVzYi1waHkJcGxhdGZvcm06IHN1cHBsaWVyIDMy ZjEwMDAwLmJsay1jdHJsIG5vdCByZWFkeQo+PiAgICAgIGlteC1wZ2MtZG9tYWluLjExCQo+PiAg ICAgIGlteC1wZ2MtZG9tYWluLjEyCQo+PiAgICAgIGlteC1wZ2MtZG9tYWluLjEzCQo+PiAgICAg IDM4MzMwMDAwLmJsay1jdHJsCXBsYXRmb3JtOiBzdXBwbGllciBpbXgtcGdjLWRvbWFpbi4xMSBu b3QgcmVhZHkKPj4gICAgICAzMmYxMDAwMC5ibGstY3RybAlpbXg4bXAtYmxrLWN0cmw6IGZhaWxl ZCB0byBnZXQgbm9jIGVudHJpZXMKPj4KPj4gQXMgZmFyIGFzIEkgY2FuIHRlbGwgYmxrLWN0cmwg c2hvdWxkIGJlIGdvb2Q6Cj4+Cj4+ICAgICAgIwo+PiAgICAgICMgaS5NWCBTb0MgZHJpdmVycwo+ PiAgICAgICMKPj4gICAgICBDT05GSUdfSU1YX0dQQ1YyX1BNX0RPTUFJTlM9eQo+PiAgICAgIENP TkZJR19TT0NfSU1YOE09eQo+PiAgICAgICMgQ09ORklHX1NPQ19JTVg5IGlzIG5vdCBzZXQKPj4g ICAgICBDT05GSUdfSU1YOE1fQkxLX0NUUkw9eQo+PiAgICAgICMgZW5kIG9mIGkuTVggU29DIGRy aXZlcnMKPj4KPj4KPj4+IElmIHlvdSBkaWRuJ3QgZmluZCBhbnkgaGludCB0aGVyZSwgeW91IG1p Z2h0IHdhbnQgdG8gcGxhY2UgYQo+Pj4gZGV2X2Vycl9wcm9iZSB3aXRoIGEgc3VpdGFibGUgbWVz c2FnZSBhdCB0aGUgcGxhY2Ugd2hlcmUgLUVQUk9CRV9ERUZFUgo+Pj4gd2FzIHJldHVybmVkLgo+ Pgo+PiBJIHdpbGwgdHJ5IHRoYXQuCj4gCj4gQ2FuIHlvdSBjaGVjayB0aGF0IENPTkZJR19BUk1f SU1YX0JVU19ERVZGUkVRIGlzIGVuYWJsZWQ/IFRoaXMgaXMgdGhlCj4gbm9jL2ludGVyY29ubmVj dCBkcml2ZXIuIFRoaXMgY291bGQgYWxzbyB0aGUgcHJvYmxlbSBmb3IgeW91IHZwdSBpc3N1ZS4K CkkgZG8gbm90IGhhdmUgdGhhdCBlbmFibGVkLiBFbmFibGluZyB0aGF0IGZpeGVzIHRoZSBVU0Ig cHJvYmluZy4KU28gdGhhdCBpcyBnb29kLCB0aGFua3MuCgpJdCBkb2Vzbid0IGZpeCB0aGUgb3Ro ZXIgcHJvYmxlbSBJIG1lbnRpb25lZCB3aXRoIHRoZSB2cHUgcGdjIG5vZGVzIHRob3VnaC4KSSBk byBnZXQgc29tZSBleHRyYSBtZXNzYWdlcyBub3cgd2l0aCB0aGlzIGVuYWJsZWQgYW5kIHRoZSA2 LjEga2VybmVsOgoKICAgICBpbXgtcGdjIGlteC1wZ2MtZG9tYWluLjg6IGZhaWxlZCB0byBjb21t YW5kIFBHQwogICAgIGlteC1wZ2MgaW14LXBnYy1kb21haW4uODogZmFpbGVkIHRvIGNvbW1hbmQg UEdDCiAgICAgaW14OG0tYmxrLWN0cmwgMzgzMzAwMDAuYmxrLWN0cmw6IGRlZmVycmVkIHByb2Jl IHRpbWVvdXQsIGlnbm9yaW5nIGRlcGVuZGVuY3kKICAgICBpbXg4bS1ibGstY3RybCAzODMzMDAw MC5ibGstY3RybDogZXJyb3IgLTExMDogZmFpbGVkIHRvIGF0dGFjaCBwb3dlciBkb21haW4gImcx IgogICAgIGlteDhtLWJsay1jdHJsOiBwcm9iZSBvZiAzODMzMDAwMC5ibGstY3RybCBmYWlsZWQg d2l0aCBlcnJvciAtMTEwCgpSZWdhcmRzCkdyZWcKCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=