From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Wed, 29 Jun 2016 14:57:50 +0000 Subject: Re: [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751 Message-Id: <4273068.i3RgB4Ufiy@wuerfel> List-Id: References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-13-git-send-email-ysato@users.sourceforge.jp> In-Reply-To: <1467207667-15768-13-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshinori Sato Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday, June 29, 2016 10:40:57 PM CEST Yoshinori Sato wrote: > + interrupt-map = <0x0000 0 1 &cpldintc 0 0>, > + 0x0800 0 1 &cpldintc 1 0>, > + 0x1000 0 1 &cpldintc 2 0>, > + 0x1800 0 1 &cpldintc 3 0>, > + 0x1800 0 2 &cpldintc 0 0>; I just noticed the typo: you have more closing '>' than opening '<' here, so this is not valid syntax. > + > +static __refdata struct platform_driver sh7751_pci_driver = { > + .driver = { > + .name = "sh7751-pci", > + .of_match_table = sh7751_pci_of_match, > + }, > + .probe = sh7751_pci_probe, > +}; > +builtin_platform_driver(sh7751_pci_driver); I think you need to add '.suppress_bind_attrs = true' to prevent the device to be unbound and rebound through sysfs, otherwise the __init annotation on the probe function is wrong. Everything else looks fine to me now. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbcF2O4K (ORCPT ); Wed, 29 Jun 2016 10:56:10 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55900 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752445AbcF2Ozx (ORCPT ); Wed, 29 Jun 2016 10:55:53 -0400 From: Arnd Bergmann To: Yoshinori Sato Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751 Date: Wed, 29 Jun 2016 16:57:50 +0200 Message-ID: <4273068.i3RgB4Ufiy@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1467207667-15768-13-git-send-email-ysato@users.sourceforge.jp> References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-13-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BM7BlQCG5bSQ0tpWv4yJV0LFWnxXO+M9AlyF9XYkFO0MEaDoDji LT6LQOvbc/GBh6x6LIQTJMMYnqqeaBS4F2TacF/QO8kWtclhyFDNxFttzKf6rHa0qiBtZyT CeD2wMhoFU18IzXSNQrhboBL/y5yyXyzeQ9luM8paExhgd491zACEq8W9KeEben6LFFzXh2 r0Npwy1w/32U2RFYT2lxw== X-UI-Out-Filterresults: notjunk:1;V01:K0:DYxWSXf5HM0=:uzcC05S7fFLNFSZqVYU3kA 93372n8GLbxlVWTgUAboxjg0cKU2EEb4ZhyWVGkUGsY5i9W0hPIrg7LSXkZ0DgK3dWp+p3jwG xmefsvnDjhVfeQUfFt0sxZsNuc03pmE1A+Sqkb+HQJ/mMm2Lvg0fQFZzBH2Mbbs6645ajisb5 1A5NIrrZs2O7YHP4aoqCjgijoF20bNW0yaO2muzcqyKVOwFcLA51VB7CgItreEvIDPlSHyEjj etk/2HFu6r7tIQPakpRelsNWXfbU84HLN0zrHsbA6AL/rLDquplZnEMm+or+suvyCXDbgeZhS jaU2QAt4K/flzWCL37p2kWTtnSV/IciuI7qaI7+Ry39A46cCPmVV1B6u8TdkGDrthNReoeaVs UUQweyWHiNeQcin3l0ShCnKMukfecXEW2n2rTcIJVpG+Pk8uphsd9nf7TvGJAx9dcV+YcC9HY t7yNK1FwNMjSg46jo6nmnTMb0Qij+auHRNm8RHStNZA6sjmbFLPoBiyfdkpKz3NEhxHwc4//e lK8kBLzMGnVh33QD1F9ES+fg+OiNNwGKTGXBY4w832ghhShUEieRw0dJW+56XhTfkgolvHif7 eYDE6F3qPIhpu6MH11NqaWSy1hOqIYSY3ey/y8rI0FHAaBeXBrBN32o6akXFybaw4+gVqsNeY ZG2PwURcscrGwu5X8ZWyDC741+uPmZMQM3boHAIyM6lV9R8mmfoSUWUYpojVbz77C+yelK04Z vXbOd4M9+l82euad Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 29, 2016 10:40:57 PM CEST Yoshinori Sato wrote: > + interrupt-map = <0x0000 0 1 &cpldintc 0 0>, > + 0x0800 0 1 &cpldintc 1 0>, > + 0x1000 0 1 &cpldintc 2 0>, > + 0x1800 0 1 &cpldintc 3 0>, > + 0x1800 0 2 &cpldintc 0 0>; I just noticed the typo: you have more closing '>' than opening '<' here, so this is not valid syntax. > + > +static __refdata struct platform_driver sh7751_pci_driver = { > + .driver = { > + .name = "sh7751-pci", > + .of_match_table = sh7751_pci_of_match, > + }, > + .probe = sh7751_pci_probe, > +}; > +builtin_platform_driver(sh7751_pci_driver); I think you need to add '.suppress_bind_attrs = true' to prevent the device to be unbound and rebound through sysfs, otherwise the __init annotation on the probe function is wrong. Everything else looks fine to me now. Arnd