From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 7 Nov 2019 09:43:10 +0100
Subject: [U-Boot] [PATCH v5 2/4] arm: socfpga: Convert reset manager
 from struct to defines
In-Reply-To: <CAFiDJ5-eCMrJVMofHyf0WnYM-4qeD4qypmYeynAGVBE6f4b5jg@mail.gmail.com>
References: <1573092659-24385-1-git-send-email-ley.foon.tan@intel.com>
 <1573092659-24385-3-git-send-email-ley.foon.tan@intel.com>
 <5fa629f0-cf26-0b60-6f0f-594148e607b8@denx.de>
 <CAFiDJ5-2u4-_1a6HbP-vfZmLz=m0dtD99F5W2QswXx8PeS28-Q@mail.gmail.com>
 <cd0962be-8e65-4e94-ecc0-e3da373fc197@denx.de>
 <CAFiDJ5-eCMrJVMofHyf0WnYM-4qeD4qypmYeynAGVBE6f4b5jg@mail.gmail.com>
Message-ID: <427ceb7a-94bd-2a40-1855-f2d6f05ecbd0@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/7/19 9:41 AM, Ley Foon Tan wrote:
> On Thu, Nov 7, 2019 at 4:33 PM Marek Vasut wrote:
>>
>> On 11/7/19 9:06 AM, Ley Foon Tan wrote:
>>> On Thu, Nov 7, 2019 at 10:49 AM Marek Vasut wrote:
>>>>
>>>> On 11/7/19 3:10 AM, Ley Foon Tan wrote:
>>>>> Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct
>>>>> to defines.
>>>>>
>>>>> Change to get reset manager base address from DT node instead of using
>>>>> #define.
>>>>
>>>> It seems the patch also moves spl_early_init() around ?
>>> Yes, because spl_early_init() initialize DT stuff, so it needs to be
>>> called before we get base address from DT.
>>
>> That really should be documented in the commit message though.
> Okay.
>>
>> [...]
>>
>>>>> +void socfpga_get_manager_addr(void)
>>>>
>>>> You should rename this function, a lot of blocks on the Gen5 are called
>>>> <something>-manager .
>>> Okay, will change it something like socfpga_get_base_addr().
>>
>> If it's only used to retrieve the reset manager base, then it should say
>> so in the function name.
> socfpga_get_manager_addr() function will get base address for clkmgr,
> rstmgr and sysmgr, not only reset manger.

Aha, OK, then that's fine as is.

[...]