[PATCH] iio: dac: ad7303: fix channel description

[PATCH] iio: dac: ad7303: fix channel description

[plroskin]

From: Pavel Roskin <plroskin@gmail.com>

realbits, storagebits and shift should be numbers, not ASCII characters.

Signed-off-by: Pavel Roskin <plroskin@gmail.com>
---
 drivers/iio/dac/ad7303.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
index e690dd11e99f..4b0f942b8914 100644
--- a/drivers/iio/dac/ad7303.c
+++ b/drivers/iio/dac/ad7303.c
@@ -184,9 +184,9 @@ static const struct iio_chan_spec_ext_info ad7303_ext_info[] = {
 	.address = (chan),					\
 	.scan_type = {						\
 		.sign = 'u',					\
-		.realbits = '8',				\
-		.storagebits = '8',				\
-		.shift = '0',					\
+		.realbits = 8,					\
+		.storagebits = 8,				\
+		.shift = 0,					\
 	},							\
 	.ext_info = ad7303_ext_info,				\
 }
-- 
2.12.2

Re: [PATCH] iio: dac: ad7303: fix channel description

[Lars-Peter Clausen]

On 04/13/2017 11:54 PM, plroskin@gmail.com wrote:
> From: Pavel Roskin <plroskin@gmail.com>
> 
> realbits, storagebits and shift should be numbers, not ASCII characters.
> 
> Signed-off-by: Pavel Roskin <plroskin@gmail.com>

Thanks for the fix.

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

You really have to wonder how somebody would be able to get that wrong
in the first place... ;)


> ---
>  drivers/iio/dac/ad7303.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
> index e690dd11e99f..4b0f942b8914 100644
> --- a/drivers/iio/dac/ad7303.c
> +++ b/drivers/iio/dac/ad7303.c
> @@ -184,9 +184,9 @@ static const struct iio_chan_spec_ext_info ad7303_ext_info[] = {
>  	.address = (chan),					\
>  	.scan_type = {						\
>  		.sign = 'u',					\
> -		.realbits = '8',				\
> -		.storagebits = '8',				\
> -		.shift = '0',					\
> +		.realbits = 8,					\
> +		.storagebits = 8,				\
> +		.shift = 0,					\
>  	},							\
>  	.ext_info = ad7303_ext_info,				\
>  }
> 

Re: [PATCH] iio: dac: ad7303: fix channel description

[Jonathan Cameron]

On 14/04/17 09:25, Lars-Peter Clausen wrote:
> On 04/13/2017 11:54 PM, plroskin@gmail.com wrote:
>> From: Pavel Roskin <plroskin@gmail.com>
>>
>> realbits, storagebits and shift should be numbers, not ASCII characters.
>>
>> Signed-off-by: Pavel Roskin <plroskin@gmail.com>
> 
> Thanks for the fix.
> 
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> 
> You really have to wonder how somebody would be able to get that wrong
> in the first place... ;)
Applied and marked for stable. Big oops on this one.

Jonathan
> 
> 
>> ---
>>  drivers/iio/dac/ad7303.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
>> index e690dd11e99f..4b0f942b8914 100644
>> --- a/drivers/iio/dac/ad7303.c
>> +++ b/drivers/iio/dac/ad7303.c
>> @@ -184,9 +184,9 @@ static const struct iio_chan_spec_ext_info ad7303_ext_info[] = {
>>  	.address = (chan),					\
>>  	.scan_type = {						\
>>  		.sign = 'u',					\
>> -		.realbits = '8',				\
>> -		.storagebits = '8',				\
>> -		.shift = '0',					\
>> +		.realbits = 8,					\
>> +		.storagebits = 8,				\
>> +		.shift = 0,					\
>>  	},							\
>>  	.ext_info = ad7303_ext_info,				\
>>  }
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>