From: Jan Kiszka <jan.kiszka@web.de>
To: David Kiarie <davidkiarie4@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Peter Xu <peterx@redhat.com>,
alex.williamson@redhat.com,
Valentine Sinitsyn <valentine.sinitsyn@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [V12 3/4] hw/i386: Introduce AMD IOMMU
Date: Fri, 08 Jul 2016 11:51:34 +0200 [thread overview]
Message-ID: <4286A8EE-7FA5-4E0A-8C60-55EF4DE7830A@web.de> (raw)
In-Reply-To: <CABdVeABLWxmTRGw1c+OYnuiwB6rUGQLMfPhi=Vq-dBLaO_TD4w@mail.gmail.com>
Yes, this is what i meant.
Am 8. Juli 2016 09:01:59 MESZ, schrieb David Kiarie <davidkiarie4@gmail.com>:
>On Mon, Jul 4, 2016 at 8:41 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
>> On 2016-07-04 07:06, David Kiarie wrote:
>>> On Wed, Jun 22, 2016 at 11:24 PM, Jan Kiszka <jan.kiszka@web.de>
>wrote:
>>>> On 2016-06-15 14:21, David Kiarie wrote:
>>>>> +
>>>>> +
>>>>> +/* PCI SIG constants */
>>>>> +#define PCI_BUS_MAX 256
>>>>> +#define PCI_SLOT_MAX 32
>>>>> +#define PCI_FUNC_MAX 8
>>>>> +#define PCI_DEVFN_MAX 256
>>>>
>>>> Shouldn't those four go to the pci header?
>>>
>>> The macros/defines in PCI header are picked from linux while some of
>>> these are not picked from linux. I'v prefixed them with AMDVI_
>though.
>>
>> They are not AMDVI-specific, rather PCI-generic.
>
>Am I getting you right here, the above should go into PCI header, right
>?
>
>>
>> Jan
>>
>>
--
Sent from an Android - sorry, just in case...
next prev parent reply other threads:[~2016-07-08 9:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 12:21 [Qemu-devel] [V12 0/4] AMD IOMMU David Kiarie
2016-06-15 12:21 ` [Qemu-devel] [V12 1/4] hw/pci: Prepare for " David Kiarie
2016-06-22 19:53 ` Jan Kiszka
2016-06-15 12:21 ` [Qemu-devel] [V12 2/4] trace-events: Add AMD IOMMU trace events David Kiarie
2016-06-15 12:21 ` [Qemu-devel] [V12 3/4] hw/i386: Introduce AMD IOMMU David Kiarie
2016-06-22 20:24 ` Jan Kiszka
2016-07-04 5:06 ` David Kiarie
2016-07-04 5:41 ` Jan Kiszka
2016-07-04 5:49 ` David Kiarie
2016-07-04 5:57 ` Jan Kiszka
2016-07-08 7:01 ` David Kiarie
2016-07-08 9:51 ` Jan Kiszka [this message]
2016-06-15 13:15 ` [Qemu-devel] [V12 0/4] " Jan Kiszka
2016-06-15 14:26 ` Eduardo Habkost
2016-06-15 17:07 ` David Kiarie
2016-06-15 17:13 ` Jan Kiszka
[not found] ` <1465993312-18119-5-git-send-email-davidkiarie4@gmail.com>
2016-06-22 20:25 ` [Qemu-devel] [V12 4/4] hw/i386: AMD IOMMU IVRS table Jan Kiszka
2016-07-04 20:33 ` Michael S. Tsirkin
2016-07-08 7:05 ` David Kiarie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4286A8EE-7FA5-4E0A-8C60-55EF4DE7830A@web.de \
--to=jan.kiszka@web.de \
--cc=alex.williamson@redhat.com \
--cc=davidkiarie4@gmail.com \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=valentine.sinitsyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.