From: Saeed Mahameed <saeedm@mellanox.com>
To: Paul Blakey <paulb@mellanox.com>,
"marcelo.leitner@gmail.com" <marcelo.leitner@gmail.com>
Cc: Jiri Pirko <jiri@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Roi Dayan <roid@mellanox.com>, Oz Shlomo <ozsh@mellanox.com>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
Vlad Buslov <vladbu@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net-next ct-offload v2 06/13] net/mlx5: E-Switch, Introduce global tables
Date: Tue, 10 Mar 2020 01:54:47 +0000 [thread overview]
Message-ID: <428981006305a063a196e8b51ab2161b1b1d897c.camel@mellanox.com> (raw)
In-Reply-To: <20200309224013.GK2546@localhost.localdomain>
On Mon, 2020-03-09 at 19:40 -0300, Marcelo Ricardo Leitner wrote:
> On Sun, Mar 08, 2020 at 04:10:55PM +0200, Paul Blakey wrote:
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> > @@ -149,7 +149,12 @@ struct mlx5_flow_handle *
> > if (flow_act.action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST) {
> > struct mlx5_flow_table *ft;
> >
> > - if (attr->flags & MLX5_ESW_ATTR_FLAG_SLOW_PATH) {
> > + if (attr->dest_ft) {
> > + flow_act.flags |= FLOW_ACT_IGNORE_FLOW_LEVEL;
> > + dest[i].type =
> > MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
> > + dest[i].ft = attr->dest_ft;
> > + i++;
> > + } else if (attr->flags & MLX5_ESW_ATTR_FLAG_SLOW_PATH)
> > {
> > flow_act.flags |= FLOW_ACT_IGNORE_FLOW_LEVEL;
> > dest[i].type =
> > MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
> > dest[i].ft =
> > mlx5_esw_chains_get_tc_end_ft(esw);
> > @@ -202,8 +207,11 @@ struct mlx5_flow_handle *
> > if (flow_act.action & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR)
> > flow_act.modify_hdr = attr->modify_hdr;
> >
> > - fdb = mlx5_esw_chains_get_table(esw, attr->chain, attr->prio,
> > - !!split);
> > + if (attr->chain || attr->prio)
> > + fdb = mlx5_esw_chains_get_table(esw, attr->chain, attr-
> > >prio,
> > + !!split);
> > + else
> > + fdb = attr->fdb;
>
> I'm not sure how these/mlx5 patches are supposed to propagate to
> net-next, but AFAICT here it conflicts with
> 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> mirroring")
>
Paul, as we agreed, this should have been rebased on top
latest net-next + ct-offloads from
git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
Pleas rebase V3 and once the review is done on this series, i will ask
Dave to pull
ct-offloads from
git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
which was already reviewed and acked on netdev mailing list.
Thanks,
Saeed.
next prev parent reply other threads:[~2020-03-10 1:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 14:10 [PATCH net-next ct-offload v2 00/13] Introduce connection tracking offload Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 01/13] netfilter: flowtable: Add API for registering to flow table events Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 02/13] net/sched: act_ct: Instantiate flow table entry actions Paul Blakey
2020-03-09 17:36 ` Edward Cree
2020-03-10 7:52 ` Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 03/13] net/sched: act_ct: Support restoring conntrack info on skbs Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 04/13] net/sched: act_ct: Support refreshing the flow table entries Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 05/13] net/sched: act_ct: Enable hardware offload of flow table entires Paul Blakey
2020-03-09 21:25 ` Edward Cree
2020-03-09 22:19 ` Marcelo Ricardo Leitner
2020-03-09 22:40 ` Edward Cree
2020-03-10 7:53 ` Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 06/13] net/mlx5: E-Switch, Introduce global tables Paul Blakey
2020-03-09 22:40 ` Marcelo Ricardo Leitner
2020-03-10 1:54 ` Saeed Mahameed [this message]
2020-03-10 7:54 ` Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 07/13] net/mlx5: E-Switch, Add support for offloading rules with no in_port Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 08/13] net/mlx5: E-Switch, Support getting chain mapping Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 09/13] flow_offload: Add flow_match_ct to get rule ct match Paul Blakey
2020-03-08 14:10 ` [PATCH net-next ct-offload v2 10/13] net/mlx5e: CT: Introduce connection tracking Paul Blakey
2020-03-08 14:11 ` [PATCH net-next ct-offload v2 11/13] net/mlx5e: CT: Offload established flows Paul Blakey
2020-03-08 14:11 ` [PATCH net-next ct-offload v2 12/13] net/mlx5e: CT: Handle misses after executing CT action Paul Blakey
2020-03-08 14:11 ` [PATCH net-next ct-offload v2 13/13] net/mlx5e: CT: Support clear action Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428981006305a063a196e8b51ab2161b1b1d897c.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.