From mboxrd@z Thu Jan 1 00:00:00 1970 From: Davide Caratti Subject: Re: [PATCH net] net/sched: act_simple: fix parsing of TCA_DEFDATA Date: Fri, 08 Jun 2018 05:00:16 +0200 Message-ID: <428e088d2b55312ebf195a4f5794d3450f09828c.camel@redhat.com> References: <20180608020754.GT8958@leo.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net To: Hangbin Liu Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752285AbeFHDAT (ORCPT ); Thu, 7 Jun 2018 23:00:19 -0400 In-Reply-To: <20180608020754.GT8958@leo.usersys.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2018-06-08 at 10:07 +0800, Hangbin Liu wrote: > On Thu, Jun 07, 2018 at 03:46:43PM +0200, Davide Caratti wrote: > > use nla_strlcpy() to avoid copying data beyond the length of TCA_DEFDATA > > s/TCA_DEFDATA/TCA_DEF_DATA/, incase someone search the commit history but > could not find it. > > Thanks > Hangbin sure, thanks, and after another look I think also the 'Fixes:' tag is wrong. More probably it was introduced with fa1b1cff3d06 "net_cls_act: Make act_simple use of netlink policy." I will send a v2 in minutes. regards, -- davide