From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tjSXx3kkZzDwNb for ; Tue, 20 Dec 2016 17:28:49 +1100 (AEDT) Received: by mail-pg0-x241.google.com with SMTP id g1so8975690pgn.0 for ; Mon, 19 Dec 2016 22:28:49 -0800 (PST) Subject: Re: [PATCH v3 3/5] powerpc/mm: add radix__create_section_mapping() To: Reza Arbab , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras References: <1481831443-22761-1-git-send-email-arbab@linux.vnet.ibm.com> <1481831443-22761-4-git-send-email-arbab@linux.vnet.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org, "Aneesh Kumar K.V" , Alistair Popple From: Balbir Singh Message-ID: <42967170-8b23-4682-ea44-4df0b1b205fd@gmail.com> Date: Tue, 20 Dec 2016 17:28:40 +1100 MIME-Version: 1.0 In-Reply-To: <1481831443-22761-4-git-send-email-arbab@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > > +#ifdef CONFIG_MEMORY_HOTPLUG > +int radix__create_section_mapping(unsigned long start, unsigned long end) > +{ > + unsigned long page_size = 1 << mmu_psize_defs[mmu_linear_psize].shift; Can we refactor bits from radix_init_pgtable() and reuse? Balbir