From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824Ab1KEXr0 (ORCPT ); Sat, 5 Nov 2011 19:47:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53896 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762Ab1KEXrZ convert rfc822-to-8bit (ORCPT ); Sat, 5 Nov 2011 19:47:25 -0400 Subject: Re: [PATCH] KVM: Add wrapper script around Qemu to test kernels Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=iso-8859-1 From: Alexander Graf In-Reply-To: Date: Sat, 5 Nov 2011 16:47:15 -0700 Cc: Pekka Enberg , Linus Torvalds , Ingo Molnar , Avi Kivity , "linux-kernel@vger.kernel.org List" , "kvm@vger.kernel.org list" , qemu-devel Developers , Steven Rostedt Content-Transfer-Encoding: 8BIT Message-Id: <42BCCB0A-6ECA-48EE-9C07-B57D0A5DD4AD@suse.de> References: <1314137806-5747-1-git-send-email-agraf@suse.de> <282DEC42-93F6-411E-97C5-C49D258718C2@suse.de> To: =?iso-8859-1?Q?Am=E9rico_Wang?= X-Mailer: Apple Mail (2.1084) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.08.2011, at 20:44, Américo Wang wrote: > On Thu, Aug 25, 2011 at 4:35 AM, Alexander Graf wrote: >> >> On 24.08.2011, at 00:31, Américo Wang wrote: >> >>> On Wed, Aug 24, 2011 at 1:19 PM, Pekka Enberg wrote: >>>> >>>> It's nice to see such an honest attempt at improving QEMU usability, Alexander! >>>> >>>> One comment: in my experience, having shell scripts under >>>> Documentation reduces the likelihood that people actually discover >>>> them so you might want to consider putting it under scripts or tools. >>>> >>> >>> I was going to give the same suggestion, +1 for tools/ directory. >> >> Well, scripts/ is a flat directory where I can just throw in the script. Tools however is split by tool and creating a full new directory for only a single script sounds a bit like overkill to me. I'll move it to scripts/ for now :) > > How about the directory tools/testing/ ? > > scripts/ is mainly for the tools/utilities we use to build kernel or > do kernel dev, > it is not so suitable for your script IMHO. Good idea! I talked to Steven about it as well and completely forgot your email pointing me to the same directory. I guess that one does fit it pretty well. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] KVM: Add wrapper script around Qemu to test kernels Date: Sat, 5 Nov 2011 16:47:15 -0700 Message-ID: <42BCCB0A-6ECA-48EE-9C07-B57D0A5DD4AD@suse.de> References: <1314137806-5747-1-git-send-email-agraf@suse.de> <282DEC42-93F6-411E-97C5-C49D258718C2@suse.de> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "kvm@vger.kernel.org list" , "linux-kernel@vger.kernel.org List" , Steven Rostedt , qemu-devel Developers , Pekka Enberg , Avi Kivity , Ingo Molnar , Linus Torvalds To: =?iso-8859-1?Q?Am=E9rico_Wang?= Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 24.08.2011, at 20:44, Am=E9rico Wang wrote: > On Thu, Aug 25, 2011 at 4:35 AM, Alexander Graf wrote: >>=20 >> On 24.08.2011, at 00:31, Am=E9rico Wang wrote: >>=20 >>> On Wed, Aug 24, 2011 at 1:19 PM, Pekka Enberg = wrote: >>>>=20 >>>> It's nice to see such an honest attempt at improving QEMU = usability, Alexander! >>>>=20 >>>> One comment: in my experience, having shell scripts under >>>> Documentation reduces the likelihood that people actually discover >>>> them so you might want to consider putting it under scripts or = tools. >>>>=20 >>>=20 >>> I was going to give the same suggestion, +1 for tools/ directory. >>=20 >> Well, scripts/ is a flat directory where I can just throw in the = script. Tools however is split by tool and creating a full new directory = for only a single script sounds a bit like overkill to me. I'll move it = to scripts/ for now :) >=20 > How about the directory tools/testing/ ? >=20 > scripts/ is mainly for the tools/utilities we use to build kernel or > do kernel dev, > it is not so suitable for your script IMHO. Good idea! I talked to Steven about it as well and completely forgot = your email pointing me to the same directory. I guess that one does fit = it pretty well. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMpxT-0005c3-C3 for qemu-devel@nongnu.org; Sat, 05 Nov 2011 19:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RMpxO-0005ua-PT for qemu-devel@nongnu.org; Sat, 05 Nov 2011 19:47:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53893 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMpxO-0005uK-Kf for qemu-devel@nongnu.org; Sat, 05 Nov 2011 19:47:26 -0400 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=iso-8859-1 From: Alexander Graf In-Reply-To: Date: Sat, 5 Nov 2011 16:47:15 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <42BCCB0A-6ECA-48EE-9C07-B57D0A5DD4AD@suse.de> References: <1314137806-5747-1-git-send-email-agraf@suse.de> <282DEC42-93F6-411E-97C5-C49D258718C2@suse.de> Subject: Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Am=E9rico_Wang?= Cc: "kvm@vger.kernel.org list" , "linux-kernel@vger.kernel.org List" , Steven Rostedt , qemu-devel Developers , Pekka Enberg , Avi Kivity , Ingo Molnar , Linus Torvalds On 24.08.2011, at 20:44, Am=E9rico Wang wrote: > On Thu, Aug 25, 2011 at 4:35 AM, Alexander Graf wrote: >>=20 >> On 24.08.2011, at 00:31, Am=E9rico Wang wrote: >>=20 >>> On Wed, Aug 24, 2011 at 1:19 PM, Pekka Enberg = wrote: >>>>=20 >>>> It's nice to see such an honest attempt at improving QEMU = usability, Alexander! >>>>=20 >>>> One comment: in my experience, having shell scripts under >>>> Documentation reduces the likelihood that people actually discover >>>> them so you might want to consider putting it under scripts or = tools. >>>>=20 >>>=20 >>> I was going to give the same suggestion, +1 for tools/ directory. >>=20 >> Well, scripts/ is a flat directory where I can just throw in the = script. Tools however is split by tool and creating a full new directory = for only a single script sounds a bit like overkill to me. I'll move it = to scripts/ for now :) >=20 > How about the directory tools/testing/ ? >=20 > scripts/ is mainly for the tools/utilities we use to build kernel or > do kernel dev, > it is not so suitable for your script IMHO. Good idea! I talked to Steven about it as well and completely forgot = your email pointing me to the same directory. I guess that one does fit = it pretty well. Alex