[PATCH 00/12] mm/debug_vm_pgtable: Enhancements

* [PATCH 00/12] mm/debug_vm_pgtable: Enhancements
@ 2021-07-06  6:17 Gavin Shan
  2021-07-06  6:17 ` [PATCH 01/12] mm/debug_vm_pgtable: Introduce struct vm_pgtable_debug Gavin Shan
                   ` (12 more replies)
  0 siblings, 13 replies; 23+ messages in thread
From: Gavin Shan @ 2021-07-06  6:17 UTC (permalink / raw)
  To: linux-mm
  Cc: linux-kernel, anshuman.khandual, catalin.marinas, will, akpm,
	shan.gavin, chuhu

There are couple of issues with current implementations and this series
tries to resolve the issues:

  (a) All needed information are scattered in variables, passed to various
      test functions. The code is organized in pretty much relaxed fashion.

  (b) The page isn't allocated from buddy during page table entry modifying
      tests. The page can be invalid, conflicting to the implementations
      of set_{pud, pmd, pte}_at() on ARM64. The target page is accessed
      so that the iCache can be flushed when execution permission is given
      on ARM64. Besides, the target page can be unmapped and access to
      it causes kernel crash.

"struct vm_pgtable_debug" is introduced to address issue (a). For issue
(b), the used page is allocated from buddy in page table entry modifying
tests. The corresponding tets will be skipped if we fail to allocate the
(huge) page. For other test cases, the original page around to kernel
symbol (@start_kernel) is still used.

The patches are organized as below. PATCH[2-10] could be combined to one
patch, but it will make the review harder:

  PATCH[1] introduces "struct vm_pgtable_debug" as place holder of all
           needed information. With it, the old and new implementation
           can coexist.
  PATCH[2-10] uses "struct vm_pgtable_debug" in various test functions.
  PATCH[11] removes the old implementation.
  PATCH[12] fixes the issue of corrupted page flag for ARM64

Gavin Shan (12):
  mm/debug_vm_pgtable: Introduce struct vm_pgtable_debug
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in basic tests
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in leaf and savewrite
    tests
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in protnone and
    devmap tests
  mm/vm_debug_pgtable: Use struct vm_pgtable_debug in soft_dirty and
    swap tests
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in migration and thp
    tests
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in PTE modifying
    tests
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in PMD modifying
    tests
  mm/vm_debug_pgtable: Use struct vm_pgtable_debug in PUD modifying
    tests
  mm/debug_vm_pgtable: Use struct vm_pgtable_debug in PGD and P4D
    modifying tests
  mm/debug_vm_pgtable: Remove unused code
  mm/debug_vm_pgtable: Fix corrupted page flag

 mm/debug_vm_pgtable.c | 875 ++++++++++++++++++++++++------------------
 1 file changed, 500 insertions(+), 375 deletions(-)

-- 
2.23.0

^ permalink raw reply	[flat|nested] 23+ messages in thread