From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A29C433F5 for ; Thu, 3 Mar 2022 16:16:30 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFC7F4276B; Thu, 3 Mar 2022 17:16:29 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E12CE40687 for ; Thu, 3 Mar 2022 17:16:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646324188; x=1677860188; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=l6SYYv+xJykV3bPlYGGhs/wTAwTVSEhaEcdjByqKapc=; b=NWns83z7RbBc7KhkupLEel+GgZPFSlj6QVuPQl0J2ej+6JI7cCdZJFBR 4HGB0O8uO6rfoGEiym0soiFy0Ca/asN9iGbcA6wv4reBN0STCL6YzgNKF bWPZuUrV1FIX4VAExjYBZcil2dKFSGOb6SNKOH0pRbfw9C5YLNhb4subo 0mO7H126mE2hSgLkSzYRjUsM9sQkyf/FXuvNQ7p/hC/wMr36KViz9DWTC 7d6PkD+/vW4n5t9YUs52Ruz+XKmg8OIYC+KUba7EmlW8tUW4OqMLCnww3 0KGHghJyw6cHOUuyAweRwSJVGuzqdK2B4ewlbgUHZX6HIScUxUCLegdGY w==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="340147293" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="340147293" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 08:14:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="594440120" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 03 Mar 2022 08:14:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 08:14:33 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 08:14:32 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 3 Mar 2022 08:14:32 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 3 Mar 2022 08:14:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THj/OCGIIfLAAtpssbwV8S0iRR6A3b8QGFfm+OC3NhWzEbVgUFUh8M9UI1P9u6n6G8BmQXBz2vvE9vm9L3LuldSDqVz9QRavnnLpyp/WwHNQh6P8ZumEla7rWtyv5+Gp4r+lUOKzmykih6OK7+Ad2GtLoi07rgObbRTA/yGEbhBCEMY4cLLMoX2lUfki6izEgtg5xuvRbWMn+pWe1Rmln573b3EXPKNdZkqF0GbV2vJdIemngF5zOCJD4tQodeyPh08RDikH5W1L2bDiv+M4uiKJRUaYBOLTw9aNmg8ZCpohOGpBE3uuE62ZcLt6DV5ewb6IX8bEUTkv6yMa1wsaDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1elRp/ZssDAxyvEWcgvq+Qo6p75KF1onb+N7UlvYyGQ=; b=VRS+XOf1UoxqVrGFFOAl6GKh5Raq51y6OHK6SmiPz9jseeQRAS0HoxLBZBRvyQB9Eom0crUn6VV0WtddUKY4L1vjaJHqz8u4e+cx2hyMY920Mr+wqRh28h+kn1Vifo7klmHmuvZGE9cPUQ8gvSDmw3jKfY/pTC/aoCUU+YMz36HbCuoB925FDG20m7njH0zbkYPF+PVXb7efXwhOAD2FE8JW4+zBSWnM15hAt89t2oexh8laM6f1a9cOrpUvoYQdlKoXx6c6MAABluaRyBe/Tp59h3pPuPApa2kgGua17tJrZ64nw0FS6NCsHCxK+T+Z4Wnw86m1pxYLX5xkjAN0Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL1PR11MB6003.namprd11.prod.outlook.com (2603:10b6:208:387::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Thu, 3 Mar 2022 16:14:30 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 16:14:30 +0000 Message-ID: <42a71aed-610f-8f32-508d-b474662490d2@intel.com> Date: Thu, 3 Mar 2022 16:14:24 +0000 Content-Language: en-US To: Raslan Darawsheh , Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko References: <20220227075753.3466574-1-michaelba@nvidia.com> <20220301110935.3958252-1-michaelba@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH v2] common/mlx5: fix missing default devargs initialization X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0355.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 556e6cf9-9fbe-48ba-d6a1-08d9fd30e5b6 X-MS-TrafficTypeDiagnostic: BL1PR11MB6003:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vKIqL4mb+fVjW9NbSrNlP4COw/ludoX+Abz+8AlE29GzQRVrlCwItrN/Mp7bjWWpFzjCiPtrG99GRsmcTlnSFvAJNt7fksSUp5l/PiU7mxdaq6KY5qR3LHqImWHgoBxDLfoyNYJGQGRw/PhfMn98fu8ucrzHC12Qe6WxnQkJibAI62tKWMpJpQ1NBrO20o+b5il6vBopv+lfGiNxWBjUBdoNpKW+0hKFVEeZnnTHJK88yVPtAHd64soyajNuMRH2MNpgPFRfio90v5pDeUnerPIluDmjDjTZuTBO4HCJaoTShI4hDCsBgR37Hf76ZzMYLHdWkPeHIOYe9rY3mWgyl7v+mD9JZROqZ1mWcFEKzdXvNcDNJoT1TCQyQ8Wnzb8hhgITq3vQ4p1VHCT2CQOQffqLGgj9laR8W1kHupwEBb9kBgb+FraY6NHc/tL+1hhxWYCqCmfLiAd9FQhIY4UM0cUAECVTRiIGn7R61vAWvxAuZwgPWYBjXg5CibA7JltXv0I6UYwgPFED5nxXuhg9hGBvCDbifFnYqyXZuHUawAF46KW0kTxnqCKROj7jMdXwRrA6p+YrwT30SctsDvWRtLx8wZKS4uNeh+xVqdC1UvZHjFxc/5tgX8Is/AZlXRm2BSZ0CkhjqaGI4wMuiny9Rr+VT2Wt4InnmSgdkR9U8CTSPtVsmPUxpYkpkEn8b91P3x0Np+0TWsRdUML6/lZ5ydW6nS6bVB5iPC/FO4Z3oAYJisqbsSkFpOnW8e3BY375Gigh8gQG03Xoz9ncSEkIGeCjuRN/VEnTJS9rqEjrcBQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(8936002)(53546011)(66946007)(66476007)(66556008)(4326008)(8676002)(6666004)(86362001)(31696002)(83380400001)(186003)(26005)(2616005)(5660300002)(2906002)(6512007)(44832011)(110136005)(508600001)(6486002)(31686004)(82960400001)(966005)(38100700002)(36756003)(54906003)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGhsa28rTHNyOHBCaWdRUFRNbElSSmJ2RDR1bEFLTlA1cG1id3JlRURrQ21C?= =?utf-8?B?NGFHd25uTktCeGZNTDdIRmtpTzRCaXFERjNFVlJBL3BTMmR4ZzU4SFdHemxk?= =?utf-8?B?bmZXRmw1RVlXS0h6U3lNbVljY2JscStyVHNBTHI2TlUvbkdWZktLNjF1Z1Yx?= =?utf-8?B?d3lhaVZRYTd3RVlBRDR1SDh2ZUVhOVJ1cjBMdGFDbkhhQXlNZVU0ZmovVCt4?= =?utf-8?B?Y1IwdkpOa1FlOXJwNWJQN3J6MzNGakJYNFMwVVhUYldWNkRadndYMDE1ak8v?= =?utf-8?B?TldFL2preXp3MlhYR0VRVXNTTlAzK1U0aDZSK1haOGFHQnJvMEd0SUsxNVR6?= =?utf-8?B?d0JlUy9XajF6UGZOeDlkcUVicWk2Ry9sQThWdU1QU0Jici9hNWRGODdaaG85?= =?utf-8?B?MlJZdnFaL3REeTBRQ3lnbStyZlFZM1RXbS95aFdGRngrak4yN2Jpb3Urdzda?= =?utf-8?B?aFc0TWhkejFVdkJNTzRwNXlyTkRUZDdlL2t2SE5aRUtzQlp3MWY5SDBjM3BS?= =?utf-8?B?UUNiSnNlYnZyS3BPUTlnN0c0Z3dsZEEwYzJuQlc5M1REVmVvZTEyL2RWeVNW?= =?utf-8?B?dlBzK1dTbVJtb3VNMy9nbFVCR1l6dTRFRXhWY01EbFVxV2JwWk5id3NlY0pj?= =?utf-8?B?WDlKSGxTNDZ3dTYwWWRGOGRzdHhBZ2Jac285VHNraktUQWNreEU4aEZGMC9S?= =?utf-8?B?aDU4MVhEZzVkZmVOMGFGSFdsbVB5UG5adGNUUUp2b0NSbDEyaVNRMWViaHhy?= =?utf-8?B?VllDUGlXOGNqckZZRVVCcFNHYkE5cFltWkRUcURRU2kxalZEOUpNWVRWVnEr?= =?utf-8?B?VVp5Yjk4QXJmNzRnSHVZNERta0M5b3EzbkZpSUZGZHlEZVg3dG02T1h1bE5O?= =?utf-8?B?RHNNOEVQK0ZoSUxYYTR0Z1ZZVHROMTVxbUpiS0RiMmNGNzhjTFhqb0d3K1A1?= =?utf-8?B?dXdZUFk3Q2tZdUExeGJxSzBDWG9mZlNtRUxaTjIyWlNYOVppQnB1Y1pZMFpr?= =?utf-8?B?VERBMWJNUVNTeWNPRWpDWHNMOFozRkEvOHprbGVvSGZlZFhYM1FwNmFHTHFs?= =?utf-8?B?dGVnUjRURnp0YnQ1OEprT0FXZk1naXJGTUJKU0Jlajkxcy84dEtnVnVRT0Mv?= =?utf-8?B?L0JQbTM1VTM5S2dldDhHZDRXaHA2RmZkb0JtdTFlZW5UM0pzVUNNUTJ6RDd6?= =?utf-8?B?WGVVKzVKVy9GVXVlYm1BZDVqSUpOUzF5YU5DSy9iRElLeDM4SHhLTTBFenJy?= =?utf-8?B?bDdiWHo5WldDTHhRc0w5NkdJL0sydGhNK0VvcVRMQ3RwTis4RVR6ZUVvTm5T?= =?utf-8?B?UkFSL1VNbnRrU0h6SFhXYjB5VmR2MG5hQ1RHcDJFbFlQS0ZyZmthZVdPRXRW?= =?utf-8?B?REVzL0xBa1hlWmU2bysvL1Y1TzlVZVhTNVlEZWNaSXMyUytjYkMxRzFsSWJ4?= =?utf-8?B?V0M3QlQwUGsrbEFvUnIyTzBOU3BCZGtPZzVxdnVQbFRoRkJZNkYrck1jai93?= =?utf-8?B?RkcwdHZHMTZNUjY5UzIxbXhtakRGNENYZEFuK0lCcm9HWG9JSXpOYXpDVHhN?= =?utf-8?B?UzIyTkhwWTdoWHVKTnltNS9TTEFlNUVZUXZiVU5ZSDllWnhEYVl5aVpWQjBJ?= =?utf-8?B?YmYwTkRoSCsrN0EwNTlpNE54SXhZeWZXV1hRY2daREhzdElsd3FWUjdOSTYr?= =?utf-8?B?SlFoT05RSE50OHN1c2R3bXdybjF1a3FtRjlOdEZTcGlxT1JIZ0x4dW4xRVkr?= =?utf-8?B?bytBazYyTkJSZDl1R09kSldUOHI0WVhqMCtHQWxibjJVa3BjdHNJc0ZtYVpt?= =?utf-8?B?ZDlQRyswckVSQ0JvcVJaLzI2c2V3RDVob0UzYUlDM3RzcEdjMlpSWU5VbE1r?= =?utf-8?B?UkU5OUxsQVFUVk5nWVFsWEhvSHJkZk9SbUZoOFl4V0s5VW1PNi82amZwSzdr?= =?utf-8?B?YTBrQi80bHp1Z2pBNlNYR2VoQ1BkTEhHVkZiRjZobFozVnRvK1lOWkhQTWtw?= =?utf-8?B?V2svSGdqK3RudFV5emZnTTl2aGVhNGNOQ3krSUhCNjlNQVFIZUlrOUhVNjZZ?= =?utf-8?B?dWpEUEVQemJ6dC9QSXh4WmU2ZXBqSnh2elVDV0gxMDJBcTU1cGdtZzJPUmhi?= =?utf-8?B?dFV6c0JaMGpUVGFGYWhNTVJLYkZObjlEd3lTS0ltVW13K3M2d24vUVgwM1dH?= =?utf-8?Q?k83GNUAR2hRwQrFd+7bfTOo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 556e6cf9-9fbe-48ba-d6a1-08d9fd30e5b6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 16:14:30.6357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CyyW8/+OGxJ0ZifWYH5PnACxu0zsUJgqCt0zgdY9ud5wOcfcOUEAMQQvCe3B9Uzv6s5eWQTV3MC6PmcQ0szn/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6003 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/2022 4:33 PM, Raslan Darawsheh wrote: > Hi, > >> -----Original Message----- >> From: Michael Baum >> Sent: Tuesday, March 1, 2022 1:10 PM >> To: dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Slava Ovsiienko >> Subject: [PATCH v2] common/mlx5: fix missing default devargs initialization >> >> Device arguments list is provided along with its identifier as part of EAL >> arguments. >> The arguments specified in the list are taken from it, and the rest is initialized >> to the default values. >> >> When no list is provided at all, all arguments should have been initialized to >> their default values. However, they are mistakenly initialized to zero which >> may be a valid value for some. >> >> This patch initializes the default values before checking whether arguments >> have been specified. >> >> Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management") > added: > Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=945 We have a defined keyword for it, and it should go before Fixes tag, like: Bugzilla ID: 945 Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management") updated accordingly in next-net >> >> Signed-off-by: Michael Baum >> Acked-by: Matan Azrad >> --- >> >> v2: updating Fixes reference hash. >> >> drivers/common/mlx5/mlx5_common.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > Patch applied to next-net-mlx, > > Kindest regards, > Raslan Darawsheh