From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
sbabic@denx.de, festevam@gmail.com
Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 5/7] imx: makefile: drop the use of imx8mimage.sh
Date: Thu, 19 Aug 2021 12:32:24 +0200 [thread overview]
Message-ID: <42ae3e5e-0195-7486-b97a-63d00a3b9a6b@kontron.de> (raw)
In-Reply-To: <20210816034847.22767-5-peng.fan@oss.nxp.com>
On 16.08.21 05:48, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> After switch to use binman, no need to use the bash script
> to check file exsiting or not. And there is bug that
> the script will be executed everytime Makefile is used which is
> confusing people.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
For my mx8mm board config using binman, this resolves the following warning:
WARNING 'mkimage.flash.mkimage' not found, resulting binary is not-functional
Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Is this save to be used with boards that haven't been converted to binman yet?
> ---
> arch/arm/mach-imx/Makefile | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index 0ef269563d..f629751c48 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -114,8 +114,7 @@ endif
> DEPFILE_EXISTS := $(shell $(CPP) $(cpp_flags) -x c -o u-boot-dtb.cfgout $(srctree)/$(IMX_CONFIG); if [ -f u-boot-dtb.cfgout ]; then $(CNTR_DEPFILES) u-boot-dtb.cfgout; echo $$?; fi)
> else ifeq ($(CONFIG_ARCH_IMX8M), y)
> IMAGE_TYPE := imx8mimage
> -IMX8M_DEPFILES := $(srctree)/tools/imx8m_image.sh
> -DEPFILE_EXISTS := $(shell $(CPP) $(cpp_flags) -x c -o spl/u-boot-spl.cfgout $(srctree)/$(IMX_CONFIG);if [ -f spl/u-boot-spl.cfgout ]; then $(IMX8M_DEPFILES) spl/u-boot-spl.cfgout 0; echo $$?; fi)
> +DEPFILE_EXISTS := 0
> else
> IMAGE_TYPE := imximage
> DEPFILE_EXISTS := 0
> @@ -150,16 +149,18 @@ endif
>
> ifdef CONFIG_ARM64
> ifeq ($(CONFIG_ARCH_IMX8M), y)
> -SPL:
> +
> +SPL: spl/u-boot-spl.bin spl/u-boot-spl.cfgout FORCE
>
> MKIMAGEFLAGS_flash.bin = -n spl/u-boot-spl.cfgout \
> -T $(IMAGE_TYPE) -e $(CONFIG_SPL_TEXT_BASE)
> flash.bin: MKIMAGEOUTPUT = flash.log
>
> +spl/u-boot-spl.cfgout: $(IMX_CONFIG) FORCE
> + $(Q)mkdir -p $(dir $@)
> + $(call if_changed_dep,cpp_cfg)
> +
> spl/u-boot-spl-ddr.bin: spl/u-boot-spl.bin spl/u-boot-spl.cfgout FORCE
> -ifeq ($(DEPFILE_EXISTS),0)
> - $(IMX8M_DEPFILES) spl/u-boot-spl.cfgout 1
> -endif
>
> flash.bin: spl/u-boot-spl-ddr.bin u-boot.itb FORCE
> $(call if_changed,mkimage)
>
next prev parent reply other threads:[~2021-08-19 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 3:48 [PATCH 1/7] tools: imx8mimage: not abort when mmap fail Peng Fan (OSS)
2021-08-16 3:48 ` [PATCH 2/7] imx: imx8mq_evk: switch to binman Peng Fan (OSS)
2021-08-16 3:48 ` [PATCH 3/7] imx: imx8mq_phanbell: " Peng Fan (OSS)
2021-08-16 3:48 ` [PATCH 4/7] imx: pico-imx8mq: switch to use binman Peng Fan (OSS)
2021-08-16 3:48 ` [PATCH 5/7] imx: makefile: drop the use of imx8mimage.sh Peng Fan (OSS)
2021-08-19 10:32 ` Frieder Schrempf [this message]
2021-08-20 13:45 ` Marcel Ziswiler
2021-10-20 12:20 ` sbabic
2021-08-16 3:48 ` [PATCH 6/7] imx: imx8mq use common imximage.cfg Peng Fan (OSS)
2021-08-16 3:48 ` [PATCH 7/7] doc: imx8mq_evk: update doc after using binman Peng Fan (OSS)
2021-10-20 12:20 ` [PATCH 1/7] tools: imx8mimage: not abort when mmap fail sbabic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ae3e5e-0195-7486-b97a-63d00a3b9a6b@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=festevam@gmail.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.