All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten <maarten@rmail.be>
To: Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>
Cc: Doug Berger <opendmb@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH] net: bcmgenet: Reset RBUF on first open
Date: Wed, 06 Mar 2024 09:03:44 +0100	[thread overview]
Message-ID: <42cc2d7ec8913a3a71e918e3f116c55e@rmail.be> (raw)
In-Reply-To: <20240305130728.5d879a7e@kernel.org>

Jakub Kicinski schreef op 2024-03-05 22:07:
> On Tue, 05 Mar 2024 21:36:03 +0100 Maarten wrote:
>> > The patch has minor formatting issues (using spaces to indent).
>> > Once you've gain sufficient confidence that it doesn't cause issues -
>> > please mend that and repost.
>> 
>> I'm sorry, it was blatantly obvious and I missed it :-( . I had added
>> indent-with-non-tab to git core.whitespace , but it seems to only 
>> error
>> when a full 8 spaces are present in indentation. By any chance, is 
>> there
>> something to test this? In the main time, I'll do a git show -p --raw 
>> |
>> hexdump -C to check this .
>> 
>> I've fixed that on my git (and fixed some similar issues in other
>> patches) and will resend.
> 
> I'd rather you waited with the resend until Doug or Florian confirms
> the change is okay. No point having the patch rot in patchwork until
> then.

Ok, hopefully it won't take too long for them to do their due diligence.

  reply	other threads:[~2024-03-06  8:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 23:53 [PATCH] net: bcmgenet: Reset RBUF on first open Maarten Vanraes
2024-02-26 17:34 ` Florian Fainelli
2024-02-26 19:14   ` Maarten
2024-02-26 23:13   ` Doug Berger
2024-02-27 12:53     ` Paolo Abeni
2024-03-05 15:13     ` Jakub Kicinski
2024-03-05 20:36       ` Maarten
2024-03-05 21:07         ` Jakub Kicinski
2024-03-06  8:03           ` Maarten [this message]
2024-03-16 11:53     ` Maarten
2024-03-19 16:56       ` Florian Fainelli
2024-03-19 21:11         ` Maarten
2024-03-19 21:50           ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42cc2d7ec8913a3a71e918e3f116c55e@rmail.be \
    --to=maarten@rmail.be \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=phil@raspberrypi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.