Re: [PATCH v2] kern/efi: Adding efi-watchdog command

[Erwan Velu <e.velu@criteo.com>]

Le 03/09/2021 à 04:09, Michael Chang a écrit :
[...]
> I'd suggest to move this efi-watchdog command registration to
> grub_register_core_commands() in grub-core/kern/corecmd.c as that helps
> us tracing or knowing available commands in grub's rescue mode.
>
> Also it would be great to see the explaination why this command needs to
> be in the core. To my understandng it could be that users may want to
> disarm the watchdog to not interrupt their work in rescue mode during a
> troubleshooting or debug session, but I am not fully clear about the
> purpose.

Hey Michael,

I'm waiting for other reviews and will add your points into a V3.


You are perfectly right on the aim.

To be efficient, the watchdog must be enabled at soon as possible and so

cannot be set into the configuration file as we are far too late and issues

could have already hit GRUB (aka unable to read the filesystem).

So, once the option is set, every-time GRUB will boots the watchdog is 
enabled.


And yes, if you need to perform a debug session, you need being in a 
position to disable it.

That's why we need this commands in the low-level command sets of grub.

I'm not very familiar with GRUB internals, so if the corecmd is a better 
place and other agree on that,

I'll make the move in V3.


Erwan,