From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDuV5-0008Lw-4U for qemu-devel@nongnu.org; Fri, 17 Jun 2016 10:12:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDuV4-0007cA-7K for qemu-devel@nongnu.org; Fri, 17 Jun 2016 10:11:59 -0400 References: <1466169069-29375-1-git-send-email-real@ispras.ru> <1466169069-29375-14-git-send-email-real@ispras.ru> From: Paolo Bonzini Message-ID: <43147d0d-6eb1-00bc-57fd-093be8bf0528@redhat.com> Date: Fri, 17 Jun 2016 16:11:44 +0200 MIME-Version: 1.0 In-Reply-To: <1466169069-29375-14-git-send-email-real@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/13] ICH9 LPC: configure PCI IRQs routing internally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Efimov Vasily , qemu-devel@nongnu.org Cc: John Snow , qemu-block@nongnu.org, Gerd Hoffmann , "Michael S. Tsirkin" , Kevin Wolf , Max Reitz , Richard Henderson , Eduardo Habkost , Peter Maydell , Kirill Batuzov On 17/06/2016 15:11, Efimov Vasily wrote: > ICH9 LPC bridge is used to route PCI IRQs to GSI. The root PCI bus reference is > required to setup the routing. According to specification, the bridge is > connected to root bus. Hence, there is no reason to setup the routing externally. > > The patch moves the setup code to 'realize' method. Also several related > functions are made static because they are no needed outside the bridge > implementation any more. > > Signed-off-by: Efimov Vasily I'm not sure of this patch, but anyway it's the last so it's not a big deal. Very nice overall! Paolo