From: Randy Dunlap <rdunlap@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Kees Cook <keescook@chromium.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bart Van Assche <bart.vanassche@wdc.com>
Subject: Re: linux-next: Tree for Mar 13
Date: Tue, 13 Mar 2018 10:30:59 -0700 [thread overview]
Message-ID: <431d701a-1ac2-6f95-aa49-bab1d921072b@infradead.org> (raw)
In-Reply-To: <CAMM=eLdZ6adSV6Q0JLkRi9k=7g5o4SEAyGfOm0P_nqw71Jbing@mail.gmail.com>
On 03/13/2018 08:57 AM, Mike Snitzer wrote:
> I had to revert the following commits to get this kernel to build
> (otherwise I got macro expansion errors, using RHEL7
> gcc-4.8.5-28.el7.x86_64):
>
> beb7eb2 kernelh-skip-single-eval-logic-on-literals-in-min-max-v3
> 19ff7e5 kernelh-skip-single-eval-logic-on-literals-in-min-max-v2
> c7c133f kernel.h: skip single-eval logic on literals in min()/max()
>
> (it wasn't until I reverted commit c7c133f that the kernel build worked)
Yep, all of my automated randconfig builds were useless...
> Here is a snippet of the errors if commit c7c133f was applied:
>
> [root@rhel-storage-02 linux]# make
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> CC kernel/bounds.s
> CHK include/generated/bounds.h
> CHK include/generated/timeconst.h
> CC arch/x86/kernel/asm-offsets.s
> In file included from ./include/linux/crypto.h:21:0,
> from arch/x86/kernel/asm-offsets.c:9:
> ./include/linux/jiffies.h: In function ‘jiffies_delta_to_clock_t’:
> ./include/linux/kernel.h:856:2: error: first argument to
> ‘__builtin_choose_expr’ not a constant
> __builtin_choose_expr(__builtin_constant_p(x) && \
> ^
> ./include/linux/kernel.h:869:19: note: in expansion of macro ‘__max’
> #define max(x, y) __max(typeof(x), typeof(y), x, y)
> ^
> ./include/linux/jiffies.h:444:28: note: in expansion of macro ‘max’
> return jiffies_to_clock_t(max(0L, delta));
> ^
> ./include/linux/mm.h: In function ‘get_mm_hiwater_rss’:
> ./include/linux/kernel.h:856:2: error: first argument to
> ‘__builtin_choose_expr’ not a constant
> __builtin_choose_expr(__builtin_constant_p(x) && \
> ^
> ./include/linux/kernel.h:869:19: note: in expansion of macro ‘__max’
> #define max(x, y) __max(typeof(x), typeof(y), x, y)
> ^
> ./include/linux/mm.h:1569:9: note: in expansion of macro ‘max’
> return max(mm->hiwater_rss, get_mm_rss(mm));
> ^
> ./include/linux/mm.h: In function ‘get_mm_hiwater_vm’:
> ./include/linux/kernel.h:856:2: error: first argument to
> ‘__builtin_choose_expr’ not a constant
> __builtin_choose_expr(__builtin_constant_p(x) && \
> ^
> ./include/linux/kernel.h:869:19: note: in expansion of macro ‘__max’
> #define max(x, y) __max(typeof(x), typeof(y), x, y)
> ^
> ./include/linux/mm.h:1574:9: note: in expansion of macro ‘max’
> return max(mm->hiwater_vm, mm->total_vm);
> ^
> ./include/linux/bvec.h: In function ‘bvec_iter_advance’:
> ./include/linux/kernel.h:833:2: error: first argument to
> ‘__builtin_choose_expr’ not a constant
> __builtin_choose_expr(__builtin_constant_p(x) && \
> ^
> ./include/linux/kernel.h:847:19: note: in expansion of macro ‘__min’
> #define min(x, y) __min(typeof(x), typeof(y), x, y)
> ^
> ./include/linux/bvec.h:59:2: note: in expansion of macro ‘min’
> min((iter).bi_size, \
> ^
> ...
>
--
~Randy
next prev parent reply other threads:[~2018-03-13 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 7:33 linux-next: Tree for Mar 13 Stephen Rothwell
2018-03-13 15:57 ` Mike Snitzer
2018-03-13 17:30 ` Randy Dunlap [this message]
2018-03-13 19:52 ` Kees Cook
2018-03-13 20:08 ` Stephen Rothwell
[not found] ` <20180313175205.GA15734@light.dominikbrodowski.net>
2018-03-13 20:48 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-03-13 4:13 Stephen Rothwell
2020-03-13 11:03 Stephen Rothwell
2015-03-13 6:36 Stephen Rothwell
2014-03-13 18:53 Mark Brown
2013-03-13 5:48 Stephen Rothwell
2013-03-13 5:48 ` Stephen Rothwell
2012-03-13 9:41 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431d701a-1ac2-6f95-aa49-bab1d921072b@infradead.org \
--to=rdunlap@infradead.org \
--cc=bart.vanassche@wdc.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.