From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D355CC76194 for ; Thu, 25 Jul 2019 16:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93ACE22BED for ; Thu, 25 Jul 2019 16:24:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dell.com header.i=@dell.com header.b="sT8ZX2Wf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390474AbfGYQYC (ORCPT ); Thu, 25 Jul 2019 12:24:02 -0400 Received: from mx0a-00154904.pphosted.com ([148.163.133.20]:22468 "EHLO mx0a-00154904.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390441AbfGYQX5 (ORCPT ); Thu, 25 Jul 2019 12:23:57 -0400 Received: from pps.filterd (m0170391.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6PG0Gud023674; Thu, 25 Jul 2019 12:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=smtpout1; bh=hgeOWCF5225x8T7FXLIFD/0bcalsAY0rIcUyWAy7H8c=; b=sT8ZX2WfhOoVVp02SKsmeZiCSjlKygXO88tDw2SsoRgVzyW4rHjzeFxZ8f7CK5D/EPDt wkHxE2CfNbu8pqOR+K9L8jpoePWkazhPTxQRl8ItA0K761zHDEfsDy9eq0wlTL33dlJ5 jslb45J+7x9LUtjnuV4jf9tM6vcWd5DLC17JoGajSaJLNjFP84tAuWKMS2eq5fBmPrVA 4+UGGlPN2IrYHNMCRzUrdfGVnonE4PnLIIeXRsoUUAZB6hqw8mIkTpxIqZK+iw0lqOOr euBlKExvQ7XJYQG57mIZfqFvBvt57jYE8Ca4Sp3JH/zRAnTbZNwCEFnig3UjU6LNHqAt IQ== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0a-00154904.pphosted.com with ESMTP id 2ty4km3623-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2019 12:23:56 -0400 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6PFw7aU109731; Thu, 25 Jul 2019 12:23:55 -0400 Received: from ausxippc110.us.dell.com (AUSXIPPC110.us.dell.com [143.166.85.200]) by mx0b-00154901.pphosted.com with ESMTP id 2tydtgtbmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jul 2019 12:23:55 -0400 X-LoopCount0: from 10.166.132.130 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208";a="836039950" From: To: , CC: , , , , , , Subject: RE: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems Thread-Topic: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems Thread-Index: AQHVQs6UiIesxZzK0UKkUWrQRuKoE6bbsW+A///PBcA= Date: Thu, 25 Jul 2019 16:23:53 +0000 Message-ID: <4323ed84dd07474eab65699b4d007aaf@AUSX13MPC105.AMER.DELL.COM> References: <2332799.izEFUvJP67@kreacher> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=Mario_Limonciello@Dell.com; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2019-07-25T16:10:40.2048648Z; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure Information Protection; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual; aiplabel=External Public x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-25_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907250188 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907250188 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org K1JhamF0DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS2FpLUhlbmcg RmVuZyA8a2FpLmhlbmcuZmVuZ0BjYW5vbmljYWwuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgSnVs eSAyNSwgMjAxOSA5OjAzIEFNDQo+IFRvOiBSYWZhZWwgSi4gV3lzb2NraQ0KPiBDYzogS2VpdGgg QnVzY2g7IENocmlzdG9waCBIZWxsd2lnOyBTYWdpIEdyaW1iZXJnOyBsaW51eC0NCj4gbnZtZUBs aXN0cy5pbmZyYWRlYWQub3JnOyBMaW1vbmNpZWxsbywgTWFyaW87IExpbnV4IFBNOyBMS01MDQo+ IFN1YmplY3Q6IFJlOiBbUmVncmVzc2lvbl0gQ29tbWl0ICJudm1lL3BjaTogVXNlIGhvc3QgbWFu YWdlZCBwb3dlciBzdGF0ZSBmb3INCj4gc3VzcGVuZCIgaGFzIHByb2JsZW1zDQo+IA0KPiANCj4g W0VYVEVSTkFMIEVNQUlMXQ0KPiANCj4gSGkgUmFmYWVsLA0KPiANCj4gYXQgMTc6NTEsIFJhZmFl bCBKLiBXeXNvY2tpIDxyandAcmp3eXNvY2tpLm5ldD4gd3JvdGU6DQo+IA0KPiA+IEhpIEtlaXRo LA0KPiA+DQo+ID4gVW5mb3J0dW5hdGVseSwNCj4gPg0KPiA+IGNvbW1pdCBkOTE2YjFiZTk0YjZk YzhkMjkzYWJlZDI0NTFmMzA2MmY2YWY3NTUxDQo+ID4gQXV0aG9yOiBLZWl0aCBCdXNjaCA8a2Vp dGguYnVzY2hAaW50ZWwuY29tPg0KPiA+IERhdGU6ICAgVGh1IE1heSAyMyAwOToyNzozNSAyMDE5 IC0wNjAwDQo+ID4NCj4gPiAgICAgbnZtZS1wY2k6IHVzZSBob3N0IG1hbmFnZWQgcG93ZXIgc3Rh dGUgZm9yIHN1c3BlbmQNCj4gPg0KPiA+IGRvZXNuJ3QgdW5pdmVyc2FsbHkgaW1wcm92ZSB0aGlu Z3MuICBJbiBmYWN0LCBpbiBzb21lIGNhc2VzIGl0IG1ha2VzDQo+ID4gdGhpbmdzIHdvcnNlLg0K PiA+DQo+ID4gRm9yIGV4YW1wbGUsIG9uIHRoZSBEZWxsIFhQUzEzIDkzODAgSSBoYXZlIGhlcmUg aXQgcHJldmVudHMgdGhlIHByb2Nlc3Nvcg0KPiA+IHBhY2thZ2UNCj4gPiBmcm9tIHJlYWNoaW5n IGlkbGUgc3RhdGVzIGRlZXBlciB0aGFuIFBDMiBpbiBzdXNwZW5kLXRvLWlkbGUgKHdoaWNoLCBv Zg0KPiA+IGNvdXJzZSwgYWxzbw0KPiA+IHByZXZlbnRzIHRoZSBTb0MgZnJvbSByZWFjaGluZyBh bnkga2luZCBvZiBTMGl4KS4NCj4gPg0KPiA+IFRoYXQgY2FuIGJlIHJlYWRpbHkgZXhwbGFpbmVk IHRvby4gIE5hbWVseSwgd2l0aCB0aGUgY29tbWl0IGFib3ZlIHRoZQ0KPiA+IE5WTWUgZGV2aWNl DQo+ID4gc3RheXMgaW4gRDAgb3ZlciBzdXNwZW5kL3Jlc3VtZSwgc28gdGhlIHJvb3QgcG9ydCBp dCBpcyBjb25uZWN0ZWQgdG8gYWxzbw0KPiA+IGhhcyB0byBzdGF5IGluDQo+ID4gRDAgYW5kIHRo YXQgImJsb2NrcyIgcGFja2FnZSBDLXN0YXRlcyBkZWVwZXIgdGhhbiBQQzIuDQo+ID4NCj4gPiBJ biBvcmRlciBmb3IgdGhlIHJvb3QgcG9ydCB0byBiZSBhYmxlIHRvIGdvIHRvIEQzLCB0aGUgZGV2 aWNlIGNvbm5lY3RlZA0KPiA+IHRvIGl0IGFsc28gbmVlZHMNCj4gPiB0byBnbyBpbnRvIEQzLCBz byBpdCBsb29rcyBsaWtlIChhdCBsZWFzdCBvbiB0aGlzIHBhcnRpY3VsYXIgbWFjaGluZSwgYnV0 DQo+ID4gbWF5YmUgaW4NCj4gPiBnZW5lcmFsKSwgYm90aCBEMyBhbmQgdGhlIE5WTWUtc3BlY2lm aWMgUE0gYXJlIG5lZWRlZC4NCg0KV2VsbCB0aGlzIGlzIHJlYWxseSB1bmZvcnR1bmF0ZSB0byBo ZWFyLiAgSSByZWNhbGwgdGhhdCB3aXRoIHNvbWUgZGlza3Mgd2Ugd2VyZQ0Kc2VlaW5nIHByb2Js ZW1zIHdoZXJlIE5WTUUgc3BlY2lmaWMgUE0gd2Fzbid0IHdvcmtpbmcgd2hlbiB0aGUgZGlzayB3 YXMgaW4gRDMuDQoNCk9uIHlvdXIgc3BlY2lmaWMgZGlzaywgaXQgd291bGQgYmUgZ29vZCB0byBr bm93IGlmIGp1c3QgcmVtb3ZpbmcgdGhlIHBjaV9zYXZlX3N0YXRlKHBkZXYpDQpjYWxsIGhlbHBz Lg0KDQpJZiBzbywgOg0KKiB0aGF0IG1pZ2h0IGJlIGEgYmV0dGVyIG9wdGlvbiB0byBhZGQgYXMg YSBwYXJhbWV0ZXIuDQoqIG1heWJlIHdlIHNob3VsZCBkb3VibGUgY2hlY2sgYWxsIHRoZSBkaXNr cyBvbmUgbW9yZSB0aW1lIHdpdGggdGhhdCB0d2Vhay4NCg0KPiA+DQo+ID4gSSdtIG5vdCBzdXJl IHdoYXQgdG8gZG8gaGVyZSwgYmVjYXVzZSBldmlkZW50bHkgdGhlcmUgYXJlIHN5c3RlbXMgd2hl cmUNCj4gPiB0aGF0IGNvbW1pdA0KPiA+IGhlbHBzLiAgSSB3YXMgdGhpbmtpbmcgYWJvdXQgYWRk aW5nIGEgbW9kdWxlIG9wdGlvbiBhbGxvd2luZyB0aGUgdXNlciB0bw0KPiA+IG92ZXJyaWRlIHRo ZQ0KPiA+IGRlZmF1bHQgYmVoYXZpb3Igd2hpY2ggaW4gdHVybiBzaG91bGQgYmUgY29tcGF0aWJs ZSB3aXRoIDUuMiBhbmQgZWFybGllcg0KPiA+IGtlcm5lbHMuDQo+IA0KPiBJIGp1c3QgYnJpZWZs eSB0ZXN0ZWQgczJpIG9uIFhQUyA5MzcwLCBhbmQgdGhlIHBvd2VyIG1ldGVyIHNob3dzIGEgMC44 fjAuOVcNCj4gcG93ZXIgY29uc3VtcHRpb24gc28gYXQgbGVhc3QgSSBkb27igJl0IHNlZSB0aGUg aXNzdWUgb24gWFBTIDkzNzAuDQo+IA0KDQpUbyBtZSB0aGF0IGNvbmZpcm1zIE5WTUUgaXMgZG93 biwgYnV0IGl0IHN0aWxsIHNlZW1zIGhpZ2hlciB0aGFuIEkgd291bGQgaGF2ZQ0KZXhwZWN0ZWQu ICBXZSBzaG91bGQgYmUgbW9yZSB0eXBpY2FsbHkgaW4gdGhlIG9yZGVyIG9mIH4wLjNXIEkgdGhp bmsuDQoNCj4gQ2FuIHlvdSBwbGVhc2UgcHJvdmlkZSB0aGUgb3V0cHV0IG9mIGBudm1lIGlkLWN0 cmwgL2Rldi9udm1lKmAgYW5kIEnigJlsbA0KPiB0ZXN0IHRoZSBOVk1lIGNvbnRyb2xsZXIgb24g WFBTIDkzODAuDQo+IA0KPiBLYWktSGVuZw0KPiANCj4gPg0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario.Limonciello@dell.com (Mario.Limonciello@dell.com) Date: Thu, 25 Jul 2019 16:23:53 +0000 Subject: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems In-Reply-To: References: <2332799.izEFUvJP67@kreacher> Message-ID: <4323ed84dd07474eab65699b4d007aaf@AUSX13MPC105.AMER.DELL.COM> +Rajat > -----Original Message----- > From: Kai-Heng Feng > Sent: Thursday, July 25, 2019 9:03 AM > To: Rafael J. Wysocki > Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux- > nvme at lists.infradead.org; Limonciello, Mario; Linux PM; LKML > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for > suspend" has problems > > > [EXTERNAL EMAIL] > > Hi Rafael, > >@17:51, Rafael J. Wysocki wrote: > > > Hi Keith, > > > > Unfortunately, > > > > commit d916b1be94b6dc8d293abed2451f3062f6af7551 > > Author: Keith Busch > > Date: Thu May 23 09:27:35 2019 -0600 > > > > nvme-pci: use host managed power state for suspend > > > > doesn't universally improve things. In fact, in some cases it makes > > things worse. > > > > For example, on the Dell XPS13 9380 I have here it prevents the processor > > package > > from reaching idle states deeper than PC2 in suspend-to-idle (which, of > > course, also > > prevents the SoC from reaching any kind of S0ix). > > > > That can be readily explained too. Namely, with the commit above the > > NVMe device > > stays in D0 over suspend/resume, so the root port it is connected to also > > has to stay in > > D0 and that "blocks" package C-states deeper than PC2. > > > > In order for the root port to be able to go to D3, the device connected > > to it also needs > > to go into D3, so it looks like (at least on this particular machine, but > > maybe in > > general), both D3 and the NVMe-specific PM are needed. Well this is really unfortunate to hear. I recall that with some disks we were seeing problems where NVME specific PM wasn't working when the disk was in D3. On your specific disk, it would be good to know if just removing the pci_save_state(pdev) call helps. If so, : * that might be a better option to add as a parameter. * maybe we should double check all the disks one more time with that tweak. > > > > I'm not sure what to do here, because evidently there are systems where > > that commit > > helps. I was thinking about adding a module option allowing the user to > > override the > > default behavior which in turn should be compatible with 5.2 and earlier > > kernels. > > I just briefly tested s2i on XPS 9370, and the power meter shows a 0.8~0.9W > power consumption so at least I don?t see the issue on XPS 9370. > To me that confirms NVME is down, but it still seems higher than I would have expected. We should be more typically in the order of ~0.3W I think. > Can you please provide the output of `nvme id-ctrl /dev/nvme*` and I?ll > test the NVMe controller on XPS 9380. > > Kai-Heng > > >