From: David Howells <dhowells@redhat.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: dhowells@redhat.com,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Scott Mayhew <smayhew@redhat.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs_context support.")
Date: Fri, 17 Jan 2020 14:20:03 +0000 [thread overview]
Message-ID: <433863.1579270803@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAJKOXPeCVwZfBsCVbc9RQUGi0UfWQw0uFamPiQasiO8fSthFsQ@mail.gmail.com>
You seem to be running afoul of the check here:
case Opt_minorversion:
if (result.uint_32 > NFS4_MAX_MINOR_VERSION)
goto out_of_bounds;
ctx->minorversion = result.uint_32;
break;
which would seem to indicate that the mount process is supplying
minorversion=X as an option. Can you modify your kernel to print param->key
and param->string at the top of nfs_fs_context_parse_param()? Adding
something like:
pr_notice("NFSOP '%s=%s'\n", param->key, param->string);
will likely suffice unless you're directly driving the new mount API - in
which case param->string might be things other than a string, but that's
unlikely. It might also be NULL, but printk should handle that.
David
next prev parent reply other threads:[~2020-01-17 14:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 11:33 [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs_context support.") Krzysztof Kozlowski
2020-01-17 0:49 ` Scott Mayhew
2020-01-17 11:53 ` Krzysztof Kozlowski
2020-01-17 12:54 ` David Howells
2020-01-17 13:16 ` Krzysztof Kozlowski
2020-01-17 14:08 ` David Howells
2020-01-17 14:36 ` Krzysztof Kozlowski
2020-01-17 14:20 ` David Howells [this message]
2020-01-17 14:40 ` Krzysztof Kozlowski
2020-01-17 15:12 ` David Howells
2020-01-17 15:17 ` Trond Myklebust
2020-01-17 15:32 ` Scott Mayhew
2020-01-17 15:44 ` David Howells
2020-01-17 15:48 ` [PATCH] nfs: Return EINVAL rather than ERANGE for mount parse errors David Howells
2020-01-17 15:55 ` [PATCH v2] " David Howells
2020-01-17 16:51 ` Krzysztof Kozlowski
2020-01-17 17:18 ` David Howells
2020-01-17 20:21 ` Schumaker, Anna
2020-01-17 21:12 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433863.1579270803@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=arnd@arndb.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.