From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 32/32] net/dpaa2: enable stashing for LS2088A
 devices
Date: Tue, 6 Dec 2016 19:50:26 +0000
Message-ID: <434169e4-1f69-714d-8a68-07bf66dc3a79@intel.com>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <1480875447-23680-33-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com,
 shreyansh.jain@nxp.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4C9B05582
 for <dev@dpdk.org>; Tue,  6 Dec 2016 20:50:29 +0100 (CET)
In-Reply-To: <1480875447-23680-33-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/4/2016 6:17 PM, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Not just specific to this patch, but overall, can you please try to
provide more information in the comment logs.

> ---
>  drivers/net/dpaa2/dpaa2_ethdev.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 1a25f07..dd8e8fb 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -229,6 +229,17 @@
>  	options = options | DPNI_QUEUE_OPT_USER_CTX;
>  	cfg.user_context = (uint64_t)(dpaa2_q);
>  
> +	/*if ls2088 or rev2 device, enable the stashing */
> +	if ((qbman_get_version() & 0xFFFF0000) > QMAN_REV_4000) {
> +		options |= DPNI_QUEUE_OPT_FLC;
> +		cfg.flc.stash_control = true;
> +		cfg.flc.value &= 0xFFFFFFFFFFFFFFC0;
> +		/* 00 00 00 - last 6 bit represent annotation, context stashing,
> +		*  data stashing setting 01 01 00 (0x14) to enable
> +		*  1 line annotation, 1 line context
> +		*/
> +		cfg.flc.value |= 0x14;
> +	}
>  	ret = dpni_set_queue(dpni, CMD_PRI_LOW, priv->token, DPNI_QUEUE_RX,
>  			     dpaa2_q->tc_index, flow_id, options, &cfg);
>  	if (ret) {
>