From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Jing D" Subject: Re: [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd driver Date: Mon, 2 Feb 2015 02:59:42 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D01661ED1@shsmsx102.ccr.corp.intel.com> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <20150130212633.GD2664@hmsreliant.think-freely.org> <20150130214622.GA21286@plxv1142.pdx.intel.com> <1465014.svDMzIcz90@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon , "Shaw, Jeffrey B" Return-path: In-Reply-To: <1465014.svDMzIcz90@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Thomas Monjalon > Sent: Saturday, January 31, 2015 6:19 AM > To: Shaw, Jeffrey B > Cc: dev-VfR2kkLFssw@public.gmane.org > Subject: Re: [dpdk-dev] [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd > driver >=20 > 2015-01-30 13:46, Jeff Shaw: > > On Fri, Jan 30, 2015 at 04:26:33PM -0500, Neil Horman wrote: > > > On Fri, Jan 30, 2015 at 01:07:16PM +0800, Chen Jing D(Mark) wrote: > > > > From: "Chen Jing D(Mark)" > > > > Jeff Shaw (18): > > > > fm10k: add base driver > [...] > > > > lib/librte_pmd_fm10k/SHARED/fm10k_api.c | 327 ++++ > [...] > > > > > > Why is there a SHARED directory in the driver? Are there other drive= rs > that use > > > the shared fm10k code? > > > > No, the other poll-mode drivers do not use the shared fm10k code. The > > directory is similar to the 'ixgbe' and 'i40e' directories in their > > respective PMDs, only that it is named 'SHARED' for the fm10k driver. >=20 > So shared is a bad name in the context of DPDK. > Inside Intel, it can be understood that you share it between projects, > but in DPDK, it's only a base driver. >=20 OK, I'll change "SHARED" to "fm10k". > -- > Thomas