From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Jing D" <jing.d.chen@intel.com>
Subject: Re: [PATCH v8 2/4] ethdev: Fill speed capability bitmaps
 in the PMDs
Date: Mon, 15 Feb 2016 09:17:22 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D04441303@shsmsx102.ccr.corp.intel.com>
References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com>
 <1455488259-1000-1-git-send-email-marcdevel@gmail.com>
 <1455488259-1000-3-git-send-email-marcdevel@gmail.com>
 <20160215084321.GK14424@autoinstall.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>, "Marc
 Sune" <marcdevel@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 2DA7F56B7
 for <dev@dpdk.org>; Mon, 15 Feb 2016 10:17:26 +0100 (CET)
In-Reply-To: <20160215084321.GK14424@autoinstall.dev.6wind.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Marc,

Best Regards,
Mark

> -----Original Message-----
> From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> Sent: Monday, February 15, 2016 4:43 PM
> To: Marc Sune
> Cc: dev@dpdk.org; Lu, Wenzhuo; Zhang, Helin; Harish Patil; Chen, Jing D
> Subject: Re: [dpdk-dev] [PATCH v8 2/4] ethdev: Fill speed capability bitm=
aps
> in the PMDs
>=20
> On Sun, Feb 14, 2016 at 11:17:37PM +0100, Marc Sune wrote:
> > Added speed capabilities to all pmds supporting physical NICs:
> >
> > * e1000
> > * ixgbe
> > * i40
> > * bnx2x
> > * cxgbe
> > * mlx4
> > * mlx5
> > * nfp
> > * fm10k
> >[...]
> > diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c
> > index 1159fa3..99dac09 100644
> > --- a/drivers/net/mlx5/mlx5_ethdev.c
> > +++ b/drivers/net/mlx5/mlx5_ethdev.c
> > @@ -523,6 +523,11 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *info)
> >  	 * size if it is not fixed.
> >  	 * The API should be updated to solve this problem. */
> >  	info->reta_size =3D priv->ind_table_max_size;
> > +
> > +	info->speed_capa =3D ETH_SPEED_CAP_1G | ETH_SPEED_CAP_10G |
> > +					ETH_SPEED_CAP_10G |
> ETH_SPEED_CAP_40G |
> > +					ETH_SPEED_CAP_56G;
> > +
> >  	priv_unlock(priv);
> >  }
>=20
> Hi Marc,
>=20
> I have a question about this information, is it a list of the
> capabilities of the family or the capability of the NIC?
> Because with ConnectX4 family we have a range of NICs which does not
> support all this kind of speeds.
>=20
> The speeds above are not completed the range is 1/10/25/40/50/100G.
>=20

Fm10k also includes several cards and different ones are designed to have d=
ifferent speed.
A better solution for fm10k is to acquire NIC type (like, BR card for 100G/=
40G, Atwood for 25/10G, etc)
Then, return proper speed.

> --
> N=E9lio Laranjeiro
> 6WIND