From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Jing D" Subject: Re: [PATCH v2 29/32] net/i40e: parse more VF parameter and configure Date: Wed, 7 Dec 2016 15:32:59 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3A3C3471@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-30-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "dev@dpdk.org" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 30B8D2B8E for ; Wed, 7 Dec 2016 16:33:25 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:19 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF paramete= r > and configure >=20 > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > When VF requested to configure TX queue, a few parameters are missed > > to be configured in PF host. This change have more fields parsed and > > configured for TX context. >=20 > What is the effect of missing Tx paramters configured? >=20 > If this cause a bug, this patch should be a fix. >=20 This need to analyze case by case. If PF driver is serving a DPDK VF client= ,=20 the missing part is OK. If serving a Linux VF client, the missing part will= =20 cause some unexpected TX queue behaviors.=20 So, this is an enhancement to support Linux VF client.=20 > > > > Signed-off-by: Chen Jing D(Mark) > > --- > > drivers/net/i40e/i40e_pf.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c > > index 8319c2c..1ad5ed1 100644 > > --- a/drivers/net/i40e/i40e_pf.c > > +++ b/drivers/net/i40e/i40e_pf.c > > @@ -422,10 +422,12 @@ > > > > /* clear the context structure first */ > > memset(&tx_ctx, 0, sizeof(tx_ctx)); > > - tx_ctx.new_context =3D 1; > > tx_ctx.base =3D txq->dma_ring_addr / I40E_QUEUE_BASE_ADDR_UNIT; > > tx_ctx.qlen =3D txq->ring_len; > > tx_ctx.rdylist =3D rte_le_to_cpu_16(vf->vsi->info.qs_handle[0]); > > + tx_ctx.head_wb_ena =3D txq->headwb_enabled; > > + tx_ctx.head_wb_addr =3D txq->dma_headwb_addr; > > + > > err =3D i40e_clear_lan_tx_queue_context(hw, abs_queue_id); > > if (err !=3D I40E_SUCCESS) > > return err; > >