From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Jing D" <jing.d.chen@intel.com>
Subject: Re: [PATCH v2 27/32] net/i40e: change version number to
 support Linux VF
Date: Thu, 8 Dec 2016 09:14:01 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3A3D0F3A@shsmsx102.ccr.corp.intel.com>
References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-28-git-send-email-wenzhuo.lu@intel.com>
 <3cc33a4b-d45f-0008-05fc-033df4ccb197@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 54B5E2A5E
 for <dev@dpdk.org>; Thu,  8 Dec 2016 10:14:06 +0100 (CET)
In-Reply-To: <3cc33a4b-d45f-0008-05fc-033df4ccb197@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 07, 2016 11:14 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Chen, Jing D <jing.d.chen@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 27/32] net/i40e: change version number =
to
> support Linux VF
>=20
> On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> > i40e PF host only support to work with DPDK VF driver, Linux
> > VF driver is not supported. This change will enhance in version
> > number returned.
> >
> > Current version info returned won't be able to be recognized
> > by Linux VF driver, change to values that both DPDK VF and Linux
> > driver can recognize.
> >
> > The expense is original DPDK host specific feature like
> > CFG_VLAN_PVID and CONFIG_VSI_QUEUES_EXT will not available.
> >
> > DPDK VF also can't identify host driver by version number returned.
> > It always assume talking with Linux PF.
>=20
> I guess you mention from following code [1], should it be also updated
> to prevent it giving wrong information:

I'd like to update it into some docs.

>=20
> [1] i40e_ethdev_vf.c
>         if (vf->version_major =3D=3D I40E_DPDK_VERSION_MAJOR)
>                 PMD_DRV_LOG(INFO, "Peer is DPDK PF host");
>         else if ((vf->version_major =3D=3D I40E_VIRTCHNL_VERSION_MAJOR) &=
&
>                 (vf->version_minor <=3D I40E_VIRTCHNL_VERSION_MINOR))
>                 PMD_DRV_LOG(INFO, "Peer is Linux PF host");
>         else {
>=20
> >
> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> > ---
>=20
> <...>