From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Jing D" <jing.d.chen@intel.com>
Subject: Re: [PATCH] net/fm10k/base: add a break statement
Date: Thu, 22 Dec 2016 05:22:22 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3C5C6866@shsmsx102.ccr.corp.intel.com>
References: <1482289505-47591-1-git-send-email-yao.chenghu@zte.com.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Chenghu Yao <yao.chenghu@zte.com.cn>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id D15F22B94
 for <dev@dpdk.org>; Thu, 22 Dec 2016 06:22:27 +0100 (CET)
In-Reply-To: <1482289505-47591-1-git-send-email-yao.chenghu@zte.com.cn>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Chenghu,


> -----Original Message-----
> From: Chenghu Yao [mailto:yao.chenghu@zte.com.cn]
> Sent: Wednesday, December 21, 2016 11:05 AM
> To: Chen, Jing D <jing.d.chen@intel.com>
> Cc: dev@dpdk.org; Chenghu Yao <yao.chenghu@zte.com.cn>
> Subject: [PATCH] net/fm10k/base: add a break statement
>=20
> In function fm10k_mbx_create_reply(), the last case branch
> has no break statement.
>=20
> Signed-off-by: Chenghu Yao <yao.chenghu@zte.com.cn>
> ---
>  drivers/net/fm10k/base/fm10k_mbx.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/net/fm10k/base/fm10k_mbx.c
> b/drivers/net/fm10k/base/fm10k_mbx.c
> index 2e70434..45d6ddb 100644
> --- a/drivers/net/fm10k/base/fm10k_mbx.c
> +++ b/drivers/net/fm10k/base/fm10k_mbx.c
> @@ -1084,6 +1084,7 @@ STATIC s32 fm10k_mbx_create_reply(struct fm10k_hw
> *hw,
>  	case FM10K_STATE_CLOSED:
>  		/* generate new header based on data */
>  		fm10k_mbx_create_disconnect_hdr(mbx);
> +		break;
>  	default:
>  		break;
>  	}

Thanks for contributing code. But there are 2 problems here.

1. You are modifying base code under 'base' directory. It assumed READ ONLY=
 because
    there is another Intel team are maintaining it.
2. Without your change, the code won't have any negative effect. Yes, I app=
reciate your
    change to make it stronger.

So, I'd to say 'NAC' for this patch.