From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9486DC072B5 for ; Fri, 24 May 2019 08:35:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 592FF20675 for ; Fri, 24 May 2019 08:35:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="Ojaeizz5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389643AbfEXIfl (ORCPT ); Fri, 24 May 2019 04:35:41 -0400 Received: from mail.z3ntu.xyz ([128.199.32.197]:37286 "EHLO mail.z3ntu.xyz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389514AbfEXIfl (ORCPT ); Fri, 24 May 2019 04:35:41 -0400 Received: from g550jk.localnet (80-110-121-20.cgn.dynamic.surfer.at [80.110.121.20]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 6D2B1C1D14; Fri, 24 May 2019 08:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1558686937; bh=8QxbOGfJLKmBY8BnGjqJHLbP9D2w96jkIDyZThAA41g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ojaeizz5pLdCcF0xdLCfW2ni1k4DaVA/6/5fp3iYD4hTrR7fARGyYCfz5XnQRDoHI 7h/ZuL2OpPXI3J+LHDxh1JlHJgpGe2DJBb1PlzoBfqK8WFhvQ3wa5it0XQv1AD4S2X FKdfKRnUKtB9iNVgwby3tNXv0SssAzJNxWfoQYqE= From: Luca Weiss To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Fri, 24 May 2019 10:35:36 +0200 Message-ID: <4343071.IDWclfcoxo@g550jk> In-Reply-To: <20190521142544.ma2xfu77bamk4hvc@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190521142544.ma2xfu77bamk4hvc@flea> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >> Signed-off-by: Luca Weiss > > >> >> --- > > >> >> > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > >> >> 1 file changed, 7 insertions(+) > > >> >> > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> @@ -704,6 +704,13 @@ > > >> >> > > >> >> status = "disabled"; > > >> >> > > >> >> }; > > >> >> > > >> >> + lradc: lradc@1c21800 { > > >> >> + compatible = "allwinner,sun4i-a10-lradc- keys"; > > >> >> + reg = <0x01c21800 0x100>; > > >> >> + interrupts = ; > > >> >> + status = "disabled"; > > >> >> + }; > > >> >> + > > >> > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > >The > > > > > >> >A10 has two channels for example, while the A64 has only one. > > >> > > > >> >It looks like the one in the A83t though, so you can use that > > >> >compatible instead. > > >> > > >> Looking at the patch for the A83t, the only difference is that it > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > >> the channels. > > > > > >I guess you can reuse the A83t compatible here then, and a more > > >specific a64 compatible in case we ever need to fix this. > > > > > >> But I'm also not sure which one (or a different one) > > >> is used from looking at the "A64 User Manual". > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > used on the A64. > > Ok :) > > I guess you can just reuse the A83t compatible then, together with the > A64's. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, I'd submit a v2 with these changes to v1 then: lradc: lradc@1c21800 { - compatible = "allwinner,sun4i-a10-lradc-keys"; - reg = <0x01c21800 0x100>; + compatible = "allwinner,sun50i-a64-lradc-keys", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; interrupts = ; status = "disabled"; }; Does that look okay? The reg change is due to me not spotting the address being 0x01C2 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. Thanks for the feedback, Luca From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Weiss Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Fri, 24 May 2019 10:35:36 +0200 Message-ID: <4343071.IDWclfcoxo@g550jk> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190521142544.ma2xfu77bamk4hvc@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190521142544.ma2xfu77bamk4hvc@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >> Signed-off-by: Luca Weiss > > >> >> --- > > >> >> > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > >> >> 1 file changed, 7 insertions(+) > > >> >> > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> @@ -704,6 +704,13 @@ > > >> >> > > >> >> status = "disabled"; > > >> >> > > >> >> }; > > >> >> > > >> >> + lradc: lradc@1c21800 { > > >> >> + compatible = "allwinner,sun4i-a10-lradc- keys"; > > >> >> + reg = <0x01c21800 0x100>; > > >> >> + interrupts = ; > > >> >> + status = "disabled"; > > >> >> + }; > > >> >> + > > >> > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > >The > > > > > >> >A10 has two channels for example, while the A64 has only one. > > >> > > > >> >It looks like the one in the A83t though, so you can use that > > >> >compatible instead. > > >> > > >> Looking at the patch for the A83t, the only difference is that it > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > >> the channels. > > > > > >I guess you can reuse the A83t compatible here then, and a more > > >specific a64 compatible in case we ever need to fix this. > > > > > >> But I'm also not sure which one (or a different one) > > >> is used from looking at the "A64 User Manual". > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > used on the A64. > > Ok :) > > I guess you can just reuse the A83t compatible then, together with the > A64's. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, I'd submit a v2 with these changes to v1 then: lradc: lradc@1c21800 { - compatible = "allwinner,sun4i-a10-lradc-keys"; - reg = <0x01c21800 0x100>; + compatible = "allwinner,sun50i-a64-lradc-keys", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; interrupts = ; status = "disabled"; }; Does that look okay? The reg change is due to me not spotting the address being 0x01C2 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. Thanks for the feedback, Luca From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C8C4C072B5 for ; Fri, 24 May 2019 08:35:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 380C920675 for ; Fri, 24 May 2019 08:35:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ftIOkQbV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="Ojaeizz5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 380C920675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=z3ntu.xyz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NjGm/yqxTRKr+QFsCz4O7td51HF66QZRL4D4zJX39k4=; b=ftIOkQbVpbt+lE Hh5Ycwg25uFipGUxJu8fCX4jdjq0eBlphGPbADSj5B1HsRoGjXQ/rUrnSW9pk6dRTmoyhYMuafkyz jlPn8QsxNJgzMraeX0TrIUeGSYNezkpRH+Npjg9sIXMrAVh5VArZ1VHpwJEjJJyhYaALe27bCeGs7 EusZQKbqDdHHGtCXjulbOc7AoQ3KfLdFUlYTyrl6XqJ8UZG+FE0adRSFxeb46aB0SpCwlRC1OSouy LBmoK1+2DjIjAZqScy7tfLJDjg190A7OPK7Ywz+jTDuLSYEcyXRejHa2DEbA3g7jkFCMMCgeW9T/9 pdpKM0PJDwAKSKWm3g3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hU5fz-00042c-Th; Fri, 24 May 2019 08:35:43 +0000 Received: from mail.z3ntu.xyz ([128.199.32.197]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hU5fw-00040n-Du for linux-arm-kernel@lists.infradead.org; Fri, 24 May 2019 08:35:42 +0000 Received: from g550jk.localnet (80-110-121-20.cgn.dynamic.surfer.at [80.110.121.20]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 6D2B1C1D14; Fri, 24 May 2019 08:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1558686937; bh=8QxbOGfJLKmBY8BnGjqJHLbP9D2w96jkIDyZThAA41g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ojaeizz5pLdCcF0xdLCfW2ni1k4DaVA/6/5fp3iYD4hTrR7fARGyYCfz5XnQRDoHI 7h/ZuL2OpPXI3J+LHDxh1JlHJgpGe2DJBb1PlzoBfqK8WFhvQ3wa5it0XQv1AD4S2X FKdfKRnUKtB9iNVgwby3tNXv0SssAzJNxWfoQYqE= From: Luca Weiss To: Maxime Ripard Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Fri, 24 May 2019 10:35:36 +0200 Message-ID: <4343071.IDWclfcoxo@g550jk> In-Reply-To: <20190521142544.ma2xfu77bamk4hvc@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190521142544.ma2xfu77bamk4hvc@flea> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190524_013540_822949_A754F457 X-CRM114-Status: GOOD ( 26.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Chen-Yu Tsai , Rob Herring , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >> Signed-off-by: Luca Weiss > > >> >> --- > > >> >> > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > >> >> 1 file changed, 7 insertions(+) > > >> >> > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> @@ -704,6 +704,13 @@ > > >> >> > > >> >> status = "disabled"; > > >> >> > > >> >> }; > > >> >> > > >> >> + lradc: lradc@1c21800 { > > >> >> + compatible = "allwinner,sun4i-a10-lradc- keys"; > > >> >> + reg = <0x01c21800 0x100>; > > >> >> + interrupts = ; > > >> >> + status = "disabled"; > > >> >> + }; > > >> >> + > > >> > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > >The > > > > > >> >A10 has two channels for example, while the A64 has only one. > > >> > > > >> >It looks like the one in the A83t though, so you can use that > > >> >compatible instead. > > >> > > >> Looking at the patch for the A83t, the only difference is that it > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > >> the channels. > > > > > >I guess you can reuse the A83t compatible here then, and a more > > >specific a64 compatible in case we ever need to fix this. > > > > > >> But I'm also not sure which one (or a different one) > > >> is used from looking at the "A64 User Manual". > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > used on the A64. > > Ok :) > > I guess you can just reuse the A83t compatible then, together with the > A64's. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, I'd submit a v2 with these changes to v1 then: lradc: lradc@1c21800 { - compatible = "allwinner,sun4i-a10-lradc-keys"; - reg = <0x01c21800 0x100>; + compatible = "allwinner,sun50i-a64-lradc-keys", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; interrupts = ; status = "disabled"; }; Does that look okay? The reg change is due to me not spotting the address being 0x01C2 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. Thanks for the feedback, Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel