From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7C6C433EF for ; Tue, 22 Feb 2022 10:46:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbiBVKq6 (ORCPT ); Tue, 22 Feb 2022 05:46:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiBVKq5 (ORCPT ); Tue, 22 Feb 2022 05:46:57 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16282DF08; Tue, 22 Feb 2022 02:46:32 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id f11so11047542ljq.11; Tue, 22 Feb 2022 02:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=Wvvk4dYJGf5Y8/8AlZicv/dhMGLGNFdMJpU3wenpSJZw/ybyjG3nx9inX0NopTAr9b hki9SqFotR4DokiJbsxi3yGsFbnL/zXxiDg/fRjfzRxiszEbWkFKpYheubiSHqOaxP34 rjOvLBDn9kWi79ogs4Zh8W6upcZAtRRWT4N5DEvXeccq1jr0fRCdDH4AhV3jc6YMVzYY 6IEqUC1xQpeJJXazlibsxRAUbsunJcLJ+Q8OZRSlkEt2s3SOTVvGTqVfVXppSIfJi21t hGpypFfvt3zGUuu9KQLV5peGeZ7tki5MqV+SxDeCYQ79bdLGMFynXY4YZv5rFu2cevD6 iV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=cZWsUQrpeNMJ/5tY5f6YHyGGkTaVS7erzwy/JEYzin03ru86tPNOwOPBlXiPWEzusl XO46VVjeDABvAfnItk1UzTkZYJxR6+tlfcCKn3itIH6CmyN6yLM51XGgkOGScwWhyfsB 6Z04ThtISuQ59WxM/X/zYrZROkg5+g/VHNHhN1/5CUArD4YSv7h6Wl3SGVIM3umhV2aO cKdBwXATBkfInR4eT+QsE9SqE3hioj1kRM3x0Z/9dqptzWIUOr2nU+nXsmTDO79q9q8L NjuylXIVok8HemGRscKxpwUHWZGkvyNuMlcif0IX9QsZFkpQDEZNWI4Lvqpvpm2N+03T TF2A== X-Gm-Message-State: AOAM533BHA/D1cKZ1sOIF1Pwyb1qMDo8wldJNRoptG7vS6hUSvILWOd4 FvPkePefuIjUyeOloBLq+7I= X-Google-Smtp-Source: ABdhPJwZ1McSWpt8xE8JSzJ7PFSX/UI6DWDglB8xl7blNXCItqUCMFWL3e68OUp80Bgn508refVPUw== X-Received: by 2002:a2e:980f:0:b0:246:3fb6:816b with SMTP id a15-20020a2e980f000000b002463fb6816bmr6085199ljj.242.1645526790359; Tue, 22 Feb 2022 02:46:30 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id w10sm1599556ljd.101.2022.02.22.02.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 02:46:29 -0800 (PST) Message-ID: <4352fda7-ecb6-4a5e-7d6c-a50537d8eaff@gmail.com> Date: Tue, 22 Feb 2022 13:46:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 22.02.2022 11:27, Mikko Perttunen пишет: > On 2/21/22 22:10, Dmitry Osipenko wrote: >> 21.02.2022 14:44, Mikko Perttunen пишет: >>> On 2/19/22 20:54, Dmitry Osipenko wrote: >>>> 19.02.2022 21:49, Dmitry Osipenko пишет: >>>>> 18.02.2022 14:39, Mikko Perttunen пишет: >>>>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client) >>>>>> +{ >>>>>> +    struct vic *vic = to_vic(client); >>>>>> +    int err; >>>>>> + >>>>>> +    err = vic_load_firmware(vic); >>>>> >>>>> You can't invoke vic_load_firmware() while RPM is suspended. Either >>>>> replace this with RPM get/put or do something else. >>> >>> Why not, I'm not seeing any HW accesses in vic_load_firmware? Although >>> it looks like it might race with the vic_load_firmware call in >>> vic_runtime_resume which probably needs to be fixed. >> >> It was not clear from the function's name that h/w is untouched, I read >> "load" as "upload" and then looked at vic_runtime_resume(). I'd rename >> vic_load_firmware() to vic_prepare_firmware_image(). >> >> And yes, technically lock is needed. > > Yep, I'll consider renaming it. Looking at this all again, I'd suggest to change: int get_streamid_offset(client) to: int get_streamid_offset(client, *offset) and bail out if get_streamid_offset() returns error. It's never okay to ignore errors. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A099C43217 for ; Tue, 22 Feb 2022 10:46:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2E9C160B75; Tue, 22 Feb 2022 10:46:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iFiitiUFXJxE; Tue, 22 Feb 2022 10:46:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 13B4260EAC; Tue, 22 Feb 2022 10:46:34 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D8C85C001A; Tue, 22 Feb 2022 10:46:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4B8E3C0011 for ; Tue, 22 Feb 2022 10:46:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 39DFE81A5C for ; Tue, 22 Feb 2022 10:46:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id edo9sZFL0IdL for ; Tue, 22 Feb 2022 10:46:32 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by smtp1.osuosl.org (Postfix) with ESMTPS id 71E1781A58 for ; Tue, 22 Feb 2022 10:46:32 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id v22so16934311ljh.7 for ; Tue, 22 Feb 2022 02:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=Wvvk4dYJGf5Y8/8AlZicv/dhMGLGNFdMJpU3wenpSJZw/ybyjG3nx9inX0NopTAr9b hki9SqFotR4DokiJbsxi3yGsFbnL/zXxiDg/fRjfzRxiszEbWkFKpYheubiSHqOaxP34 rjOvLBDn9kWi79ogs4Zh8W6upcZAtRRWT4N5DEvXeccq1jr0fRCdDH4AhV3jc6YMVzYY 6IEqUC1xQpeJJXazlibsxRAUbsunJcLJ+Q8OZRSlkEt2s3SOTVvGTqVfVXppSIfJi21t hGpypFfvt3zGUuu9KQLV5peGeZ7tki5MqV+SxDeCYQ79bdLGMFynXY4YZv5rFu2cevD6 iV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=42TP5JuV1dNHYdOPUIk+7kO3HqohZpUZrL0u/qhJDjoXnl/r4JNTQRJgC604yv2Vfm nkhfCB8PnJgjPaOsMLRZ6uoECNt6VVo6ew+ymBUN7Z05V2hWhb1zeja/1c1dlOfSWTbA tsaQEbB7r9MDc5prRLJ6FkPSo+vRLAHULjB53wfc7ljmvBjoFsoG2RI8ji/8RXDBwgUS fLZk6QYORtIBQKp4aB4k0ieayRbde98KNhQFlcbe7REd/VbWszCsEWIDK8X71Asc5bYd gpxEM+UirtGAmtYWMshQXCVn8cxSJxmo+gB+220c8r5T9jBk+oYtRrTFb6JvqJJyoU1s Hfsg== X-Gm-Message-State: AOAM532ho8y6DO+kqyfPuooSvag8GkKkOEzIMhXeOBtVfTyxNHeZsDHh NdY3/JTYKvR0m/oZmvGXrAY= X-Google-Smtp-Source: ABdhPJwZ1McSWpt8xE8JSzJ7PFSX/UI6DWDglB8xl7blNXCItqUCMFWL3e68OUp80Bgn508refVPUw== X-Received: by 2002:a2e:980f:0:b0:246:3fb6:816b with SMTP id a15-20020a2e980f000000b002463fb6816bmr6085199ljj.242.1645526790359; Tue, 22 Feb 2022 02:46:30 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id w10sm1599556ljd.101.2022.02.22.02.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 02:46:29 -0800 (PST) Message-ID: <4352fda7-ecb6-4a5e-7d6c-a50537d8eaff@gmail.com> Date: Tue, 22 Feb 2022 13:46:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" MjIuMDIuMjAyMiAxMToyNywgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6Cj4gT24gMi8yMS8y MiAyMjoxMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+PiAyMS4wMi4yMDIyIDE0OjQ0LCBNaWtr byBQZXJ0dHVuZW4g0L/QuNGI0LXRgjoKPj4+IE9uIDIvMTkvMjIgMjA6NTQsIERtaXRyeSBPc2lw ZW5rbyB3cm90ZToKPj4+PiAxOS4wMi4yMDIyIDIxOjQ5LCBEbWl0cnkgT3NpcGVua28g0L/QuNGI 0LXRgjoKPj4+Pj4gMTguMDIuMjAyMiAxNDozOSwgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6 Cj4+Pj4+PiArc3RhdGljIGludCB2aWNfZ2V0X3N0cmVhbWlkX29mZnNldChzdHJ1Y3QgdGVncmFf ZHJtX2NsaWVudCAqY2xpZW50KQo+Pj4+Pj4gK3sKPj4+Pj4+ICvCoMKgwqAgc3RydWN0IHZpYyAq dmljID0gdG9fdmljKGNsaWVudCk7Cj4+Pj4+PiArwqDCoMKgIGludCBlcnI7Cj4+Pj4+PiArCj4+ Pj4+PiArwqDCoMKgIGVyciA9IHZpY19sb2FkX2Zpcm13YXJlKHZpYyk7Cj4+Pj4+Cj4+Pj4+IFlv dSBjYW4ndCBpbnZva2UgdmljX2xvYWRfZmlybXdhcmUoKSB3aGlsZSBSUE0gaXMgc3VzcGVuZGVk LiBFaXRoZXIKPj4+Pj4gcmVwbGFjZSB0aGlzIHdpdGggUlBNIGdldC9wdXQgb3IgZG8gc29tZXRo aW5nIGVsc2UuCj4+Pgo+Pj4gV2h5IG5vdCwgSSdtIG5vdCBzZWVpbmcgYW55IEhXIGFjY2Vzc2Vz IGluIHZpY19sb2FkX2Zpcm13YXJlPyBBbHRob3VnaAo+Pj4gaXQgbG9va3MgbGlrZSBpdCBtaWdo dCByYWNlIHdpdGggdGhlIHZpY19sb2FkX2Zpcm13YXJlIGNhbGwgaW4KPj4+IHZpY19ydW50aW1l X3Jlc3VtZSB3aGljaCBwcm9iYWJseSBuZWVkcyB0byBiZSBmaXhlZC4KPj4KPj4gSXQgd2FzIG5v dCBjbGVhciBmcm9tIHRoZSBmdW5jdGlvbidzIG5hbWUgdGhhdCBoL3cgaXMgdW50b3VjaGVkLCBJ IHJlYWQKPj4gImxvYWQiIGFzICJ1cGxvYWQiIGFuZCB0aGVuIGxvb2tlZCBhdCB2aWNfcnVudGlt ZV9yZXN1bWUoKS4gSSdkIHJlbmFtZQo+PiB2aWNfbG9hZF9maXJtd2FyZSgpIHRvIHZpY19wcmVw YXJlX2Zpcm13YXJlX2ltYWdlKCkuCj4+Cj4+IEFuZCB5ZXMsIHRlY2huaWNhbGx5IGxvY2sgaXMg bmVlZGVkLgo+IAo+IFllcCwgSSdsbCBjb25zaWRlciByZW5hbWluZyBpdC4KCkxvb2tpbmcgYXQg dGhpcyBhbGwgYWdhaW4sIEknZCBzdWdnZXN0IHRvIGNoYW5nZToKCmludCBnZXRfc3RyZWFtaWRf b2Zmc2V0KGNsaWVudCkKCnRvOgoKaW50IGdldF9zdHJlYW1pZF9vZmZzZXQoY2xpZW50LCAqb2Zm c2V0KQoKYW5kIGJhaWwgb3V0IGlmIGdldF9zdHJlYW1pZF9vZmZzZXQoKSByZXR1cm5zIGVycm9y LiBJdCdzIG5ldmVyIG9rYXkgdG8KaWdub3JlIGVycm9ycy4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3Rz LmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9922CC433F5 for ; Tue, 22 Feb 2022 10:46:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77A6D10E5D3; Tue, 22 Feb 2022 10:46:33 +0000 (UTC) Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E98C10E5D3 for ; Tue, 22 Feb 2022 10:46:32 +0000 (UTC) Received: by mail-lj1-x230.google.com with SMTP id r20so18845204ljj.1 for ; Tue, 22 Feb 2022 02:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=Wvvk4dYJGf5Y8/8AlZicv/dhMGLGNFdMJpU3wenpSJZw/ybyjG3nx9inX0NopTAr9b hki9SqFotR4DokiJbsxi3yGsFbnL/zXxiDg/fRjfzRxiszEbWkFKpYheubiSHqOaxP34 rjOvLBDn9kWi79ogs4Zh8W6upcZAtRRWT4N5DEvXeccq1jr0fRCdDH4AhV3jc6YMVzYY 6IEqUC1xQpeJJXazlibsxRAUbsunJcLJ+Q8OZRSlkEt2s3SOTVvGTqVfVXppSIfJi21t hGpypFfvt3zGUuu9KQLV5peGeZ7tki5MqV+SxDeCYQ79bdLGMFynXY4YZv5rFu2cevD6 iV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=NzPt/tzGtYaE3qvT2MM/OP9HzjuwUaZF2oNz7qKB6+gXVFG+wQTPT8hE6RkOr5SB+L ys2zLf7ztbRO30Vv6WRa8fuGGQrHGr1206Gp9xlRzdWqV8GADcLwAuls/V8I4TAtNrvw vmKFZKcRgCukT70l476RYJ9vZ9iZgQcGDaKKRw2ozTrw0r6sZLB9JpgkJsM0zj9OeB7r 95UfX+LHOKAC8b9FRExvv8aMZ+HMag6pn44CX/vxRM+lDgJSl4H7VbC6ot3LVqFWCkDp rBUGyMUSjSlNZqB785ptVveEn4DAE4w0D6uP5wZ5dd/fsy/WMCdxb83j3jqDLWPXWzfY JGpw== X-Gm-Message-State: AOAM532UMiTbpJIZapCeNF9eldH5Tz2pGKETPZkSfGoU7B/vpjVqxVjI kWRKwGYnFEDxFpMXr2R064c= X-Google-Smtp-Source: ABdhPJwZ1McSWpt8xE8JSzJ7PFSX/UI6DWDglB8xl7blNXCItqUCMFWL3e68OUp80Bgn508refVPUw== X-Received: by 2002:a2e:980f:0:b0:246:3fb6:816b with SMTP id a15-20020a2e980f000000b002463fb6816bmr6085199ljj.242.1645526790359; Tue, 22 Feb 2022 02:46:30 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id w10sm1599556ljd.101.2022.02.22.02.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 02:46:29 -0800 (PST) Message-ID: <4352fda7-ecb6-4a5e-7d6c-a50537d8eaff@gmail.com> Date: Tue, 22 Feb 2022 13:46:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 22.02.2022 11:27, Mikko Perttunen пишет: > On 2/21/22 22:10, Dmitry Osipenko wrote: >> 21.02.2022 14:44, Mikko Perttunen пишет: >>> On 2/19/22 20:54, Dmitry Osipenko wrote: >>>> 19.02.2022 21:49, Dmitry Osipenko пишет: >>>>> 18.02.2022 14:39, Mikko Perttunen пишет: >>>>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client) >>>>>> +{ >>>>>> +    struct vic *vic = to_vic(client); >>>>>> +    int err; >>>>>> + >>>>>> +    err = vic_load_firmware(vic); >>>>> >>>>> You can't invoke vic_load_firmware() while RPM is suspended. Either >>>>> replace this with RPM get/put or do something else. >>> >>> Why not, I'm not seeing any HW accesses in vic_load_firmware? Although >>> it looks like it might race with the vic_load_firmware call in >>> vic_runtime_resume which probably needs to be fixed. >> >> It was not clear from the function's name that h/w is untouched, I read >> "load" as "upload" and then looked at vic_runtime_resume(). I'd rename >> vic_load_firmware() to vic_prepare_firmware_image(). >> >> And yes, technically lock is needed. > > Yep, I'll consider renaming it. Looking at this all again, I'd suggest to change: int get_streamid_offset(client) to: int get_streamid_offset(client, *offset) and bail out if get_streamid_offset() returns error. It's never okay to ignore errors. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BE9BC43217 for ; Tue, 22 Feb 2022 10:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kXup8xGwTj6fbgk8CkMdDp5Pis1jMEQXJMQc2OUkyFw=; b=MJiLSrBD2jT0uO HsWDqO/nbtSiOkM5d2MVNmRe5lOFfjkEhFceGcuVHKnQipXBln0u257pGD7JG5XMob5Dc2iY7xQsM SqUz+5cEDmU5qVuY3najOvof/zxpP0WMAjTv5t4qcDRTPQm5W0SmU9QVNUpDlOsm9+GcN7wR/0Pot tp8W9U1Yz6b8bEq7eJP8Z6LJUMn3PrHM22GThohhoWYswpPzcdmkgcAbZIkLfslsW/FUH3jkceRs6 0gi6akw7EplCwuOcaVk9i/AFIJ2hUDoFOZkW+iQGKBtjs9lmFAWU45b2sBREmwXiUqqLOg7dl47R1 Nz/I8LDt/3Lyf2+f9D/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMSgn-0099nW-0I; Tue, 22 Feb 2022 10:46:37 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMSgi-0099lh-CQ for linux-arm-kernel@lists.infradead.org; Tue, 22 Feb 2022 10:46:33 +0000 Received: by mail-lj1-x233.google.com with SMTP id v28so11370679ljv.9 for ; Tue, 22 Feb 2022 02:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=Wvvk4dYJGf5Y8/8AlZicv/dhMGLGNFdMJpU3wenpSJZw/ybyjG3nx9inX0NopTAr9b hki9SqFotR4DokiJbsxi3yGsFbnL/zXxiDg/fRjfzRxiszEbWkFKpYheubiSHqOaxP34 rjOvLBDn9kWi79ogs4Zh8W6upcZAtRRWT4N5DEvXeccq1jr0fRCdDH4AhV3jc6YMVzYY 6IEqUC1xQpeJJXazlibsxRAUbsunJcLJ+Q8OZRSlkEt2s3SOTVvGTqVfVXppSIfJi21t hGpypFfvt3zGUuu9KQLV5peGeZ7tki5MqV+SxDeCYQ79bdLGMFynXY4YZv5rFu2cevD6 iV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iabqwLRHm/0Z6nOkM33Y0js7aZKJwfXcVsR9drxTBpI=; b=CTZbhgJ3l7tY6sofkIa7fmQm78GqxxlLRpRHPzKFIhygzhi/7bnVM2xEaY22vLdt0R ERfI16/CyvXsYdDHgCfgBrQi8oh2xRUaeN7ihwH0DEMWSbUPL7MPEBzum3Wx+H9oai1I x08Cu8Z/tUfPslV/mRaZ8ue6i1bhAX9AYKZfR6+J7uV3E7fAeVaMNbzD/BVliHyLJPxB W12Qh8RKllUklRRcz7wCq6y+C5RSKXtJ5Hwy38zFP1hLDN+KDiLNm66MkYnn0+cMiHq/ B+/nUmuarlRqr3YRZV2gqcrasABjRNgzHcp/yulcSoF1mGWhnMcK/0VH0sm80+rQpEHh fsvA== X-Gm-Message-State: AOAM531l22Gt8IcDzyvOib4Kj2ZEMrq4xpyO1RnLH4N2YR5B6CUOwloY Lo+iHj7sbXD1acAwpoeIEm8= X-Google-Smtp-Source: ABdhPJwZ1McSWpt8xE8JSzJ7PFSX/UI6DWDglB8xl7blNXCItqUCMFWL3e68OUp80Bgn508refVPUw== X-Received: by 2002:a2e:980f:0:b0:246:3fb6:816b with SMTP id a15-20020a2e980f000000b002463fb6816bmr6085199ljj.242.1645526790359; Tue, 22 Feb 2022 02:46:30 -0800 (PST) Received: from [192.168.2.145] (109-252-138-165.dynamic.spd-mgts.ru. [109.252.138.165]) by smtp.googlemail.com with ESMTPSA id w10sm1599556ljd.101.2022.02.22.02.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 02:46:29 -0800 (PST) Message-ID: <4352fda7-ecb6-4a5e-7d6c-a50537d8eaff@gmail.com> Date: Tue, 22 Feb 2022 13:46:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset Content-Language: en-US To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-9-mperttunen@nvidia.com> <7f4e4c47-59f1-1def-36bf-a2ded912f76d@gmail.com> <5d1b6e82-2c9d-8388-697f-0d7305a1206f@kapsi.fi> <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> From: Dmitry Osipenko In-Reply-To: <30033f5b-3fd1-22c7-896b-af034a4041df@kapsi.fi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_024632_456882_EE71804E X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjIuMDIuMjAyMiAxMToyNywgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6Cj4gT24gMi8yMS8y MiAyMjoxMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+PiAyMS4wMi4yMDIyIDE0OjQ0LCBNaWtr byBQZXJ0dHVuZW4g0L/QuNGI0LXRgjoKPj4+IE9uIDIvMTkvMjIgMjA6NTQsIERtaXRyeSBPc2lw ZW5rbyB3cm90ZToKPj4+PiAxOS4wMi4yMDIyIDIxOjQ5LCBEbWl0cnkgT3NpcGVua28g0L/QuNGI 0LXRgjoKPj4+Pj4gMTguMDIuMjAyMiAxNDozOSwgTWlra28gUGVydHR1bmVuINC/0LjRiNC10YI6 Cj4+Pj4+PiArc3RhdGljIGludCB2aWNfZ2V0X3N0cmVhbWlkX29mZnNldChzdHJ1Y3QgdGVncmFf ZHJtX2NsaWVudCAqY2xpZW50KQo+Pj4+Pj4gK3sKPj4+Pj4+ICvCoMKgwqAgc3RydWN0IHZpYyAq dmljID0gdG9fdmljKGNsaWVudCk7Cj4+Pj4+PiArwqDCoMKgIGludCBlcnI7Cj4+Pj4+PiArCj4+ Pj4+PiArwqDCoMKgIGVyciA9IHZpY19sb2FkX2Zpcm13YXJlKHZpYyk7Cj4+Pj4+Cj4+Pj4+IFlv dSBjYW4ndCBpbnZva2UgdmljX2xvYWRfZmlybXdhcmUoKSB3aGlsZSBSUE0gaXMgc3VzcGVuZGVk LiBFaXRoZXIKPj4+Pj4gcmVwbGFjZSB0aGlzIHdpdGggUlBNIGdldC9wdXQgb3IgZG8gc29tZXRo aW5nIGVsc2UuCj4+Pgo+Pj4gV2h5IG5vdCwgSSdtIG5vdCBzZWVpbmcgYW55IEhXIGFjY2Vzc2Vz IGluIHZpY19sb2FkX2Zpcm13YXJlPyBBbHRob3VnaAo+Pj4gaXQgbG9va3MgbGlrZSBpdCBtaWdo dCByYWNlIHdpdGggdGhlIHZpY19sb2FkX2Zpcm13YXJlIGNhbGwgaW4KPj4+IHZpY19ydW50aW1l X3Jlc3VtZSB3aGljaCBwcm9iYWJseSBuZWVkcyB0byBiZSBmaXhlZC4KPj4KPj4gSXQgd2FzIG5v dCBjbGVhciBmcm9tIHRoZSBmdW5jdGlvbidzIG5hbWUgdGhhdCBoL3cgaXMgdW50b3VjaGVkLCBJ IHJlYWQKPj4gImxvYWQiIGFzICJ1cGxvYWQiIGFuZCB0aGVuIGxvb2tlZCBhdCB2aWNfcnVudGlt ZV9yZXN1bWUoKS4gSSdkIHJlbmFtZQo+PiB2aWNfbG9hZF9maXJtd2FyZSgpIHRvIHZpY19wcmVw YXJlX2Zpcm13YXJlX2ltYWdlKCkuCj4+Cj4+IEFuZCB5ZXMsIHRlY2huaWNhbGx5IGxvY2sgaXMg bmVlZGVkLgo+IAo+IFllcCwgSSdsbCBjb25zaWRlciByZW5hbWluZyBpdC4KCkxvb2tpbmcgYXQg dGhpcyBhbGwgYWdhaW4sIEknZCBzdWdnZXN0IHRvIGNoYW5nZToKCmludCBnZXRfc3RyZWFtaWRf b2Zmc2V0KGNsaWVudCkKCnRvOgoKaW50IGdldF9zdHJlYW1pZF9vZmZzZXQoY2xpZW50LCAqb2Zm c2V0KQoKYW5kIGJhaWwgb3V0IGlmIGdldF9zdHJlYW1pZF9vZmZzZXQoKSByZXR1cm5zIGVycm9y LiBJdCdzIG5ldmVyIG9rYXkgdG8KaWdub3JlIGVycm9ycy4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK