From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758679AbbKSOXZ (ORCPT ); Thu, 19 Nov 2015 09:23:25 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:64701 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757284AbbKSOXK (ORCPT ); Thu, 19 Nov 2015 09:23:10 -0500 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Hannes Reinecke , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] scsi: advansys needs ISA dma api for ISA support Date: Thu, 19 Nov 2015 15:22:23 +0100 Message-ID: <4355540.BF55dNX7U7@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MDaUSD/lDR1QI+A5PN26Uxs+MWAYZWb/c84Ca4nPE9jXcXaDO97 kT3deqRnMawc8O0BVmheWRy0NKPu7Kh9i8CB4dQSiTjAc0ckZwx+7JFblKxJIloW85lJeIQ 8lM6/iIuKMRmzg7sSF82G+M4Udld43WJkXaYzPHdpKTFB2BJgjc2X72erXImWfJIIYRn8Qc mA9eWKmtmnshoYKaXJK4g== X-UI-Out-Filterresults: notjunk:1;V01:K0:cHMy+oO3ycw=:3FcPXljXgLK4Um8Qyemov9 loGq9zL5+GVaFCgPoVP20As4SYDLYn8cQYErrSYQUNeJRDlxZOJUnuMutjfeeOJxK8pDJP2re C5agf9bNkclReqjdDqnEjc54ckF2MTVMWL0BxCW9x2tqhmyRccmmoS6J5nAlqzFFpPUu7/aq8 WoKRwTDpLLUt/gQEU4jdzINcuLk7Fg+rO+Fd0OjjPYkU1uZrxTE7EO7N/vF56AUu7DEZRMkBs mPNxHTiZyx6vVJucA1JOPz5q+bTx+VHERvd4CV508Hu8NMuUDYBH4eJJvQIBHBhIzOEr+4zrN mr5w1z5gHqnQoASgGDZ1XmhJwuX+QcGKVKJnBQVNsBrhyaHwF06A72g7yWV0pjStCycVHvwL/ qtkyhZkBuZ4BJGZ6k/4IIOd/X2fh1qzC5MuEoDtl/UE1mOJ6fHHeM8Ftwh3FJ7IoWX3IB3bUO 3jcFn1VVJxHEThdeOVqD3pFSRkM14zn2SZH9v/bofv9jtB4NpeKnCwWXSDoh3MkSu2hVuEPYu 6tKb3SUaTHHBh6pKhJVit7XiwL3KvLu0mallb4TEv7hd1EcnnUeU8KPzHHJu+exaBNh0KwjG6 a9reCulfRG5H99JIRuxd5SOqnPCNKXTnDzI9dTvdAwSAYLtXNpnXrwdwTPMeGtAjgtmOU2NAv +NRsljNpe+tgl7OYo3b4NG0vd5nBrBf7+x5IjsfRd0IRfYyi9s6F/DvQfkZ2KB4ytLED3Oeof QCHm4f2PzBVenC+z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The advansys drvier uses the request_dma function that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] The problem now showed up in ARM randconfig builds after commit 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neither VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. This adds the missing dependency. Signed-off-by: Arnd Bergmann --- This is identical to v1 of the patch. We had gone through several iterations of this in October before concluding that everything else was more problematic. Please apply. diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 5f692ae40749..04a720686516 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,6 +499,7 @@ config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI depends on ISA || EISA || PCI + depends on ISA_DMA_API || !ISA help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: [PATCH v3] scsi: advansys needs ISA dma api for ISA support Date: Thu, 19 Nov 2015 15:22:23 +0100 Message-ID: <4355540.BF55dNX7U7@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-kernel@lists.infradead.org, Hannes Reinecke , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org The advansys drvier uses the request_dma function that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] The problem now showed up in ARM randconfig builds after commit 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neither VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. This adds the missing dependency. Signed-off-by: Arnd Bergmann --- This is identical to v1 of the patch. We had gone through several iterations of this in October before concluding that everything else was more problematic. Please apply. diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 5f692ae40749..04a720686516 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,6 +499,7 @@ config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI depends on ISA || EISA || PCI + depends on ISA_DMA_API || !ISA help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 19 Nov 2015 15:22:23 +0100 Subject: [PATCH v3] scsi: advansys needs ISA dma api for ISA support Message-ID: <4355540.BF55dNX7U7@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The advansys drvier uses the request_dma function that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] The problem now showed up in ARM randconfig builds after commit 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neither VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. This adds the missing dependency. Signed-off-by: Arnd Bergmann --- This is identical to v1 of the patch. We had gone through several iterations of this in October before concluding that everything else was more problematic. Please apply. diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 5f692ae40749..04a720686516 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,6 +499,7 @@ config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI depends on ISA || EISA || PCI + depends on ISA_DMA_API || !ISA help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in